From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94627 invoked by alias); 13 Sep 2017 09:14:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94614 invoked by uid 89); 13 Sep 2017 09:14:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:996 X-HELO: zimbra.cs.ucla.edu Subject: Re: [PATCH 3/9] posix: Allow glob to match dangling symlinks [BZ #866] To: Adhemerval Zanella , Zack Weinberg Cc: Joseph Myers , Andreas Schwab , GNU C Library References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-4-git-send-email-adhemerval.zanella@linaro.org> <878thop5fa.fsf@linux-m68k.org> <9455e298-8c48-c42a-0ec3-ffb8d166c69b@linaro.org> <450d2eab-f21a-f90c-6210-ea638787e339@cs.ucla.edu> <403decc7-e039-9be1-fb44-25d611540156@linaro.org> <7bf58b8a-afc9-b934-9a4a-1616e71c03ff@cs.ucla.edu> <805e4d8a-de63-5253-e214-b3912ed221e3@cs.ucla.edu> <30b5f782-8fb0-5b38-3b4c-6ebf435bc91c@linaro.org> From: Paul Eggert Message-ID: <95745cd2-0033-8a3c-92af-879c24d0d396@cs.ucla.edu> Date: Wed, 13 Sep 2017 09:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <30b5f782-8fb0-5b38-3b4c-6ebf435bc91c@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-09/txt/msg00536.txt.bz2 Adhemerval Zanella wrote: > Another approach that does not involve adding compat symbols (which adds > a lot of code complexity inside glibc build and do not solve 'make' builds > against new glibc) would to make GLOB_ALTDIRFUNCS to follow the old seman= tic > of using gl_stat instead of gl_lstat while making glob without GLOB_ALTDI= RFUNCS > works as intended. And add another flag, GLOB_ALTDIRFUNCS2, which actual= ly > uses gl_lstat. Although that's clever, it is a gratuitous source-code incompatibility with= BSD,=20 which is not a good thing. To some extent it's just GLOB_FOLLOW and=20 GLOB_NOFOLLOW in disguise, and disguise is not a good thing in APIs. So I t= hink=20 I still prefer the compat symbol approach. We'll get GNU 'Make' fixed, and I wouldn't worry overly much about people=20 building unpatched 'Make' with new glibc. I filed a Make bug report is here: http://lists.gnu.org/archive/html/bug-make/2017-09/msg00014.html