From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24819 invoked by alias); 3 Apr 2018 09:02:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24724 invoked by uid 89); 3 Apr 2018 09:02:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Stefan, stefan X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [hurd,commited] hurd: Avoid more libc.so local PLTs To: libc-alpha@sourceware.org References: <20180403003817.21337-1-samuel.thibault@ens-lyon.org> <20180403082029.g3bfw4upbti67wwz@var.youpi.perso.aquilenet.fr> From: Stefan Liebler Date: Tue, 03 Apr 2018 09:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180403082029.g3bfw4upbti67wwz@var.youpi.perso.aquilenet.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18040309-0040-0000-0000-00000429C727 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18040309-0041-0000-0000-0000262CF373 Message-Id: <95b0834b-d041-a4e5-ef47-97ae65fe1956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-04-03_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804030098 X-SW-Source: 2018-04/txt/msg00051.txt.bz2 On 04/03/2018 10:20 AM, Samuel Thibault wrote: > Andreas Schwab, on mar. 03 avril 2018 10:10:21 +0200, wrote: >> On Apr 03 2018, Samuel Thibault wrote: >> >>> * hurd/catch-signal.c (__hurd_catch_signal): Call __libc_siglongjmp >>> instead if siglongjmp. >>> (hurd_safe_memmove): Call __libc_longjmp instead of longjmp. >>> * hurd/hurdfault.c (faulted): Call __libc_longjmp instead of longjmp. >>> * include/setjmp.h (__libc_siglongjmp, __libc_longjmp): New hidden >>> prototypes. >>> * libio/iolibio.h (_IO_puts): New hidden prototype. >>> * libio/ioputs.c (_IO_puts): New hidden def. >>> * setjmp/longjmp.c (__libc_longjmp, __libc_siglongjmp): New hidden >>> defs. >>> * sysdeps/mach/hurd/sigwait.c (__sigwait): Call __libc_longjmp instead >>> of longjmp. >> >> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/s/s390x >> >> In file included from :0:0: >> ../sysdeps/s390/longjmp.c:35:34: error: '__libc_longjmp' aliased to undefined symbol '__libc_siglongjmp' >> strong_alias (__libc_siglongjmp, __libc_longjmp) >> ^ >> ./../include/libc-symbols.h:135:26: note: in definition of macro '_strong_alias' >> extern __typeof (name) aliasname __attribute__ ((alias (#name))); >> ^~~~~~~~~ >> ../sysdeps/s390/longjmp.c:35:1: note: in expansion of macro 'strong_alias' >> strong_alias (__libc_siglongjmp, __libc_longjmp) > > Ah, there is #define __libc_siglongjmp magic here indeed. Does the > attached patch fix it? > > Samuel > Yes. This patch fixes the issue on s390x. Thanks. Stefan