From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129072 invoked by alias); 29 Oct 2016 03:26:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128954 invoked by uid 89); 29 Oct 2016 03:26:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=UD:iso-2022-cn-ext.c, sk:iso202, slen, sk:iso-202 X-HELO: mail-qt0-f181.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=c9SzaAIRKxJOEb3e8DmCgk4vNctF5FZwlFjaUq88JIE=; b=gQrJBKedNCu6BTHjq2oPFYl3xO8AVhsYCFuShagOZUkllFH4E/YDP6bQihcU7ixobn W2+nWP5pRJPu1pL7lXU4YIGtJLFvLmLAnq/NMZz5c/3gFpJ/PvEAnwjxge4jo0AgoLoE l8AequD3KMh5jcYT0xXNx+PDecC9hfIe9UiNWfHpIGEfWW/Mg2CThXpwbCmF3umYFmTG d4HD0LGt1nocmHgmtYVIOt53OYtxF2koQ7X+dtgtHFGx6/ExsV2j0uYt05XONbnvO6yd OkA/YqJnGkj5kjYMhF1MsxzFelMwii3Kt7q/2+5MHBT5qdZ0MF8B1yU34NwE+Q2/unJf MiTQ== X-Gm-Message-State: ABUngveavzjdNXwpPstXi/0gegTGVdU/b5ZV3/2Z//iZLqo6Q1cAr5brra6BGvpinSoIngBS X-Received: by 10.237.48.37 with SMTP id 34mr14322595qte.111.1477711565187; Fri, 28 Oct 2016 20:26:05 -0700 (PDT) Subject: Re: [PATCH v3] Fix -Os related build and test failures. To: Joseph Myers References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> Cc: Florian Weimer , GNU C Library From: Carlos O'Donell Message-ID: <96997355-530d-98bd-64b4-1d931cd61692@redhat.com> Date: Sat, 29 Oct 2016 03:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00582.txt.bz2 On 10/28/2016 10:57 PM, Carlos O'Donell wrote: > OK? > > 2016-10-28 Carlos O'Donell > > [BZ #20729] > * include/libc-internal.h (DIAG_IGNORE_Os_NEEDS_COMMENT): > Define. > * iso-2022-cn-ext.c: Include libc-internal.h and ignore > -Wmaybe-uninitialized for BODY macro only for -Os compiles. > * locale/weight.h (findix): Ignore -Wmaybe-uninitialized error > for seq2.back_us and seq1.back_us only for -Os compiles. > * locale/weightwc.h (findix): Likewise. > * nptl_db/thread_dbP.h: Ignore -Wmaybe-uninitialized error for > DB_GET_FIELD_ADDRESS only for -Os compiles. > * resolv/res_send (reopen): Ignore -Wmaybe-uninitialized error > for slen only for -Os compiles. > * string/strcoll_l.c (get_next_seq): Ignore > -Wmaybe-uninitialized for seq2.save_idx and seq1.save_idx only > for -Os compiles. > > +/* Similar to DIAG_IGNORE_NEEDS_COMMENT the following macro ignores the > + diagnostic OPTION but only if optimizations for size are enabled. > + This is required because different warnings may be generated for > + different optimization levels. For example a key piece of code may > + only generate a warning when compiled at -Os, but at -O2 you could > + still want the warning to be enabled to catch errors. In this case > + you would use DIAG_IGNORE_Os_NEEDS_COMMENT to disable the warning > + only for -Os. */ > +#if __OPTIMIZE_SIZE__ > +#define DIAG_IGNORE_Os_NEEDS_COMMENT(version, option) \ > + _Pragma (_DIAG_STR (GCC diagnostic ignored option)) > +#else > +#define DIAG_IGNORE_Os_NEEDS_COMMENT(version, option) > +#endif Typo. s/if/ifdef/g, since __OPTIMIZE_SIZE__ is not defined at -O2. Fixed. -- Cheers, Carlos.