From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id DF61B385E019 for ; Thu, 7 Apr 2022 13:51:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF61B385E019 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 237COY6l031182 for ; Thu, 7 Apr 2022 13:51:58 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f9vtx69pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Apr 2022 13:51:58 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 237DhKli007055 for ; Thu, 7 Apr 2022 13:51:56 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma01fra.de.ibm.com with ESMTP id 3f6e490896-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Apr 2022 13:51:56 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 237Dq28747186400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Apr 2022 13:52:02 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 339C4A4051 for ; Thu, 7 Apr 2022 13:51:54 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0FE0BA4040 for ; Thu, 7 Apr 2022 13:51:54 +0000 (GMT) Received: from [9.145.48.180] (unknown [9.145.48.180]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP for ; Thu, 7 Apr 2022 13:51:53 +0000 (GMT) Message-ID: <97c52751-89ff-fc73-ab5c-d862323c562a@linux.ibm.com> Date: Thu, 7 Apr 2022 15:51:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] S390: Fix elf/tst-audit25[ab] Content-Language: en-US To: libc-alpha@sourceware.org References: <20220407115948.1664232-1-stli@linux.ibm.com> From: Stefan Liebler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Zg7KtYoYnxARwIsFWUKlXCZ9QsQkoiKU X-Proofpoint-GUID: Zg7KtYoYnxARwIsFWUKlXCZ9QsQkoiKU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-07_01,2022-04-07_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxscore=0 bulkscore=0 mlxlogscore=953 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204070065 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 13:52:01 -0000 On 07/04/2022 15:36, Adhemerval Zanella via Libc-alpha wrote: > > > On 07/04/2022 08:59, Stefan Liebler via Libc-alpha wrote: >> If glibc is configured with --disable-default-pie and build on >> s390 with -O3, the tests elf/tst-audit25a and elf/tst-audit25b are >> failing as there are additional la_symbind lines for free and malloc. >> It turns out that those belong to the executable. In fact those are >> the PLT-stubs. Furthermore la_symbind is also called for calloc and >> realloc symbols, but those belong to libc. >> >> Those functions are not called at all, but dlsym'ed in >> elf/dl-minimal.c: >> __rtld_malloc_init_real (struct link_map *main_map) >> { >> ... >> void *new_calloc = lookup_malloc_symbol (main_map, "calloc", &version); >> void *new_free = lookup_malloc_symbol (main_map, "free", &version); >> void *new_malloc = lookup_malloc_symbol (main_map, "malloc", &version); >> void *new_realloc = lookup_malloc_symbol (main_map, "realloc", &version); >> ... >> } >> >> Therefore, this commit just ignored symbols with LA_SYMB_DLSYM flag. > > LGTM, thank. Why don't we see in other configuration and/or architecture? > What s390 is doing different here? > > Reviewed-by: Adheemrval Zanella > Thanks. Then I'll commit the patch. You are right I have not seen it on x86_64. Perhaps it triggers something in s390x-code in ld regarding -Bsymbolic and pointer-equality-reasons. But this is only a guess. Thanks, Stefan