From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id 03674385781D for ; Mon, 29 Mar 2021 21:04:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03674385781D Received: by mail-qv1-xf2d.google.com with SMTP id x16so7177770qvk.3 for ; Mon, 29 Mar 2021 14:04:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lZRBw6mgG6MSe8DTsTg0ZBfc7T2R6fgdqes0ZEwr/VE=; b=WFrIw4v/ZWSKFJCOZkCpR0Rc2gPVP7kAOqK+GdOzHKU3arUtU8Y7RCRigThVqD0mqF Cl5sO3Bjb9QVZY1a3gSfRRMO/mzQ82UpPsadX2BTK9N+PFXSF5mar5lGAJgJPtDhJLyq Z627lDwGHsIQ06LWA/tBawdu6juN8iQ90Wmd/G/KBc8AYApnGQ/V6ofvNTBAjIldlcz0 XMF0fyMpthGeEFnw/9YKzal8CgKvW1UiTwJxcfOjgAHL3QzIJDCLESJB99t8a/ZCakW4 1al8Q3Ofo3sagzz+GoIGsrRVbmgDxqblA9ysopEdTyWLDTHTaMz2fIFFv8n02lVAQAL7 +Qzw== X-Gm-Message-State: AOAM533ZbF0jYUxjVaoQKrD5YWrEOQbrfvlMzRHwiqZdLCKGiX5fiJpW G8IbftSqytIQf0yO53AbD3p0cr0VoIrPHIFN X-Google-Smtp-Source: ABdhPJy6JNfY7wni6GglP6S57heNi5Q6Q/7zRNoLSmghioJ9oHVF4eBsVTfAzmlfldUBf3BhbXQBbw== X-Received: by 2002:a0c:ed2c:: with SMTP id u12mr27531800qvq.30.1617051863451; Mon, 29 Mar 2021 14:04:23 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id z4sm14440138qkb.94.2021.03.29.14.04.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 14:04:23 -0700 (PDT) Subject: Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment To: Alejandro Colomar , libc-alpha@sourceware.org References: <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> <20210324182915.29042-1-alx.manpages@gmail.com> From: Adhemerval Zanella Message-ID: <97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org> Date: Mon, 29 Mar 2021 18:04:20 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210324182915.29042-1-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 21:04:25 -0000 On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: > 'this' can be understood as the current parameter, but in this case it > is meaning the other one, the one holding the width/precission. > > 'it' better describes that parameter, differentiating it from the > one corresponding to the current specifier. > > Signed-off-by: Alejandro Colomar We don't use SCO, but rather Copyright assignment. The rest looks good to me (although I am not a native speaker). Reviewed-by: Adhemerval Zanella > --- > stdio-common/printf-prs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c > index 1d4e00553d..8ebf09a0a9 100644 > --- a/stdio-common/printf-prs.c > +++ b/stdio-common/printf-prs.c > @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) > /* Parse this spec. */ > nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); > > - /* If the width is determined by an argument this is an int. */ > + /* If the width is determined by an argument, it is an int. */ > if (spec.width_arg != -1 && (size_t) spec.width_arg < n) > argtypes[spec.width_arg] = PA_INT; > > - /* If the precision is determined by an argument this is an int. */ > + /* If the precision is determined by an argument, it is an int. */ > if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) > argtypes[spec.prec_arg] = PA_INT; > >