From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id 24C5D3858002 for ; Tue, 7 Sep 2021 14:04:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24C5D3858002 Received: by mail-qv1-xf2a.google.com with SMTP id p17so5833518qvo.8 for ; Tue, 07 Sep 2021 07:04:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SIOdufyMnE9N/PWYjLY1PGwiJ5YUB6PPMJzUj6MNMjk=; b=IEUPOIbt41cdFh60LC8o5fc0BlDSpWZC4d4gxHStbHTVfkMme9P5AMARM1DC5q7ebq fwLDcOgcTont7IFPNjACc6+BSQTdow6GGAP7zSkZIC8wo+s1t70vcY2pWzCdYxqFUlXA ayfDSZjXxOrIQHHjEyf3T3ifGwb+f2Axd65XhhXRhxtOL6Qam/SOPfMGrzRgLRZYzVgF i7WUJb/kDmA6zb+t6R7SruwsrpfTFCUbc1J7e+bhRsWfjM2eQE3TNqJxnt9GNcz2Q849 vvANOVML7MzU7zNOiiCR7AEgm9vFAzXB4IokwW2cfvMLg6yxmCEObIUhLS/3AzCwM8S1 kmaw== X-Gm-Message-State: AOAM530g2bzMK6Rb0HxbC7NrSOZ5S/uiCGEJIRDpalSw3/W4zzdr22wU ILJPp6p0Zb6ZndfzpE4NF+doNN4iNsHh1Q== X-Google-Smtp-Source: ABdhPJzpu8IPMJasVCXYxZZtk+AdOU/p1tPiyz8RemoF1DIgZC/BMhpW1++NC0cA6KB9NT17Ts+a0Q== X-Received: by 2002:a0c:ffca:: with SMTP id h10mr16828399qvv.15.1631023449662; Tue, 07 Sep 2021 07:04:09 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:733d:f360:5bf3:9813:d8f5? ([2804:431:c7cb:733d:f360:5bf3:9813:d8f5]) by smtp.gmail.com with ESMTPSA id s16sm7298852qtq.31.2021.09.07.07.04.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 07:04:09 -0700 (PDT) Subject: Re: [PATCH] MIPS: Setup errno for {f,l,}xstat To: YunQiang Su Cc: Jiaxun Yang , libc-alpha@sourceware.org, Xi Ruoyao References: <20210907053142.1774-1-jiaxun.yang@flygoat.com> <43d37c1b-6efc-c688-cc4a-f6514ff3c6b8@linaro.org> From: Adhemerval Zanella Message-ID: <97f9be81-c182-d1f3-29eb-5616831c3cfa@linaro.org> Date: Tue, 7 Sep 2021 11:04:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 14:04:13 -0000 On 07/09/2021 10:20, YunQiang Su wrote: > > > Adhemerval Zanella > 于 2021年9月7日周二 下午9:15写道： > > > > On 07/09/2021 02:31, Jiaxun Yang wrote: > > {f,l,}xstat stub for MIPS is using INTERNAL_SYSCALL > > to do xstat syscall for glibc ver, However it leaves > > errno untouched and thus giving bad errno output. > > > > Setup errno properly when syscall returns non-zero. > > > > Signed-off-by: Jiaxun Yang > > > > LGTM, thanks.  I fixed the code style (using space instead of > tabs as the current file is doing) and pushed upstream. > > > this problem introduced in 2.33. > is it possible to backport it to 2.33 and 2.34? Done.