From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 7/7] misc: syslog: Use RFC5424
Date: Mon, 21 Feb 2022 13:18:39 -0300 [thread overview]
Message-ID: <980d5ae5-d541-1550-87e5-851223736512@linaro.org> (raw)
In-Reply-To: <da8f1cc9-e661-980c-b179-7a8e15f3eae2@linaro.org>
On 21/02/2022 11:01, Adhemerval Zanella wrote:
>
>
> On 19/02/2022 00:50, Paul Eggert wrote:
>>> + else
>>> + {
>>> + size_t datebytes = __strftime_l (timebuf->b, sizeof timebuf->b,
>>> + "%FT%T", gmtm, _nl_C_locobj_ptr);
>> RFC 5424 does not allow leap seconds, so something like this:
>>
>> if (gmtm->tv_sec == 60)
>> {
>> gmtm->tv_sec = 59;
>> gmtm->tv_nsec = 999999999;
>> }
>>
>> before calling __strftime_l. (Or again, if the idea is to depart from RFC 5424, document the departure.)
>
> I think this is worth to support, I will add such test.
In fact struct tm does not 'tv_nsec' so I am confused about your suggestion here.
next prev parent reply other threads:[~2022-02-21 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 14:23 [PATCH v2 0/7] Use RFC5424 for syslog Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 1/7] support: Add xmkfifo Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 2/7] misc: Add syslog test Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 3/7] misc: syslog: Fix indentation and style Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 4/7] misc: syslog: Simplify implementation Adhemerval Zanella
2022-02-19 3:15 ` Paul Eggert
2022-02-21 13:15 ` Adhemerval Zanella
2022-02-21 22:25 ` Paul Eggert
2022-02-21 14:06 ` Andreas Schwab
2022-02-21 22:23 ` Paul Eggert
2022-02-18 14:23 ` [PATCH v2 5/7] misc: syslog: Use static buffer Adhemerval Zanella
2022-02-19 3:45 ` Paul Eggert
2022-02-21 13:31 ` Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 7/7] misc: syslog: Use RFC5424 Adhemerval Zanella
2022-02-19 3:50 ` Paul Eggert
2022-02-21 14:01 ` Adhemerval Zanella
2022-02-21 16:18 ` Adhemerval Zanella [this message]
2022-02-21 22:25 ` Paul Eggert
2022-02-19 20:35 ` Dan Raymond
2022-02-19 22:23 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980d5ae5-d541-1550-87e5-851223736512@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).