diff --git a/nis/nss_nisplus/nisplus-parser.c b/nis/nss_nisplus/nisplus-parser.c index 8dc021e73d..4714a3085a 100644 --- a/nis/nss_nisplus/nisplus-parser.c +++ b/nis/nss_nisplus/nisplus-parser.c @@ -82,7 +82,7 @@ _nss_nisplus_parse_pwent (nis_result *result, struct passwd *pw, char *numstr = NISOBJVAL (2, obj); len = NISOBJLEN (2, obj); - if (len == 0 && numstr[len - 1] != '\0') + if (len != 0 && numstr[len - 1] != '\0') { if (len >= room_left) goto no_more_room; @@ -91,14 +91,14 @@ _nss_nisplus_parse_pwent (nis_result *result, struct passwd *pw, first_unused[len] = '\0'; numstr = first_unused; } - if (numstr[0] == '\0') + if (len == 0 || numstr[0] == '\0') /* If we don't have a uid, it's an invalid shadow entry. */ return 0; pw->pw_uid = strtoul (numstr, NULL, 10); numstr = NISOBJVAL (3, obj); len = NISOBJLEN (3, obj); - if (len == 0 && numstr[len - 1] != '\0') + if (len != 0 && numstr[len - 1] != '\0') { if (len >= room_left) goto no_more_room; @@ -107,7 +107,7 @@ _nss_nisplus_parse_pwent (nis_result *result, struct passwd *pw, first_unused[len] = '\0'; numstr = first_unused; } - if (numstr[0] == '\0') + if (len == 0 || numstr[0] == '\0') /* If we don't have a gid, it's an invalid shadow entry. */ return 0; pw->pw_gid = strtoul (numstr, NULL, 10);