From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1CF9A385BF9E for ; Fri, 10 Dec 2021 14:19:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1CF9A385BF9E Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-9rUO1Ap6OcumGxdexG7hww-1; Fri, 10 Dec 2021 09:19:09 -0500 X-MC-Unique: 9rUO1Ap6OcumGxdexG7hww-1 Received: by mail-io1-f70.google.com with SMTP id g23-20020a6be617000000b005e245747fb4so10193972ioh.15 for ; Fri, 10 Dec 2021 06:19:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=E8pbxr/YUDqAAKHx5PV3OKmYRT1D9AwwY0U7lZgZAtA=; b=Q7KniQnh1Vk8MLLYNvzomrTH5D4l0d4IHqkwOrcB6a2oVEPOsARrVQZhXiqCxy9WHg Ne5YnGBhbBhx5Arq4WGtAC0Cb48EpNsM1qzJFoBeK72l8b3OI0NBP+pse1FLoXNyxLyA 2BS8voFlz+d0eYqyEx2C5a60YsIaUfL6hzg4o/RJaR41QtLUgLClKdKDx1k+L3y7cBf2 ImnzWwH4rds7L9HFUp0J+L6WAwr2i0l5VPuUJe4PYLpjgVO8A5XNfrIfTXvxooGe2OFx PIpr5AfIMJX1EDpKgF9+sahdu1iFglXQYzcdI7UY29dZ8wt3LVjCbgmZlsVeMHQXj7/u FatQ== X-Gm-Message-State: AOAM530wWTiG6eoF5C8Zdrj+QNRrTCTZ//2goIkFDkWOz63D5vcogIsj kN8W5sw5vzwyy3Sx4VJlP6EjKuRKhimYIFngv2hK/DIqpMDRhDz2ihP/yaiXPHUgofJKGmeSWBv 5j0RJ9aW1drBPWmb/sFZc X-Received: by 2002:a92:c68c:: with SMTP id o12mr22888691ilg.256.1639145948892; Fri, 10 Dec 2021 06:19:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTIaFppYKUWT1HvYsE8/X7MbPXAj6vQEr42vJzWtijzMR+DEbcCVzAm9eB0aaBClw8TNCVOg== X-Received: by 2002:a92:c68c:: with SMTP id o12mr22888672ilg.256.1639145948604; Fri, 10 Dec 2021 06:19:08 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id d3sm2155475ilu.28.2021.12.10.06.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 06:19:08 -0800 (PST) Message-ID: <98408068-60c1-3073-42a4-93073f7afeba@redhat.com> Date: Fri, 10 Dec 2021 09:19:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3] elf: Install a symbolic link to ld.so as /usr/bin/ld.so To: Florian Weimer , libc-alpha@sourceware.org References: <8735n0dc4a.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <8735n0dc4a.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 14:19:14 -0000 On 12/10/21 04:48, Florian Weimer via Libc-alpha wrote: > This makes ld.so features such as --preload, --audit, > and --list-diagnostics more accessible to end users because they > do not need to know the ABI name of the dynamic loader. I've seen Andreas Schwab comment on this and provided feedback. You have addressed that feedback and so overall this looks good. I see rough consensus on the Debian thread for this change here: https://mailman-int.corp.redhat.com/archives/tools-patches/2021-December/msg00013.html At a high level this makes things objectively better. You always have the ability to call ld.so and get a loader that you can call regardless of the architecture and regardless of the version of the installer runtime. This allows downstreams to write generic support code that can use features like --list-diagnostics which provide valuable feedback to support teams. LGTM. Reviewed-by: Carlos O'Donell > --- > v2: Use $(make-link). > v3: Update NEWS entry. > > NEWS | 3 +++ > elf/Makefile | 7 ++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 8744a92532..3a04befe8e 100644 > --- a/NEWS > +++ b/NEWS > @@ -79,6 +79,9 @@ Major new features: > variables. The GNU C Library manual has details on integration of > Restartable Sequences. > > +* A symbolic link to the dynamic linker is now installed under > + /usr/bin/ld.so (or more precisely, '${bindir}/ld.so'). OK. > + > Deprecated and removed features, and other changes affecting compatibility: > > * The r_version update in the debugger interface makes the glibc binary > diff --git a/elf/Makefile b/elf/Makefile > index ef36008673..d0bb0daa7e 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -110,7 +110,7 @@ endif > ifeq (yes,$(build-shared)) > extra-objs = $(all-rtld-routines:%=%.os) sofini.os interp.os > generated += librtld.os dl-allobjs.os ld.so ldd > -install-others = $(inst_rtlddir)/$(rtld-installed-name) > +install-others = $(inst_rtlddir)/$(rtld-installed-name) $(inst_bindir)/ld.so OK. > install-bin-script = ldd > endif > > @@ -692,6 +692,11 @@ $(inst_rtlddir)/$(rtld-installed-name): $(objpfx)ld.so $(+force) > $(make-target-directory) > $(do-install-program) > > +# Creates the relative /usr/bin/ld.so symbolic link. > +$(inst_bindir)/ld.so: $(inst_rtlddir)/$(rtld-installed-name) > + $(make-target-directory) > + $(make-link) > + OK. > # Special target called by parent to install just the dynamic linker. > .PHONY: ldso_install > ldso_install: $(inst_rtlddir)/$(rtld-installed-name) > -- Cheers, Carlos.