From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id D0DFD395C012 for ; Fri, 8 Jan 2021 09:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0DFD395C012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EF4A6342A7E; Fri, 8 Jan 2021 09:09:08 +0000 (UTC) Received: from pdx1-sub0-mail-a10.g.dreamhost.com (100-98-64-116.trex.outbound.svc.cluster.local [100.98.64.116]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 60EEE342D00; Fri, 8 Jan 2021 09:09:08 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a10.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Fri, 08 Jan 2021 09:09:08 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Macabre-Spot: 641e20463a345a1f_1610096948681_2258122598 X-MC-Loop-Signature: 1610096948681:3934222628 X-MC-Ingress-Time: 1610096948681 Received: from pdx1-sub0-mail-a10.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTP id 0C3527F012; Fri, 8 Jan 2021 01:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=gL16HK lWJsTxSAnlGT+2Hb4WI20=; b=YE+8CWoV16RnzA+41xVh0D+yVy6sriUvLYtsrk rn67z2bJ5Cpxbtg0U2yEPc/HtymSIwktEVGpvtj9+zdg8dXL4JG+IyRDjAzaGTEs n32cDsxX2+cQ19zJrMK89NTThNwa+W28czDYNK0mCf2O95Tn+EFSjTa4RKd9V0Nw eyK0k= Received: from [192.168.86.152] (unknown [103.199.172.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTPSA id D4BD47ED6A; Fri, 8 Jan 2021 01:09:05 -0800 (PST) Subject: Re: [PATCH] correct readlinkat attribute access (BZ #27024) To: Samuel Thibault Cc: Martin Sebor , GNU C Library References: <42f6934f-da58-0d1c-d953-4504ba240a42@gotplt.org> <20210108090602.w5voa66jvgrqr7tz@function> X-DH-BACKEND: pdx1-sub0-mail-a10 From: Siddhesh Poyarekar Message-ID: <986eaf7a-25b1-5aa8-0ae4-e6e63057ece3@gotplt.org> Date: Fri, 8 Jan 2021 14:38:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108090602.w5voa66jvgrqr7tz@function> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 09:09:12 -0000 On 1/8/21 2:36 PM, Samuel Thibault wrote: >> Why do we need an access attribute at all for __len, let alone a >> __write_only__ one? > > ? This is not on __len, this is on __buf (arg 3) for __len bytes (arg 4) > Ugh, sorry I misread that. Siddhesh