From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 13E913856DD5 for ; Sat, 3 Jun 2023 02:12:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13E913856DD5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685758326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RXZPYb+VDROMEHYVDLIN2M1mwcgakqOSUqJYLsH3gKA=; b=I3TdGJcL4TMJamvH8Dcm9w1zFoKf76PUE2OiEnhyiIpLt2aeCOPUKWuQPbRqAS1/Aul9TM 79b1shX0Cgc8cjqTFt2HKMZwJImOOAxpEmj5ZPFYh/79Y1oc3+GQVOzLtOfDNMcK7XXXlj KsQ2wNfXk0SUsNwS7qlFkfFLbyEU4Yg= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-Hujjz8WqNj-9P_g2QT_9_g-1; Fri, 02 Jun 2023 22:12:04 -0400 X-MC-Unique: Hujjz8WqNj-9P_g2QT_9_g-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-5693861875fso32198747b3.1 for ; Fri, 02 Jun 2023 19:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685758323; x=1688350323; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RXZPYb+VDROMEHYVDLIN2M1mwcgakqOSUqJYLsH3gKA=; b=kVgjaghMyVxbIcKzXs3scQBUHXXOCZ2dH5XTVx6Kx3u2YEqgGvAuczJmPzrEtja+NF 6XgyHb4LL0QIYtQI65s4hmChtsSVwZdsjyEquc2Nbo1VOcsGbW49nOAt9WRJUczSPZeq 2WY6h9BROfPBi2JbZZ5fsPYbFQfU/arSBOf1ZI+9VFxKXf0piqvdhJlPv3Gj6ydk9y5w Eg75+3j2YiVwB/PNLod4m8rSZkImrbG5SDKlvL4tw9Uk132zJffeLG3m3IXwj+YT3AHE VSX5XORdMGYgixVvFgIhDAkrgK6VKQbPgHaXivFY8n0hmCOmSQAm0/ie1LDFiWlfygP4 DVOw== X-Gm-Message-State: AC+VfDz80G5r4MNgwCaSqOQ5fcfSBjXVdsxyJyXWnP87OIN4EMODzp0t /+b5w8fPMScJRjBGw/9BSAXVTNYPrFSlQBH/EFcfm1jypx+yfErEjykz+XHWQMmwcACN0G0IyoH qtl6EAbHwIlpEKIQt9rhLxLhVkqef X-Received: by 2002:a0d:ca89:0:b0:561:dd1b:e516 with SMTP id m131-20020a0dca89000000b00561dd1be516mr1972839ywd.35.1685758322719; Fri, 02 Jun 2023 19:12:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5bh6XxbldPtMxfpXCDwqmJquIfN7T9u2Yg1RY9MmoCQWW1NBhzTziraZ2IqVOiAhiHJVVZZw== X-Received: by 2002:a0d:ca89:0:b0:561:dd1b:e516 with SMTP id m131-20020a0dca89000000b00561dd1be516mr1972829ywd.35.1685758322519; Fri, 02 Jun 2023 19:12:02 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id o66-20020a0dfe45000000b00555c30ec361sm1012678ywf.143.2023.06.02.19.12.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 19:12:02 -0700 (PDT) Message-ID: <98a2aed5-9fd3-1da2-b023-da8f43ea5e6d@redhat.com> Date: Fri, 2 Jun 2023 22:12:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/2] Add lint-makefiles Makefile linting test. To: Florian Weimer Cc: libc-alpha@sourceware.org, alx.manpages@gmail.com References: <20230530133212.3935551-1-carlos@redhat.com> <20230530133212.3935551-2-carlos@redhat.com> <87sfberl26.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87sfberl26.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/30/23 09:44, Florian Weimer wrote: > * Carlos O'Donell: > >> We add a 'make check' test that lints all Makefiles in the source >> directory of the glibc build. This linting test ensures that the >> lines in all Makefiles will be sorted correctly as developers >> creates patches. It is added to 'make check' because it is >> light-weight and supports the existing developer workflow >> >> The test adds ~3s to a 'make check' execution. >> >> No regressions on x86_64 and i686. >> --- >> v3: Print nothing on success. Use diff -u. Use output as fixit patch. >> Makefile | 10 ++++++ >> scripts/lint-makefiles.sh | 74 +++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 84 insertions(+) >> create mode 100644 scripts/lint-makefiles.sh > > This version looks okay to me. > > Reviewed-by: Florian Weimer Thanks! Pushed. Looking forward to more cleaned up Makefiles :-) There are still 190+ left to review :> -- Cheers, Carlos.