From: Stefan Liebler <stli@linux.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] build-many-glibcs.py: Add some s390x glibc variants.
Date: Wed, 12 Aug 2020 16:22:09 +0200 [thread overview]
Message-ID: <98c09e71-ab19-edf9-90d4-4e22b4e1e5f7@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2008101715320.16471@digraph.polyomino.org.uk>
On 8/10/20 7:23 PM, Joseph Myers wrote:
> On Mon, 10 Aug 2020, Stefan Liebler via Libc-alpha wrote:
>
>> Here, conformtest.py is running something like this:
>> echo "#include <stdio.h>" > tst.c
>> s390x-glibc-linux-gnu-gcc -O3 -I../include ... -I.. -fno-builtin -ansi
>> -D_XOPEN_SOURCE -D_ISOMAC -E tst.c -P -Wp,-dN
>> => The output contains the __USE_EXTERN_INLINES from
>> <glibc>/libio/bits/stdio.h for getc_unlocked, getchar_unlocked,
>> putc_unlocked and putchar_unlocked.
>
> So this should be reported as a bug in Bugzilla; the inline functions
> ought to have the same feature test macro conditionals as the main
> declarations (i.e. __USE_POSIX199506).
I've created the bugzilla:
"Bug 26376 - Namespace violation in stdio.h and sys/stat.h if build with
optimization."
https://sourceware.org/bugzilla/show_bug.cgi?id=26376
and posted this patch:
"[PATCH] Fix namespace violation in stdio.h and sys/stat.h if build with
optimization. [BZ #26376]"
https://sourceware.org/pipermail/libc-alpha/2020-August/116979.html
>
>> Is there a reason, why ...
>> - scripts/build-many-glibcs.py configures glibc with
>> CC="<target-triple>-gcc <ccopts>" instead of CC="<target-triple>-gcc"
>> CFLAGS="<ccopts>" CXX/CXXFLAGS? If build-many-glibcs.py is configuring
>> the glibc with the FLAGS, the the "make check" for the O3 extra-glibc is
>> passing.
>
> The general principle is that all options required in all compilations,
> including ABI options, should go in CC, while options that might get
> overridden in some cases go in CFLAGS. -g and -O options belong in
> CFLAGS. build-many-glibcs.py doesn't currently have a mechanism for
> overriding CFLAGS (when testing -Os builds I hardcoded a CFLAGS setting
> for all builds). It probably does make sense to include some -O3 and -Os
> builds (with some new mechanism to change CFLAGS) by default, so we know
> when those break.
I've just posted this patch:
"[PATCH] build-many-glibcs.py: Add a s390x -O3 glibc variant."
https://sourceware.org/pipermail/libc-alpha/2020-August/116980.html
>
>> - conform/conformtest.py is called without the configured CFLAGS and
>> thus without optimization? I assume one reason is -Wall -Werror.
>
> There are lots of other variants that could meaningfully be tested with
> conformtest.py and linknamespace.py. Enabling optimization is one,
> _FILE_OFFSET_BITS=64 is another that's known to have namespace problems
> (bug 14106). It's useful to know about failures when someone runs tests
> with different options, but less clear exactly what variants should be
> tested by default.
>
Thanks,
Stefan
prev parent reply other threads:[~2020-08-12 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 14:45 Stefan Liebler
2020-08-05 15:39 ` Florian Weimer
2020-08-05 17:53 ` Adhemerval Zanella
2020-08-06 7:51 ` Stefan Liebler
2020-08-06 8:34 ` Florian Weimer
2020-08-10 15:34 ` Stefan Liebler
2020-08-10 17:23 ` Joseph Myers
2020-08-12 14:22 ` Stefan Liebler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c09e71-ab19-edf9-90d4-4e22b4e1e5f7@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).