From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brown.birch.relay.mailchannels.net (brown.birch.relay.mailchannels.net [23.83.209.23]) by sourceware.org (Postfix) with ESMTPS id 6B61F3858D39 for ; Mon, 15 Nov 2021 02:34:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B61F3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 097DA200A9F; Mon, 15 Nov 2021 02:34:33 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9E189200A76; Mon, 15 Nov 2021 02:34:31 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.111.70.133 (trex/6.4.3); Mon, 15 Nov 2021 02:34:32 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Ski-Keen: 4d1bc42c00bf9c30_1636943672860_1094231411 X-MC-Loop-Signature: 1636943672860:347111986 X-MC-Ingress-Time: 1636943672860 Received: from [192.168.1.174] (unknown [1.186.223.29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4HstYy4Cpdz33; Sun, 14 Nov 2021 18:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1636943671; bh=HoM3F/0ExgXzflTULXNFu8WaKCE=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=HsmDcrok8huB+ZlRAJw3nFi3oAluy+I2//XZw1h3uQ6jzav1wtR4//DW1i+7TsEKx lpGZgkVzPVyKw5y+/7HPnfZwNA6JK+rvp/ppA/IUQVpG55mjJwA3AQ3t2gahzKhyDe UEYMk0+uoA1VQtnaKOkQ7NAdP3zv9FxLcZ8CIlfU= Message-ID: <98e3b40a-3d1f-bac9-997b-22a659a1200b@gotplt.org> Date: Mon, 15 Nov 2021 08:04:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards Content-Language: en-US To: Stafford Horne , GLIBC patches References: <20211113004047.1980486-1-shorne@gmail.com> From: Siddhesh Poyarekar In-Reply-To: <20211113004047.1980486-1-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3033.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 02:34:36 -0000 On 11/13/21 06:10, Stafford Horne wrote: > The change 1e5a5866cb ("Remove malloc hooks [BZ #23328]") has broken > ports that are using GLIBC_2_35, like the new OpenRISC port I am working > on. > > The libc_malloc_debug.so library used to bring in the debug > infrastructure is currently essentially empty for GLIBC_2_35 ports like > mine causing mtrace tests to fail: > > cat sysdeps/unix/sysv/linux/or1k/shlib-versions > DEFAULT GLIBC_2.35 > ld=ld-linux-or1k.so.1 > > FAIL: posix/bug-glob2-mem > FAIL: posix/bug-regex14-mem > FAIL: posix/bug-regex2-mem > FAIL: posix/bug-regex21-mem > FAIL: posix/bug-regex31-mem > FAIL: posix/bug-regex36-mem > FAIL: malloc/tst-mtrace. > > The issue seems to be with the ifdefs in malloc/malloc-debug.c. The > ifdefs are currently essentially exluding all symbols for ports > 2.35. > In short: > > if (SHLIB_COMPAT 2.0 -> 2.34) > debug api > inlcude .c files > implement apis > > Generate debug compat api > endif > > This fix changes this to: > > debug api > inlcude .c files > implement apis > > if (SHLIB_COMPAT 2.0 -> 2.34) > Generate debug compat api > endif What symbols does this change generate? Could you please share the output of objdump -T malloc/libc_malloc_debug.so from your build? Thanks, Siddhesh