Re: [PATCH] feat: crypt support sm3 algorithm

[Carlos O'Donell <carlos@redhat.com>]

On 7/31/22 22:53, Mingjun Yang wrote:
> This patch aim to let crypt packet support SM3 algorithms, the
> proccess of SM3 encryption is the same to this semi-formal
> SHA-crypt document (https://www.akkadia.org/drepper/SHA-crypt.txt).
> noted that this patch define that SM3 algorithms ID is 8.
> 
> SM3 algorithm is defined in section 23 of ISO/IEC 10118-3:2018
> (https://www.iso.org/standard/67116.html)
> SM3 is similar to SHA256, but its algorithm is more complex.
> SM3 is much safer than SHA256 at the same bit size.
> 
> Signed-off-by: Mingjun Yang <yangmingjun@uniontech.com>

What needs do you have that drive this requirement?

I do not want to add any new algorithms to crypt in glibc.

I would instead suggest using libxcrypt, which is an ABI-compatible drop-in
replacement for crypt APIs.

The community worked closely with libxcrypt upstream to ensure it could be
used to provide all the functions required by applications.

For example Fedora uses --disable-crypt to configure glibc and uses libxcrypt
to provide the APIs. This change was done in 2018, and so for almost 4 years
Fedora has been using libxcrypt [1].

If anything I think glibc should switch to disabling libcrypt by default
and provide --enable-legacy-crypt (or something like this) to enable the
legacy library is built and installed. This is similar to the transition we
made with SunRPC to TIRPC [2].

-- 
Cheers,
Carlos.

[1] https://fedoraproject.org/wiki/Changes/Replace_glibc_libcrypt_with_libxcrypt
[2] https://fedoraproject.org/wiki/Changes/SunRPCRemoval