From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by sourceware.org (Postfix) with ESMTPS id D7A17384D158 for ; Fri, 3 Mar 2023 13:01:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7A17384D158 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc32.google.com with SMTP id t5-20020a4ac885000000b005251f70a740so406619ooq.8 for ; Fri, 03 Mar 2023 05:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677848511; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GULqQH3KOG4myncvzQvhrqZ3VETH057lcX2LqAKxseQ=; b=XYyMsTUuMuo/Am1mxkp/djgwI2X+QfxJ5rS/JyZdUXPIra+uoNlItaY5RyepmOVtAQ mj3OfSCl7rKdP9OoCN7veq23kvaIji2lpYa40WXcutSN3/vMmRxmWFVjooMiHU3h3mHR Iz9o98+1TSHBP7iU8CT8J1JBpULieb1aGQk/2pfxVvDKdQ0BF1nf0qIm8EnsIxVKVESi ZoAR3HU9Gs8aD381WehFuLsBXp+2qV8dYMe3G7rhWkfSx3/aDD+ZSO8lRS5u+ULpzsr8 rppxkZc8QReV1e/AnfA9yGfMFD3gs7xp7a6G5awVb9uW6G2Ap7WATZkKlenTL3Vnm2lm qq6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677848511; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GULqQH3KOG4myncvzQvhrqZ3VETH057lcX2LqAKxseQ=; b=0ScnVt2tFD8Pvof7MksJKju7x7QbCO3Xz8C3wP9h724D87GmilUvnHTLdYfBuGO/Xk pt2Sgs0UFp+oNxzc46zbIASq83M+kQeBrOhtdcIScYneaCUNcc2LlMbci4TcYNMKMszT eGfswb1pFMM3uapGYmdefjQVmxQ2twpQvbDidmjInVO1MYTlKSYNIl+R28VuDdwD6fyf bQKQkJoSfG+evqMjKxxeY7xAbHkqLLgWZAB7rPnT05q8x3nP8vhfoegMUkbZV0NzOuZS OuJuxeHfiOCcP+b/V2rJ3GBYU5NnPSZnMpT/JeeIQ1YxgAODtFKlth0fpsGBWZ9t/VKt Fg2g== X-Gm-Message-State: AO0yUKXccHW4stCfVdNkozl3QBRRltLYtGdLK/CsGgKUa4sPS/cmKXhj IbKodx0Is6eAfcKxsh1FPgT/gMzDgyNB4mkPtx0= X-Google-Smtp-Source: AK7set/F5VwW4s5oDusuKUiQuI44jOKg7V+UaEum48IJEh2RfqBKyavAJ+JgR1WDMauRLzLOdRuetA== X-Received: by 2002:a4a:5284:0:b0:525:863:ea52 with SMTP id d126-20020a4a5284000000b005250863ea52mr986911oob.2.1677848510961; Fri, 03 Mar 2023 05:01:50 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:d849:65ac:94e7:b706:d532? ([2804:1b3:a7c3:d849:65ac:94e7:b706:d532]) by smtp.gmail.com with ESMTPSA id z6-20020a05683020c600b0068bcc902b82sm974193otq.71.2023.03.03.05.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 05:01:50 -0800 (PST) Message-ID: <995c5b47-d9ba-5267-b3bb-5ceec65475ca@linaro.org> Date: Fri, 3 Mar 2023 10:01:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] nptl: fix pthread_mutexattr_gettype always return 0 Content-Language: en-US To: abushwang , libc-alpha@sourceware.org, drepper.fsp@gmail.com References: <20230303063419.1874310-1-abushwangs@gmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230303063419.1874310-1-abushwangs@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/03/23 03:34, abushwang via Libc-alpha wrote: > According to posix, pthread_mutexattr_gettype will return EINVAL > when the value specified by attr is invalid. > > Signed-off-by: abushwang > --- > nptl/pthread_mutexattr_gettype.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/nptl/pthread_mutexattr_gettype.c b/nptl/pthread_mutexattr_gettype.c > index 21e0a9e946..e09dc41e76 100644 > --- a/nptl/pthread_mutexattr_gettype.c > +++ b/nptl/pthread_mutexattr_gettype.c > @@ -28,6 +28,9 @@ __pthread_mutexattr_gettype (const pthread_mutexattr_t *attr, int *kind) > *kind = (iattr->mutexkind & ~PTHREAD_MUTEXATTR_FLAG_BITS > & ~PTHREAD_MUTEX_NO_ELISION_NP); > > + if (*kind < PTHREAD_MUTEX_NORMAL || *kind > PTHREAD_MUTEX_ADAPTIVE_NP) > + return EINVAL; > + > return 0; POSIX states that pthread_mutexattr_*set*type should return EINVAL, having an invalid pthread_mutexattr_t kind means that either the application is not creating the object using pthread_mutex_init or a glibc bug that is setting the value to unspecified behavior. > } > versioned_symbol (libc, __pthread_mutexattr_gettype,