From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57801 invoked by alias); 8 May 2018 21:27:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57789 invoked by uid 89); 8 May 2018 21:27:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zdKFoQGMZYmf1x365RSA1KaXnJEactsw4Qw35h9GbBw=; b=PPuQkgOLm/DmGfqIuwIXQDo0rOwrpLjIz/AlTd5AyAmBub73SvDI8d7q4SCRecm9ZB BoWKS+Qvcmv/IBnzP/oxlGcGr2sfVPZAHdwcdmOSXNpUxKEUqe0AR6iIZ92d9HjsiTbw lmGginjO+CKnLgQUDTJmwoXneTduWPrQns9YciX/kqlJVaQeofGudVnQXr3T2t3JXeGs UEEK/xTL1VBjk7ojyPQpA0c9eC02QArS8cO1/VjRsk86UMmII5EHsTBM2P+u4kYOh7m9 Qm7vv3Z0S7CDQoKsdsNvLBB/mjZsrk2tJQBBDYB2oJMNWQ+CcIe60hYgaG2ZjGYq1y12 u+yg== X-Gm-Message-State: ALQs6tDosrCWH/pcSDQVPv14h4LigvwCUtSKCR59FYHRPZfNZ52xu1nB 8Z6/ul8PjaV/qTnGqqw+z005ttyEvSE= X-Google-Smtp-Source: AB8JxZoIZb2DG+/I++yUtTuzZQzNsthVJKrhC7lkFwNwj4c81Y0CnTI9Ej502h0fkBVMFBMvFQgOug== X-Received: by 10.55.121.133 with SMTP id u127mr27759328qkc.272.1525814841659; Tue, 08 May 2018 14:27:21 -0700 (PDT) Subject: Re: [PATCH 07/11] nds32: Linux Syscall Interface To: libc-alpha@sourceware.org References: <1525617685-32083-1-git-send-email-vincentc@andestech.com> <1525617685-32083-8-git-send-email-vincentc@andestech.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <99dc760f-f96d-0e75-b39f-9d5a15fff80a@linaro.org> Date: Tue, 08 May 2018 21:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525617685-32083-8-git-send-email-vincentc@andestech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-05/txt/msg00360.txt.bz2 On 06/05/2018 11:41, vincentc wrote: > This patch contains the Linux system call interface, as well as the > definitions of a handful of system calls. > --- > sysdeps/unix/sysv/linux/nds32/arch-fork.h | 27 ++ > sysdeps/unix/sysv/linux/nds32/clone.S | 66 +++++ > sysdeps/unix/sysv/linux/nds32/profil-counter.h | 31 +++ > sysdeps/unix/sysv/linux/nds32/pt-vfork.S | 1 + > sysdeps/unix/sysv/linux/nds32/readahead.c | 36 +++ > sysdeps/unix/sysv/linux/nds32/syscall.c | 39 +++ > sysdeps/unix/sysv/linux/nds32/syscalls.list | 2 + > sysdeps/unix/sysv/linux/nds32/sysdep.c | 30 +++ > sysdeps/unix/sysv/linux/nds32/sysdep.h | 337 +++++++++++++++++++++++++ > 9 files changed, 569 insertions(+) > create mode 100644 sysdeps/unix/sysv/linux/nds32/arch-fork.h > create mode 100644 sysdeps/unix/sysv/linux/nds32/clone.S > create mode 100644 sysdeps/unix/sysv/linux/nds32/profil-counter.h > create mode 100644 sysdeps/unix/sysv/linux/nds32/pt-vfork.S > create mode 100644 sysdeps/unix/sysv/linux/nds32/readahead.c > create mode 100644 sysdeps/unix/sysv/linux/nds32/syscall.c > create mode 100644 sysdeps/unix/sysv/linux/nds32/syscalls.list > create mode 100644 sysdeps/unix/sysv/linux/nds32/sysdep.c > create mode 100644 sysdeps/unix/sysv/linux/nds32/sysdep.h > > diff --git a/sysdeps/unix/sysv/linux/nds32/arch-fork.h b/sysdeps/unix/sysv/linux/nds32/arch-fork.h > new file mode 100644 > index 0000000..e86143a > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/nds32/arch-fork.h > @@ -0,0 +1,27 @@ > +/* ARCH_FORK definition for Linux fork implementation, Andes Linux/nds32 version. > + Copyright (C) 2002-2018 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +#define ARCH_FORK() \ > + INLINE_SYSCALL (clone, 5, \ > + CLONE_CHILD_SETTID | CLONE_CHILD_CLEARTID | SIGCHLD, 0, \ > + NULL, NULL, &THREAD_SELF->tid) > + The clone syscall for fork implementation was consolidate (commit 3dc214977beccc95f0df3b90fa4ca2557fe1bdd2). The new ports need to redefine it iff the clone kernel ABI does not follow the generic expect one (check sysdeps/unix/sysv/linux/kernel-features.h:119). > diff --git a/sysdeps/unix/sysv/linux/nds32/readahead.c b/sysdeps/unix/sysv/linux/nds32/readahead.c > new file mode 100644 > index 0000000..5559619 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/nds32/readahead.c Joseph already noted this files should not be required. > diff --git a/sysdeps/unix/sysv/linux/nds32/syscall.c b/sysdeps/unix/sysv/linux/nds32/syscall.c > new file mode 100644 > index 0000000..77af6bb > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/nds32/syscall.c > @@ -0,0 +1,39 @@ > +/* System call interface, Andes nds32 version. > + Copyright (C) 2001-2018 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > +#include > +#include > +long int syscall (long int __sysno, ...) > +{ > + > + int result; > + unsigned long arg1,arg2,arg3,arg4,arg5,arg6; > + va_list arg; > + va_start (arg, __sysno); > + arg1 = va_arg (arg, unsigned long); > + arg2 = va_arg (arg, unsigned long); > + arg3 = va_arg (arg, unsigned long); > + arg4 = va_arg (arg, unsigned long); > + arg5 = va_arg (arg, unsigned long); > + arg6 = va_arg (arg, unsigned long); > + va_end (arg); > + __asm__ volatile ( "" ::: "memory" ); > + result = INLINE_SYSCALL_NCS(__sysno,6,arg1,arg2,arg3,arg4,arg5,arg6); > + return result; > +} Maybe we could it as a generic version, the only points I am not sure if why you need a compiler memory barrier here.