* Steward opinions on gerrit?
@ 2019-11-27 20:00 Carlos O'Donell
2019-11-27 22:47 ` Joseph Myers
2019-12-09 10:54 ` Andreas Schwab
0 siblings, 2 replies; 7+ messages in thread
From: Carlos O'Donell @ 2019-11-27 20:00 UTC (permalink / raw)
To: Joseph Myers, Andreas Schwab, libc-alpha, Paul Eggert
As stewards for glibc I wanted to ask each of you if you had
any opinions on gerrit, and thoughts on or the fundamental
requirements of a review system for a project like glibc.
Joseph,
You write and review a lot of patches. Does using gerrit
interest you? Does it solve any problems?
Andreas,
Would you be interested in trying out gerrit? Does it solve
any problems for you as a reviewer?
Paul,
You comment on a lot of changes orthogonality, usually with
a broad perspective from various packages, would having reviews
in gerrit prevent this from happening during review?
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-11-27 20:00 Steward opinions on gerrit? Carlos O'Donell
@ 2019-11-27 22:47 ` Joseph Myers
2019-12-02 17:21 ` Carlos O'Donell
2019-12-09 10:54 ` Andreas Schwab
1 sibling, 1 reply; 7+ messages in thread
From: Joseph Myers @ 2019-11-27 22:47 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: Andreas Schwab, libc-alpha, Paul Eggert
On Wed, 27 Nov 2019, Carlos O'Donell wrote:
> As stewards for glibc I wanted to ask each of you if you had
> any opinions on gerrit, and thoughts on or the fundamental
> requirements of a review system for a project like glibc.
>
> Joseph,
>
> You write and review a lot of patches. Does using gerrit
> interest you? Does it solve any problems?
I'm not convinced the experiment is advanced enough to tell whether it
helps much. The main problem I see patch review systems as being for is
to track changes that are under consideration but not yet approved, and
it's hard to judge when there are only a few changes in there. (I suspect
any system would gradually accumulate patches that were submitted by
one-off contributors, issues raised, but never revised and never
definitively rejected either.)
There's potential for various kinds of CI integration with patch tracking,
but I don't think we've tried that.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-11-27 22:47 ` Joseph Myers
@ 2019-12-02 17:21 ` Carlos O'Donell
0 siblings, 0 replies; 7+ messages in thread
From: Carlos O'Donell @ 2019-12-02 17:21 UTC (permalink / raw)
To: Joseph Myers; +Cc: Andreas Schwab, libc-alpha, Paul Eggert
On 11/27/19 5:47 PM, Joseph Myers wrote:
> On Wed, 27 Nov 2019, Carlos O'Donell wrote:
>
>> As stewards for glibc I wanted to ask each of you if you had
>> any opinions on gerrit, and thoughts on or the fundamental
>> requirements of a review system for a project like glibc.
>>
>> Joseph,
>>
>> You write and review a lot of patches. Does using gerrit
>> interest you? Does it solve any problems?
>
> I'm not convinced the experiment is advanced enough to tell whether it
> helps much. The main problem I see patch review systems as being for is
> to track changes that are under consideration but not yet approved, and
> it's hard to judge when there are only a few changes in there. (I suspect
> any system would gradually accumulate patches that were submitted by
> one-off contributors, issues raised, but never revised and never
> definitively rejected either.
Gerrit does track changes under consideration, but falls down because it
doesn't accept email input at various stages and is non-robust in this case
if you clip the mail footer. I'm not happy about that.
I'd like to try Patchwork v2.0 and do a comparison.
> There's potential for various kinds of CI integration with patch tracking,
> but I don't think we've tried that.
We have not yet tried that. We haven't gotten past making the new patch
tracking work well enough that we aren't doing too much manual work.
The problem with Patchwork v1.0 seemed to be that we needed a lot of manual
work to keep the patch queue clean and so we didn't do it.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-11-27 20:00 Steward opinions on gerrit? Carlos O'Donell
2019-11-27 22:47 ` Joseph Myers
@ 2019-12-09 10:54 ` Andreas Schwab
2019-12-09 12:39 ` Carlos O'Donell
1 sibling, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2019-12-09 10:54 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: Joseph Myers, libc-alpha, Paul Eggert
gerrit doesn't work with EWW. That's a no-go.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-12-09 10:54 ` Andreas Schwab
@ 2019-12-09 12:39 ` Carlos O'Donell
2019-12-09 12:54 ` Andreas Schwab
0 siblings, 1 reply; 7+ messages in thread
From: Carlos O'Donell @ 2019-12-09 12:39 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Joseph Myers, libc-alpha, Paul Eggert
On 12/9/19 5:54 AM, Andreas Schwab wrote:
> gerrit doesn't work with EWW. That's a no-go.
Thanks for that feedback.
Can you try out a public patchwork 2.0 and see if it works?
For example can you browse and use:
https://patchwork.kernel.org/
Which is patchwork 2.0.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-12-09 12:39 ` Carlos O'Donell
@ 2019-12-09 12:54 ` Andreas Schwab
2019-12-09 17:23 ` Carlos O'Donell
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2019-12-09 12:54 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: Joseph Myers, libc-alpha, Paul Eggert
On Dez 09 2019, Carlos O'Donell wrote:
> Can you try out a public patchwork 2.0 and see if it works?
That works fine, of course.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Steward opinions on gerrit?
2019-12-09 12:54 ` Andreas Schwab
@ 2019-12-09 17:23 ` Carlos O'Donell
0 siblings, 0 replies; 7+ messages in thread
From: Carlos O'Donell @ 2019-12-09 17:23 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Joseph Myers, libc-alpha, Paul Eggert
On 12/9/19 7:54 AM, Andreas Schwab wrote:
> On Dez 09 2019, Carlos O'Donell wrote:
>
>> Can you try out a public patchwork 2.0 and see if it works?
>
> That works fine, of course.
Awesome. Thank you for checking. I think with Siddhesh we're going
to see if we can try this out next.
I appreciate any feedback you're willing to give about this process.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-09 17:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 20:00 Steward opinions on gerrit? Carlos O'Donell
2019-11-27 22:47 ` Joseph Myers
2019-12-02 17:21 ` Carlos O'Donell
2019-12-09 10:54 ` Andreas Schwab
2019-12-09 12:39 ` Carlos O'Donell
2019-12-09 12:54 ` Andreas Schwab
2019-12-09 17:23 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).