From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eggert@cs.ucla.edu>
Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68])
 by sourceware.org (Postfix) with ESMTPS id 68E2E3858D1E
 for <libc-alpha@sourceware.org>; Mon, 11 Apr 2022 18:07:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68E2E3858D1E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=cs.ucla.edu
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2C195160052;
 Mon, 11 Apr 2022 11:07:21 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id Qk1jafMZxzRC; Mon, 11 Apr 2022 11:07:20 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7607A1600C2;
 Mon, 11 Apr 2022 11:07:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id JbQatoxmiBjs; Mon, 11 Apr 2022 11:07:20 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4E84F160052;
 Mon, 11 Apr 2022 11:07:20 -0700 (PDT)
Message-ID: <9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu>
Date: Mon, 11 Apr 2022 11:07:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Noah Goldstein <goldstein.w.n@gmail.com>
References: <20220411165835.4028009-1-goldstein.w.n@gmail.com>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t
In-Reply-To: <20220411165835.4028009-1-goldstein.w.n@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Apr 2022 18:07:23 -0000

On 4/11/22 09:58, Noah Goldstein via Libc-alpha wrote:
> -   uint_fast16_t stack_flags = DEFAULT_STACK_PERMS;
> +   uint32_t stack_flags = DEFAULT_STACK_PERMS;

Doesn't this lose width info - or worse, add misleading info? For this 
particular case it looks like we need 32 bits, when we don't.

If we want to lose info, it'd be simpler to use plain 'int' and 
'unsigned int' for situations like these. That's less misleading.

If we don't want to lose info, it'd be better to define private types 
like glibc_uint_fast16_t and use these private types to address 
efficiency concerns.

I prefer losing the width info here, as this will cause less 
bikeshedding in the future. But if we want to keep width info, surely we 
should not make it more misleading.