From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350)
Date: Fri, 30 Sep 2022 09:51:56 -0300 [thread overview]
Message-ID: <9a7585d4-45de-d957-f746-770bc2abf55e@linaro.org> (raw)
In-Reply-To: <YzbhqEBn75W7DhQQ@arm.com>
On 30/09/22 09:31, Szabolcs Nagy wrote:
> The 09/30/2022 08:24, Adhemerval Zanella Netto wrote:
>> On 30/09/22 08:05, Szabolcs Nagy wrote:
>>> The 09/30/2022 11:47, Szabolcs Nagy via Libc-alpha wrote:
>>>> The 01/27/2022 17:15, Adhemerval Zanella via Libc-alpha wrote:
>>>>> The __convert_scm_timestamps only updates the control message last
>>>>> pointer for SOL_SOCKET type, so if the message control buffer contains
>>>>> multiple ancillary message types the converted timestamp one might
>>>>> overwrite a valid message.
>>>>>
>>>>> The test checks if the extra ancillary space is correctly handled
>>>>> by recvmsg/recvmmsg, where if there is no extra space for the 64-bit
>>>>> time_t converted message the control buffer should be marked with
>>>>> MSG_TRUNC. It also check if recvmsg/recvmmsg handle correctly multiple
>>>>> ancillary data.
>>>>>
>>>>> Checked on x86_64-linux and on i686-linux-gnu on both 5.11 and
>>>>> 4.15 kernel.
>>>>>
>>>>> Co-authored-by: Fabian Vogt <fvogt@suse.de>
>>>>
>>>> note: the time64 recvmsg test started to fail on 32bit
>>>> arm after i updated my aarch64 kernel to 5.18
>>>
>>> sorry the kernel is
>>> Linux 8a7948402d35 5.15.0-48-generic #54~20.04.1-Ubuntu SMP Thu Sep 1 16:20:53 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
>>
>> I just check on exactly same kernel (ubuntu 22) on a aarch64 VM and I could not
>> reproduce it:
>>
>> $ uname -a
>> Linux ubuntu-aarch64 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:31:33 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
>> $ file socket/tst-socket-timestamp
>> socket/tst-socket-timestamp: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped
>> $ file socket/tst-socket-timestamp-time64
>> socket/tst-socket-timestamp-time64: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped
>> $ ./testrun.sh socket/tst-socket-timestamp
>> $ ./testrun.sh socket/tst-socket-timestamp-time64
>> $
>>
>> I used gcc 12.1.1, maybe it is a compiler issue?
>
> sorry it was my fault: old kernel headers.
Right, but I am puzzled since it should not matter (at least glibc should handle it).
What was miscompiled due wrong kernel header?
next prev parent reply other threads:[~2022-09-30 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 20:15 [PATCH v5 0/3] Fix socket ancillary timestamp on 32 bit time_t ABIs Adhemerval Zanella
2022-01-27 20:15 ` [PATCH v5 1/3] support: Add support_socket_so_timestamp_time64 Adhemerval Zanella
2022-01-28 12:37 ` Florian Weimer
2022-01-27 20:15 ` [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350) Adhemerval Zanella
2022-01-28 13:22 ` Florian Weimer
2022-01-28 16:41 ` Adhemerval Zanella
2022-09-30 10:47 ` Szabolcs Nagy
2022-09-30 11:05 ` Szabolcs Nagy
2022-09-30 11:24 ` Adhemerval Zanella Netto
2022-09-30 12:31 ` Szabolcs Nagy
2022-09-30 12:51 ` Adhemerval Zanella Netto [this message]
2022-09-30 13:09 ` Arnd Bergmann
2022-09-30 13:46 ` Adhemerval Zanella Netto
2022-09-30 14:56 ` Arnd Bergmann
2022-09-30 15:33 ` Adhemerval Zanella Netto
2022-01-27 20:15 ` [PATCH v5 3/3] Linux: Only generate 64 bit timestamps for 64 bit time_t recvmsg/recvmmsg Adhemerval Zanella
2022-01-28 14:02 ` Florian Weimer
2022-01-28 16:42 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a7585d4-45de-d957-f746-770bc2abf55e@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).