From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11748 invoked by alias); 29 Dec 2017 13:41:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11738 invoked by uid 89); 29 Dec 2017 13:41:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=GlFt1ynt0uAc02T+FmK/16VIyS5D/b7nayz/c1RDgJ4=; b=JV2J1wClbd73voZzHFKL33KOSCU33t60jdp+/+59qlrh26J+URT14Kac++BxYIStdO aA0NPYh9us8PVJJCFQBkG5SXs68oQefpwcoOJ4SoQnB6N8fmQ+U1WMtZDxRHze6WJTga s1H7PQRSCmoA7ul8FafRPVFQGAbf5q8klDNB5b86EUeTu8TptkEul5q3IjiTR6TuMfhc Gyc4BpwNZN4MTX0wt/ocI4yaXz92umYawoUNBmicfZPWTeHm8CXuQ/fYxwApajaemdyK mNB8GJq0FPzP+Pr8weAsXgMRCVQu28p+vxlHc21GKeDEQSLxPKJ6AOo+xd2oFxa8jsf6 wZ7A== X-Gm-Message-State: AKGB3mJ7O0VOMalLTzachEvx7ywhXnunb7w57k3x1DBGEX7Q6E3RMXof OjQRoJUxRZ/ySwrFDePNKKr3TP5MX04= X-Google-Smtp-Source: ACJfBoubFD7XPFHWH26oftcVk6tpSJYej0UhN6cZrL9scTxbVKm9in8iYysPLHlQuNqHR2bqHuLorw== X-Received: by 10.55.191.5 with SMTP id p5mr19474616qkf.270.1514554895796; Fri, 29 Dec 2017 05:41:35 -0800 (PST) Subject: Re: [PATCH 3/3] linux/x86: sync sys/ptrace.h with Linux 4.14 [BZ #22433] To: libc-alpha@sourceware.org References: <20171227034637.GD32108@altlinux.org> <20171229133619.GI3713@altlinux.org> From: Adhemerval Zanella Message-ID: <9a77454d-89bc-312e-8907-9383dbd69c94@linaro.org> Date: Fri, 29 Dec 2017 13:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171229133619.GI3713@altlinux.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RBHKHcd8jo7qC3CPdZzyLgPB9f5nIIYN1" X-SW-Source: 2017-12/txt/msg00957.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RBHKHcd8jo7qC3CPdZzyLgPB9f5nIIYN1 Content-Type: multipart/mixed; boundary="fWYOPi1OL6IvR5j64nlB7E2kzEXLfBv8e"; protected-headers="v1" From: Adhemerval Zanella To: libc-alpha@sourceware.org Message-ID: <9a77454d-89bc-312e-8907-9383dbd69c94@linaro.org> Subject: Re: [PATCH 3/3] linux/x86: sync sys/ptrace.h with Linux 4.14 [BZ #22433] References: <20171227034637.GD32108@altlinux.org> <20171229133619.GI3713@altlinux.org> In-Reply-To: <20171229133619.GI3713@altlinux.org> --fWYOPi1OL6IvR5j64nlB7E2kzEXLfBv8e Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable Content-length: 1342 On 29/12/2017 11:36, Dmitry V. Levin wrote: > On Fri, Dec 29, 2017 at 11:13:03AM -0200, Adhemerval Zanella wrote: >> On 27/12/2017 01:46, Dmitry V. Levin wrote: >>> Clone generic linux/sys/ptrace.h, add the following x86-specific >>> __ptrace_request constants: PTRACE_GET_THREAD_AREA, >>> PTRACE_SET_THREAD_AREA, PTRACE_ARCH_PRCTL, PTRACE_SYSEMU, >>> PTRACE_SYSEMU_SINGLESTEP, and PTRACE_SINGLEBLOCK. >>> >>> [BZ #22433] >>> * sysdeps/unix/sysv/linux/x86/sys/ptrace.h: New file. >> >> Wouldn't be better to avoid code duplication to add a ptrace-arch.h as an >> empty one for generic case and add a x86 with the arch-specific bits? >=20 > Maybe, but there are two complications. >=20 > First, this x86/bits/ptrace-arch.h would have to contain a part of > enum __ptrace_request definition - are we OK with distributing > such ugly looking arch-specific bits? >=20 > Second, there are exceptions, e.g. ia64/sys/ptrace.h includes additional > headers and defines struct __pt_all_user_regs, s390/sys/ptrace.h and > sparc/sys/ptrace.h undefine potentially conflicting PTRACE_* macros - > we would have to #include more arch-specific bits to accommodate them. >=20 >=20 Indeed breaking down the enum on arch-specific bits does not seems a good refactor way. It seems ptrace.h justify to be a quite arch-specific header. The patch LGTM then. --fWYOPi1OL6IvR5j64nlB7E2kzEXLfBv8e-- --RBHKHcd8jo7qC3CPdZzyLgPB9f5nIIYN1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJaRkYKAAoJEKqx7BSnlIjvle8QALDVRMRJEv543QhXKptlbLLS yNX2jjKgmCb5wjdCRgrQjBuwO7ZkKfU0WFzAreFxrDTP8yHF+Jmpi8hFECOIbGpb neU4F7j/NyWMrI4fYxOBrJRRfGY/uCu/Fu12XmB5k0i3Wek9rWZr/gD8J1j/ZAxM keYvMuXR/iCM0g4Oc74KDSXSeDJqWiHft/w4vgVkAhbqj4E2eXaQ2+vuEIMH7Gh8 cCuCkQwdLxK3fjVnw0X74CkF13AgrInjLnakYhsGTSSaHO+F5jD3tclKrdDLmukl KjZuQtzcWQP0/fv9TNRTbCC+VAv3jyDiZXWYidoJ+vbjyAbgQnuBWT4msL+aQ4iX 4lTgncZCy1QmDA6hzS3FMln4IRvU5ri2uKxyKK5FgMaD5DN5z+fwAqPxD9Yk9M12 4pj+AJm/+6FxwMaDwUKkxomUSXq75zCsH7eMJaA9rR6UwyFENMjWW8usY42y6y4v PTAj5BvDaV/sPeSU2Rdm9dJO6jS4de4Lga7+8ZaEAVrpAJbJFJ+sX3hFWDUvJUKx l0HlNO8e15IGWII4A9NjkdT9XL62GXAt0FOfz3Yze5ozWUUFYuH8YVvODumP+WXR jsEGuhQ7scDHB8Jxp3TlQ0hLJzIEYObo6ve36BBlj1ZyFKiwSiFg53zkG8JAVA9W zbGEfi14/4PDtCrNzy+r =KuOI -----END PGP SIGNATURE----- --RBHKHcd8jo7qC3CPdZzyLgPB9f5nIIYN1--