From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id AE96F3854578 for ; Thu, 17 Nov 2022 16:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE96F3854578 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x234.google.com with SMTP id l127so2458581oia.8 for ; Thu, 17 Nov 2022 08:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=yjKzi98DW4Rxe5lp1WOdEvmWMHNrj0b3QOx3fkk7Xm0=; b=qOf3LQVomXEDZgUFO0inyGPxj3HLdUDmL6qFZBSFK3KGA6TXMVqbJj5I0fyoF6zCXb g8uQU0ZPSv3RaonbfALhnTDlbMtHu/0GJXuWqiSt4ylnEL1YNwQvnKeobhJtwN6TsJZd Lxzn1UAF+1yjBCjMN7aPlb2r8j5gQd0oNEAWEeuU7NC7NpAIzCKf+vOFmwVqaNK8W0n2 kqImOY+0j9nFn7SdzrzKpIetiyjZTuWpnGCjOOx+x9H1P/NG3J/MbEYHUHd2sQvKG58j B/kzlcHqdbxQgRwmrj4NMiRRn3gjp0FEnoLo7cORb7EuyY3hAaeVq3PUhnKQUmxlCQhj BmDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yjKzi98DW4Rxe5lp1WOdEvmWMHNrj0b3QOx3fkk7Xm0=; b=1Z0Ti8wLB8xKdEpp8fov7Qe0JChG3KCvMFBrqSyWi5rxalRT9X2d0lICDLThHz6Gpi ZtFU/u3604/4mpY8w9KNgTEWFsZ8BQpANkF4Re+6y5mXwIPMwQffR84kDHZdWAI6Pjbq 4tMsN2V5Ff7I7G1mHtQGM2qe0d6f32aIMkJQPU4bseIKJF1wSdXA+5OxpLl9scxSAzjv 8p10FA/UNRW0twA8X0ekV0cTYsKNZ3eRlSHc6Grgr4hKh14PpWkPNi2eOhrUHN7ytm2G zLWAV2iwpu1eOPR4/0lrw19JNUIwHjG8MceQmGED20EJWzJbm5Z4Ouyx4w9fS08qeLmH aVRg== X-Gm-Message-State: ANoB5pkyNensHid/Jom9d7AVOJfKXgywVQcHIoC6wyzWxW4XUcSCWxNO /doQix9uhzgzRzfABUkZGo+uVA== X-Google-Smtp-Source: AA0mqf52MRoz1aXKKJigs3daQH7RNd1Y3s/+HrT3sR5DAWbrr20MWicT5/qgCSqag0Tz4KjglLez1Q== X-Received: by 2002:a54:408f:0:b0:359:33c2:e5d6 with SMTP id i15-20020a54408f000000b0035933c2e5d6mr4326686oii.174.1668703628805; Thu, 17 Nov 2022 08:47:08 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c1:84f3:2833:5b94:1e27:c35b? ([2804:1b3:a7c1:84f3:2833:5b94:1e27:c35b]) by smtp.gmail.com with ESMTPSA id g89-20020a9d12e2000000b00661948e6119sm525345otg.47.2022.11.17.08.47.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 08:47:08 -0800 (PST) Message-ID: <9a9d4b58-2bb7-c31c-76c7-750b2b5fd9b7@linaro.org> Date: Thu, 17 Nov 2022 13:47:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Rename STAT_HAS_TIME32 to KERNEL_STAT64_HAS_TIME32 Content-Language: en-US To: YunQiang Su , libc-alpha@sourceware.org Cc: aurelien@aurel32.net, jiaxun.yang@flygoat.com, macro@orcam.me.uk, syq@debian.org References: <20221104015428.1545677-1-yunqiang.su@cipunited.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20221104015428.1545677-1-yunqiang.su@cipunited.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/11/22 22:54, YunQiang Su wrote: > The macro name STAT_HAS_TIME32 is not so clear. > > This macro is used for some arch like MIPSn64. > The kernel_stat/kernel_stat64 of it has a 32bit unsigned time value. > Thus that has y2106 problem. > So we should statx to solve this problem. I am not seeing much gain in this refactor, it is only an internal define used once and on its definition it already states the problem (and the y2106 issue is already stated in 5b980d48099130). I prefer to keep current macro so keep git history simpler. > --- > sysdeps/unix/sysv/linux/fstatat64.c | 2 +- > sysdeps/unix/sysv/linux/mips/kernel_stat.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c > index 8b1a1a290d..532b9beb67 100644 > --- a/sysdeps/unix/sysv/linux/fstatat64.c > +++ b/sysdeps/unix/sysv/linux/fstatat64.c > @@ -42,7 +42,7 @@ _Static_assert (sizeof (__blkcnt_t) == sizeof (__blkcnt64_t), > > #if (__WORDSIZE == 32 \ > && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ > - || defined STAT_HAS_TIME32 \ > + || defined KERNEL_STAT64_HAS_TIME32 \ > || (!defined __NR_newfstatat && !defined __NR_fstatat64) > # define FSTATAT_USE_STATX 1 > > diff --git a/sysdeps/unix/sysv/linux/mips/kernel_stat.h b/sysdeps/unix/sysv/linux/mips/kernel_stat.h > index 19524f7ea4..044adfb8df 100644 > --- a/sysdeps/unix/sysv/linux/mips/kernel_stat.h > +++ b/sysdeps/unix/sysv/linux/mips/kernel_stat.h > @@ -69,7 +69,7 @@ struct kernel_stat > #endif > /* MIPS64 has unsigned 32 bit timestamps fields, so use statx as well. */ > #if _MIPS_SIM == _ABI64 > -# define STAT_HAS_TIME32 > +# define KERNEL_STAT64_HAS_TIME32 > #endif > > #endif