From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 25B0F3847718 for ; Wed, 3 Apr 2024 17:50:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25B0F3847718 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25B0F3847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712166653; cv=none; b=tRMvP73CBESuqDbSNfeLFf6CzftAURVTrP0tSYK1QhC4ueVBkrDbuOBnlBty6lMA27HuJ0+RskGy55W7x8y/nBc6pI4QNL/cfb5y0CtY+FmKhJ/16f25++AcRpoAzjO8Xd5wL5qGnUa8Wz8Ii5N8YNFlQoiJsLIstUmkv+wadZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712166653; c=relaxed/simple; bh=tUMQZMJO8n5DZUSwcKygWEfLHF+d6Q4gV05zyax0omI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=UJOr83dF11/sVAZmwclmWsC/dvXJbAYTv2TgcHX6GS+gmctbHNe+0QIrcyUUoG5kwhIKGrsQLwKhRhyOpet6C6GvcK00kNk+TLVQ2dPlyzU5fQ5DKUJFglWvmljIDgKGfUWmsy3tH8Sc9Vzza29M8kRpp5UAlf88EWtke4ZBf0A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5c6bd3100fcso120659a12.3 for ; Wed, 03 Apr 2024 10:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712166650; x=1712771450; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f+0cck1i0hezNBpY7i/UsIlQxdZoInNSkI8kJLa9+do=; b=yPyEPYf3jr4GJtKQu1/6OuCzNfzidYQW3VVFs5o/s12xdAf0V3V3dtnwgGYuBieEcd zbrl/L6m4cAgyT88OovEy5BG01Or8TA5mNUDT+x7EDdlAzPbLZQShiBcd1zMaM6hJiUi UX0vD7kc5cIas/ryUrCtbTFun4WRqB01LCEKH+ZYsBFq8gWLMog4Y4E1IESQ4V819310 RMG9xfumtsA5EJsdCgS6/+np5FpwMvBxVZCzUZJx2jdkJlnAbdneRScSi6WfV8fQCjIT BuR7U28Ab5pliq88Bo1Vx+I3U9kytGpVI8LMKo675afDg5HkCOPFU2uIYXUPfkPqoZOa iAtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712166650; x=1712771450; h=content-transfer-encoding:in-reply-to:organization:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f+0cck1i0hezNBpY7i/UsIlQxdZoInNSkI8kJLa9+do=; b=hS6euF4w2kWpIkaJuiAJs95GVsRxhGZ/8VbpbiCBClAVs5NmA/89LZx/7fEzDa8D/p xKLNZ8el9jkWjEzckmVQ5xV4sboW4j5/4IroPWMynRs/AvcQrFBYiydtfn0Aqm/OYITm 0Glsq0Imbs16gIo7JKwe/kwTsQZhHJO7A6vMjm7o+ZvyYPNqAXrf83jbXUpiOK8nwqXz bu/vKhjcrl7Mi8bN3gNrt8IfIKc49IO6DwEBX8Cm1I2gk1kGGsUXrMcW2ppbHMskQneP Zm+yl5vo0uMEarUd8A3WRZquh8rbLB/velYhq+HAUTZGJawXAXjZecpISFDQ4a3PuzvF ROVA== X-Gm-Message-State: AOJu0YxHCka9fzfl+BakLaGAysNLnfcgWM/nqtO+3iuW65wNX+1GUN+z eQK9qNRrWSs2S269STBC3QeE04jq74GM2rMtD9O9NFIg9PA2E1nvUMgQfzQh/Fg7lscUiVUe5zK d X-Google-Smtp-Source: AGHT+IGId1eVwQJEKWraMqjUnuWq5z21vBCXhcE63enmL8K4ox305t3a73VJA+VO0C+1nPH6Rq208A== X-Received: by 2002:a17:902:e741:b0:1dc:a605:5435 with SMTP id p1-20020a170902e74100b001dca6055435mr17859296plf.31.1712166650452; Wed, 03 Apr 2024 10:50:50 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af? ([2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af]) by smtp.gmail.com with ESMTPSA id l11-20020a170903244b00b001e29ac7cc64sm1322181pls.231.2024.04.03.10.50.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 10:50:49 -0700 (PDT) Message-ID: <9ae90894-3a34-4fcb-8592-2dc500c4479a@linaro.org> Date: Wed, 3 Apr 2024 14:50:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arc4random: fix getrandom fallback to /dev/urandom From: Adhemerval Zanella Netto To: libc-alpha@sourceware.org References: <20240403165523.23129-1-ailiop@suse.com> <87zfuagxih.fsf@oldenburg.str.redhat.com> <57bf1728-de5d-4ee5-9d79-ea49ad66a40c@linaro.org> Content-Language: en-US Organization: Linaro In-Reply-To: <57bf1728-de5d-4ee5-9d79-ea49ad66a40c@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/04/24 14:48, Adhemerval Zanella Netto wrote: > > > On 03/04/24 14:35, Florian Weimer wrote: >> * Anthony Iliopoulos: >> >>> diff --git a/stdlib/arc4random.c b/stdlib/arc4random.c >>> index 3ae8fc130234..9b6a6ee85150 100644 >>> --- a/stdlib/arc4random.c >>> +++ b/stdlib/arc4random.c >>> @@ -42,7 +42,7 @@ __arc4random_buf (void *p, size_t n) >>> >>> for (;;) >>> { >>> - l = TEMP_FAILURE_RETRY (__getrandom_nocancel (p, n, 0)); >>> + l = TEMP_FAILURE_RETRY (__getrandom_nocancel_nostatus (p, n, 0)); >>> if (l > 0) >>> { >>> if ((size_t) l == n) >> >> TEMP_FAILURE_RETRY is incompatible with __getrandom_nocancel_nostatus. >> You need to check for -EINTR and try again. > > It does work, it will return -ENOSYS in this case. Right, it is need to handle the signal.