Re: [PATCH v6] sysdeps/x86_64/multiarch/memmem-avx2.c: add memmem-avx2.c

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 19/02/24 05:13, Alexander Monakov wrote:
> 
> On Mon, 19 Feb 2024, Noah Goldstein wrote:
> 
>> It doesn't seem you have addressed many of the comments from your v5 patch.
>> Can it helps if you
>> 1: Reply to the comments indicating they are handled / why are choosing not
>> to handle them.
>> 2: Send further versions to the same email chain. (`--in-reply-to`
>> with `git send-email`).
> 
> Are you ok with the change in worst-case time complexity? The existing generic
> implementation is O(n+m), the proposed variants are O(n*m).

I think we should consider this a regression, we already have a bug opened for
wcsstr [1] for a similar issue. We already had another similar issue for
PowerPC [2], and we did not have consensus back then because the generic
implementation was also O(m*n) (it was before Wilco new implementation).

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=23865
[2] https://sourceware.org/pipermail/libc-alpha/2015-July/062808.html