From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3FB473858C62 for ; Mon, 12 Feb 2024 14:08:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FB473858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FB473858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707746910; cv=none; b=WXzyNWKNwZeChu8ljF0iEp/yrg26/Kf3ijlmNHqAhjPzv+97ei95jcghAjGTjYOxib4RsbtB5MU70TELYWfPOPdVOrQ7mH8Dut0WNy5XOxjxiazcbNKGSkpEIMppWgw7MzVMS0zL6W0QxlEylwrzB0Gn6d5uBXY99IvB2ji1jqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707746910; c=relaxed/simple; bh=VDlvqQ0Wg1JZTvrEufLkqXhZLs6nm2to/sZMOsNR0mc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xlrhwK5v7xuL2m6tqbr0iOmsTK+MQlqXCqbWFtpTAbv5SOOfszH8tHE4qIzwk0sH8+e2TStI9ybFHqfKiHUiQbFOKeh9tzwnq/DR895lTcvW7kdI3ftlV7TSmWkCf+2ovAbBXG5KbQqoBSBPaqsyCRZ1WkZkqkQR+oqPa60lkdg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707746908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=whL1K6dOwEXUCEREx7F7efPZ57teLB0xWMUdg0HtmQ0=; b=c7LUTfuticCloih9jgyn3W0vzVxuUW9xyvpoLHGBAJNNzPwNp7I80NCdZLz3oWG91zbNGI POxyaXfq4OUJP4DIV1WJ4zFi0emhY7CTl3+b9wAK7NTr0JsKvAYmMJ7vQUzTyK1OOBaTDj etkl5zfhyVizihn1gY3p0poiDwwvmnk= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-wgrNZpLeOsOqGUHxS2VtMA-1; Mon, 12 Feb 2024 09:08:26 -0500 X-MC-Unique: wgrNZpLeOsOqGUHxS2VtMA-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-59900bec87eso4298153eaf.0 for ; Mon, 12 Feb 2024 06:08:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707746906; x=1708351706; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=whL1K6dOwEXUCEREx7F7efPZ57teLB0xWMUdg0HtmQ0=; b=NcAU4G7D36mpkyOh2ArZpk6YudsMLU2VinGGD2Y1jf++7z/mfJwwTaEIrkmv5I+ReV wPdZ3WsoHFTphci8HA68aDF9Nfd4lXsVU3PMAdnz6rtCjG4O+Cwef6axTCTU55whivfJ 7qfXb1kTgwyldDcSv5WdKNsjuqwYDTn290TLl59WNG77WtAyOhm+Al2oSGLFO0CemDVh 9wR7q6UcEfwSgy9YySiVJ0zpiDWWBRmAFQ0gONPCKXRqTiKynyBcIxGDC/hxFxguoMZG axfls/pXL9JTjWFu6myu3b1qcUtXVNG7jLCHiO6SwzMZjF41dtMHZf1IHvHRBv+rlul7 b71g== X-Forwarded-Encrypted: i=1; AJvYcCXsSNAp0cj4ChTbOy1gVFYwyIqM53v3tDlAH0aS9LjdMcDIsmcqn5A1ao3WyJG0GHuuKQaXTzLTNLpaT0vxa69jY/5hVbhqPucA X-Gm-Message-State: AOJu0YyJ6RYqaiFgULYGKeAVS9GEbwFfvOVt+6tJ54pT4fUxTPBcgtZ5 6g4vOGX+TgI5ackkTAvt7cPLUcCMM6ADY0yAEoPPOTEuGXm0UnE7YegI1WDlo2V49y2pjxzqblJ kuAFMn/0cgSJgflSGIf/yhjPdB83REhd1bJqOmKgEWhd/8RBK8XR6P1tNgw== X-Received: by 2002:a05:6358:7e81:b0:17a:ec6c:4236 with SMTP id o1-20020a0563587e8100b0017aec6c4236mr552980rwn.2.1707746906045; Mon, 12 Feb 2024 06:08:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQ8VlenVg1iyCsTfh17PVrct128ZZQ1ywRN11cdIBL/2PBr7suiG8dRSE+jlHVIwQ46bG2lg== X-Received: by 2002:a05:6358:7e81:b0:17a:ec6c:4236 with SMTP id o1-20020a0563587e8100b0017aec6c4236mr552959rwn.2.1707746905710; Mon, 12 Feb 2024 06:08:25 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUwNXSzmWdvLiiBNGnJVj8OHmk35nBv35mYYAMB1MP0GiY2nKYrlPCm6REyNnhRtfTzlC2PB4wIIiz4EmnRXcxhJnQe39I2Gm9g Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id bo10-20020a05621414aa00b0068ccb492b1dsm167481qvb.141.2024.02.12.06.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 06:08:25 -0800 (PST) Message-ID: <9b010600-731d-4be2-ac90-af92cd796b05@redhat.com> Date: Mon, 12 Feb 2024 09:08:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] Patch review volunteers To: Maxim Kuvyrkov , GNU C Library References: From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/5/24 12:45, Maxim Kuvyrkov wrote: > Hi All, > > TL;DR: Answer "yes, I volunteer" to this email. Yes, I volunteer! > Glibc community has a "Patchwork Review Meeting" [1] where we try to assign patches waiting for review to various glibc developers. One challenge, though, is that the current practice is to pick reviewers from the people who happened to join a particular meeting. This process doesn't scale since the number of patches glibc project is receiving is substantially bigger than the number of developers joining the patch review meeting. > > We are seeking volunteers to join the patch reviewer pool to whom we can distribute the load of incoming patches. You agree to be assigned a few patches per week and review them in a reasonable timeframe. If you start joining the review meetings (on Mondays) -- even better! > > We are guessing that a pool of 20 volunteers would be enough to cope with Glibc's current patch influx. This would translate into each volunteer reviewing 1-2 patches (or short patch series) per week. > > You don't have to be a senior developer to join patch review. We will have a smaller pool of senior developers who will help with advice and mentorship when you get assigned to a particularly difficult patch. Joining the patch reviewer pool is a great way to develop your upstream skills. > > Are you joining the patch review volunteers? > > > Disclaimer: > Note, that "patch review" and "patch approval" are different things. Being assigned as patch reviewer is not a grant of a right to unilaterally approve the patch. The usual patch approval process still applies. > > [1] https://sourceware.org/glibc/wiki/PatchworkReviewMeetings > > -- > Maxim Kuvyrkov > https://www.linaro.org > -- Cheers, Carlos.