From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] nptl: Use SA_RESTART for SIGCANCEL handler
Date: Tue, 22 Jun 2021 16:58:10 -0300 [thread overview]
Message-ID: <9ba151ab-bb59-af4a-d48a-4040729b0887@linaro.org> (raw)
In-Reply-To: <87bl7xada6.fsf@oldenburg.str.redhat.com>
On 22/06/2021 16:51, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> * The pthread cancellation handler is now installed with SA_RESTART
>> and pthread_cancel will always send the internal SIGCANCEL on a
>> cancellation request. It should not be visible to application since
>> the cancellation handler should either act upon cancellation (if
>> asynchronous cancellation is enabled) or ignore the cancellation
>> internal signal. However there is buggy kernel interfaces (for
It should be 'there are' here.
>> instance some CIFS modules) that could still see spurious EINTR
>> error when cancellation interrupts a blocking syscall.
>
> Suggest: “some CIFS [versions]”
>
> Rest looks okay to me, thanks.
Ack, I will change and push upstream.
prev parent reply other threads:[~2021-06-22 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:52 Adhemerval Zanella
2021-06-17 13:03 ` Andreas Schwab
2021-06-17 13:04 ` Adhemerval Zanella
2021-06-18 11:38 ` Florian Weimer
2021-06-22 18:30 ` Adhemerval Zanella
2021-06-22 18:33 ` Florian Weimer
2021-06-22 18:50 ` Adhemerval Zanella
2021-06-22 18:52 ` Florian Weimer
2021-06-22 19:50 ` Adhemerval Zanella
2021-06-22 19:51 ` Florian Weimer
2021-06-22 19:58 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ba151ab-bb59-af4a-d48a-4040729b0887@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).