From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C83CB3858D32 for ; Mon, 27 Feb 2023 11:23:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C83CB3858D32 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=linaro.org Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWbbK-0002rr-G9 for libc-alpha@gnu.org; Mon, 27 Feb 2023 06:23:32 -0500 Received: by mail-oi1-x235.google.com with SMTP id bi17so4894214oib.3 for ; Mon, 27 Feb 2023 03:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677497004; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PBvN12W9934W8DpLQYcNa7PkpHDGltyfrzHMm1kr6U0=; b=X/Dr6w7Q6G2scE8WHBqpyHfQTe8SGeZCpQeImpJtnW4I+NTTKihP2A8TH7Q1fq3JB7 2CXxkt3eeTzX/4dBkm/GgBczM8Tx2FRicRw9o4onV/mhgr2nYh6D17L04DjyAmPkzVMD edQlZ2h2AXfNxjqfDtAxtEfiTmT1dpZSM6xZ+gD4fLUgVIf3duPOdhp5F8THVc33GKW9 YSN/JPKZQaEJWbR/5sMY5gYr20lWVqjD3IWKTcduSaqkrJG6IOv3CNGLS0louk2OmBDQ 2MJjzlgym4gAHDYdZxsY/KHcJHfDRvCd5/ruMsOEuQPHzU4XhjOs2Kjg3xuNo3rMptji JL0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677497004; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PBvN12W9934W8DpLQYcNa7PkpHDGltyfrzHMm1kr6U0=; b=l0zr0zMIdLj0ZenBqX3Ta2SYm7IsMLSn3VJRm0ODIzlXhOWKDslDMb2KFkHjQu3pRX 2zaQpLHYCBhU+OAS+5Z/D8SRveMFd+djgUrpicnWK0AsgCIDrUuqpdZS4xW2/c7s0E/h o2M89G0kKtIBvzAIiXwcaKTZugRK7X6GIRZNTQyzYxsrBTeJOFhtDNrmEAVZQHe9kkOS b8FCFESPYcI+9NGioh1jHo49Sv7+vpwA6j9D+yFLDYG2py4WUkm/OTWZ+eEjX+2rqRcB /N+7s3FDklUzsPKjXP8P1JkOTiZydz9Gbu5kcMG0Vkrk9mawgAyR8e94yt/Ut13bvXzz Y3mQ== X-Gm-Message-State: AO0yUKWDnJbfFgijIo4Rr4vZ3GH0vAvUbqh6sICHDhngNsBhvUIN6Dzh l0LFGzEpJlXJNonHTRw3jGpFOA== X-Google-Smtp-Source: AK7set+Jie4IHZFaZSfqpzZ4Jrtq4yAl5/vGW11Nav2Na5UALpP+noGJutNbx3X+xGXMnw8kU+4baQ== X-Received: by 2002:aca:130d:0:b0:378:6035:adda with SMTP id e13-20020aca130d000000b003786035addamr8790139oii.25.1677497003909; Mon, 27 Feb 2023 03:23:23 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:b7aa:65ed:a6ee:da2e:396b? ([2804:1b3:a7c3:b7aa:65ed:a6ee:da2e:396b]) by smtp.gmail.com with ESMTPSA id e4-20020acab504000000b00383dd160a1dsm2973311oif.30.2023.02.27.03.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 03:23:23 -0800 (PST) Message-ID: <9bb68f46-9932-209b-b37b-0c3da83cff56@linaro.org> Date: Mon, 27 Feb 2023 08:23:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] cdefs.h: fix "__clang_major" typo Content-Language: en-US To: Carlos O'Donell , Paul Eggert , libc-alpha@gnu.org References: <20211221221329.347210-1-eggert@cs.ucla.edu> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::235; envelope-from=adhemerval.zanella@linaro.org; helo=mail-oi1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,NICE_REPLY_A=-0.001,RCVD_IN_DNSWL_NONE=-0.0001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/02/23 15:30, Carlos O'Donell wrote: > On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 21/12/2021 19:13, Paul Eggert wrote: >>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella > > Ahemerval, > > In reviewing old patches to improve our SLI for patch review I noticed that > this patch is reviewed and approved but not committed. The patch still looks > correct to me. > > Would you mind committing this on behalf of Paul please? > > Done. >>> --- >>> misc/sys/cdefs.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >>> index a05b538579..f6e1db1954 100644 >>> --- a/misc/sys/cdefs.h >>> +++ b/misc/sys/cdefs.h >>> @@ -81,7 +81,7 @@ >>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >>> # else >>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >>> # if __cplusplus >= 201103L >>> # define __THROW noexcept (true) >>> # else >> >