From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59684 invoked by alias); 28 Oct 2016 17:30:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59659 invoked by uid 89); 28 Oct 2016 17:30:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f177.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=EognT5suCSGBuF2e9PpQG13cNoZp85uT50e102ysx+s=; b=OPhTOgWHMiXB4bdme36wnqLV0f6+8OD4FMtvjGz4Rv8vkXoflxOEZq8oWL3SbUWqMD o7fZQOZ5QU4E7kZmEyFhyihFer0zvs3v7y9NJ/aFZUPiR4ZQ4oOZLJ3A57pbmSqP5pGh vcEIie1PX9w/Jm1eBCwNyyctKwa5yhYTi+cU28lho3/vfbdmtR3d65Hekvb/Hy7+aeWR hm9qAaKpSQ2mouCKS507gcG4SIi2YzoY6jONZOzA8l3QpZwbos/I/TebCjAj/BN64G1N N02UtFdwOk21PbjHHpCXrdzwRNoHVUSkKTob2CVLdJN0mtNqqnIBSb+xv/Ug6u0efkcd cN9g== X-Gm-Message-State: ABUngvcmF2MBiYliHfY719xyzkZCgwo7+z4PV+dMv+QsiFwFqVOLn6NcI/HNNkKwh5VdUysl X-Received: by 10.55.163.138 with SMTP id m132mr11363970qke.88.1477675797246; Fri, 28 Oct 2016 10:29:57 -0700 (PDT) Subject: Re: [PATCH] Add test for linking against most static libraries To: Florian Weimer , libc-alpha@sourceware.org References: <20161028125742.928D7439942E0@oldenburg.str.redhat.com> <8b17140d-bbab-95c1-7458-7214f0e474ad@redhat.com> From: Carlos O'Donell Message-ID: <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com> Date: Fri, 28 Oct 2016 17:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <8b17140d-bbab-95c1-7458-7214f0e474ad@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00552.txt.bz2 On 10/28/2016 10:51 AM, Carlos O'Donell wrote: > On 10/28/2016 08:57 AM, Florian Weimer wrote: >> 2016-10-28 Florian Weimer >> >> * elf/tst-linkall-static.c: New file. >> * elf/Makefile (tests-static): Add tst-linkall-static. >> (tst-linkall-static): Link against static libraries. > > LGTM. Thanks for increasing test coverage. > This breaks my i486 -Os build with a test build failures because it can't find crypt.h. I don't see that any of the sysdep selection mechanisms add crypt to the list, therefore you can't access crypt headers. However, the crypt/ tests themselves seem to get an absolute path added explicitly, so they work. The only other reference is from locale/Makefile which also adds -I../crypt via vpath and CFLAGS-*. I'm kinda baffled by this. We don't set it in config-sysdirs. I expect you have a local patch that hid this. I'm going to commit the following immediate fix: 2016-10-28 Carlos O'Donell * elf/Makefile (CFALGS-tst-linkall-static): Define. diff --git a/elf/Makefile b/elf/Makefile index 82c7e05..a8d2bfe 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1280,6 +1280,7 @@ $(objpfx)tst-ldconfig-X.out : tst-ldconfig-X.sh $(objpfx)ldconfig $(objpfx)tst-dlsym-error: $(libdl) +CFLAGS-tst-linkall-static = -I../crypt $(objpfx)tst-linkall-static: \ $(common-objpfx)math/libm.a \ $(common-objpfx)crypt/libcrypt.a \ --- -- Cheers, Carlos.