From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by sourceware.org (Postfix) with ESMTPS id DD59C3937421 for ; Wed, 14 Oct 2020 14:43:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD59C3937421 Received: by mail-qv1-xf41.google.com with SMTP id t6so1615483qvz.4 for ; Wed, 14 Oct 2020 07:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ko7pbifczA5WW2lxQxT9urYKumRi9b+A89Mjr/ZhQfc=; b=W7YXkN2ZINvgr3p3X/2AJjTgaNtF5U0fcsDTZjlBJZSx9qGf6fHoo+d36oVZCT8eds 3RX1wRK60wHCa5TP9gknwxa7TIBFR3OqYzTFi9orxObqtfVPFBte0POaMCAXKN2wXHtU AxOAoW/iFEeQSkSfhkrG/MinKJMQwUIsi/RCELf2PspZA51r9egUiecML8xHbODjsdhG Ei7yWi4PfSdN3G8mceQ5CE39NYgjX/WUkqct7KehZWHBkRf7QKRaiZdI+SYn31Zp89mW 7xzTh42f9Au2nyyOmh5SMwjXDEi0baDXGLs6rYQKWwqDTk7xlBO6ve13ipObBaw2WjBX mxAQ== X-Gm-Message-State: AOAM5336KF7heenNRTR7PStawiNDQr5Tcc+aUp66Ttv4LajjFxcjtQCf dNPQWqMNTTyHrcSQTFCODaUbGueldCpARQ== X-Google-Smtp-Source: ABdhPJzq34D3J9LqonjfWM9R2XQDrR1ODbhRPo0iad3TTLlHt+NvZeE/LUrxvr5+e0ps+RFqctT9Eg== X-Received: by 2002:a0c:b410:: with SMTP id u16mr5101539qve.52.1602686601209; Wed, 14 Oct 2020 07:43:21 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id t9sm1321253qkt.49.2020.10.14.07.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 07:43:20 -0700 (PDT) Subject: Re: [PATCH 20/28] aarch64: Add glibc-hwcaps support To: Szabolcs Nagy Cc: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <90b5f27a-9da8-76b0-b12d-907dcd7f7c0c@linaro.org> <87r1q0oq6j.fsf@oldenburg2.str.redhat.com> <3a7b2533-e6c7-5ded-2d94-b1b5c41de424@linaro.org> <20201014143750.GF3819@arm.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <9cae6181-56a1-9d9d-0b0d-ea3880ef9e06@linaro.org> Date: Wed, 14 Oct 2020 11:43:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014143750.GF3819@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 14:43:23 -0000 On 14/10/2020 11:37, Szabolcs Nagy wrote: > The 10/14/2020 11:15, Adhemerval Zanella via Libc-alpha wrote: >> On 14/10/2020 11:08, Florian Weimer wrote: >>> * Adhemerval Zanella via Libc-alpha: >>>> On 01/10/2020 13:33, Florian Weimer via Libc-alpha wrote: >>>>> At this point, only the "atomics" subdirectory is available, >>>>> for libraries built using LSE atomics. >>>> >>>> LGTM, thanks. >>>> >>>> Reviewed-by: Adhemerval Zanella >>> >>> Thanks. I didn't want to skip AArch64, but it's really more of a stub >>> implementation: >>> >>>>> +const char _dl_hwcaps_subdirs[] = "atomics"; >>> >>> Does this still make sense with GCC defaulting to -moutline-atomics for >>> ARMv8a? That's what I wonder. >>> >>> Eventually, we need to define some levels for AArch64, and I'm not sure >>> to what extent they would align with the official 8.X versions. To me, >>> they look more like a bouquet you can choose from. >> >> I am not sure how ARM maintainers would like to handle it, either by >> defining based on ARMv8.x revisions, a subsets of HWCAP capabilities, >> or by not defining anything. >> >> For now I think the atomic makes sense because of -moutline-atomics, >> although it is essentially ARMv8.1. > > the atomics path logic was added in glibc 2.28 in > commit 397c54c1afa531242602fe3ac7bb47eff0e909f9 > (see the reasoning in the commit message). > > since then this is public api that users may rely > on (although likely there are not many users..) > > so i dont want to remove it (and yes it's not > very helpful now that outline-atomics is the > default in gcc). > > otoh i did not review this patch when it was > posted because i wanted the return value to > not be a signed int when it is a bit mask. > Ok fair enough, do you plan to send an updated version Florian or the rest of the set is ok as-is to review?