From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 70DBA3857C4D for ; Thu, 27 Jan 2022 18:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70DBA3857C4D Received: by mail-oi1-x229.google.com with SMTP id w133so7442634oie.7 for ; Thu, 27 Jan 2022 10:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s4NR8vJCPoPj5JoNYHan6RMB4SxZ40ByrZ+sOnVvOOQ=; b=XYX6HeQ+Y3hSy4i/7USw3RV6MPS1CCe9A4mRRIIPED1SwotaFao99qGBR1OVdhW39v AgMM61u799/0ubJ7/wBkBYmNhRMnh7TVG4lSfRtgBQMhhXlz/XFnsNziw+1Pp0u2b2A1 vf4sfhbxGH+6PqkmlPOKRzbHcy9/f1LyzCfCkVbRcEXzrLIqSUXHV0PJIIXP7iOO4aVD etGyCWR185RH81F41HnLM1a5rwOVoXzKFe7KpfvOZ+ChVzuZnQNNY7zEJj0szrxqNhz9 mRxuytEY0pCgX8VD/KvCYxIScZtP5I4exlvnE/lJSG/lEmlQUGD5aqjgwYjlVQ5L3t4k ZSqg== X-Gm-Message-State: AOAM53015ZSKKdCE3nFh1s/dnMqSRcUglWsJ0fDbCaRB+R5n4U0Uy1ni 29AHq5Dy8xE+hYBRaP77kN9yVA== X-Google-Smtp-Source: ABdhPJzBij7cATvTAUPTeAZ/H4TddMvNQ42TtlsRnmSd1lboQYtAnNUndbqJ2XiGJgI55lsNnWov0A== X-Received: by 2002:aca:f106:: with SMTP id p6mr7367775oih.285.1643306971619; Thu, 27 Jan 2022 10:09:31 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:1507:9c68:3ec9:801? ([2804:431:c7ca:709a:1507:9c68:3ec9:801]) by smtp.gmail.com with ESMTPSA id g10sm8058519otn.65.2022.01.27.10.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 10:09:31 -0800 (PST) Message-ID: <9cba4ff5-49c6-e597-85f5-45be0021bfa7@linaro.org> Date: Thu, 27 Jan 2022 15:09:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np Content-Language: en-US To: Samuel Thibault Cc: Florian Weimer , libc-alpha@sourceware.org References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> <20220127171557.kseob4ysn5tgcsg4@begin> From: Adhemerval Zanella In-Reply-To: <20220127171557.kseob4ysn5tgcsg4@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 18:09:36 -0000 On 27/01/2022 14:15, Samuel Thibault wrote: > Hello, > > Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit: >> On 27/01/2022 13:11, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the >>>> controlling terminal), so it would make more sense to actually fit >>>> it on the file actions API. >>>> >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is >>>> implicit by the presence of tcsetpgrp file action. >>>> >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present. >>>> >>>> Checked on x86_64-linux-gnu and i686-linux-gnu. >>> >>> This has an ABI check failure on Hurd: >>> >>> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F >>> >>> The changes look okay to me. A second review is probably warranted at >>> this stage. >> >> Thanks. It is really annoying that hurd make update-abi adds a bunch of files >> and requires manual edit to get it right. > > I don't think I understand. How is it different in the linux case? A 'make update-abi' with a default 'configure --prefix=/usr' creates two files on source: $ git status On branch master Your branch is up to date with 'origin/master'. Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: sysdeps/mach/hurd/i386/libc.abilist modified: sysdeps/mach/hurd/libhurduser.abilist modified: sysdeps/mach/libmachuser.abilist And the libc.abilist is jsut annoying by the fact Hurd seems to use a different default path than Linux ports (which generates an _nl_default_dirname with different size). Am I doing something wrong with the Hurd build?