From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by sourceware.org (Postfix) with ESMTPS id 193783857815 for ; Mon, 21 Dec 2020 13:44:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 193783857815 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 13FF3181A75; Mon, 21 Dec 2020 13:44:38 +0000 (UTC) Received: from pdx1-sub0-mail-a74.g.dreamhost.com (100-100-138-63.trex.outbound.svc.cluster.local [100.100.138.63]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5471E180E5B; Mon, 21 Dec 2020 13:44:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a74.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 21 Dec 2020 13:44:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Eyes-Drop: 6f2d405d0ba943ba_1608558277617_2506432720 X-MC-Loop-Signature: 1608558277617:1184233330 X-MC-Ingress-Time: 1608558277617 Received: from pdx1-sub0-mail-a74.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTP id CC1257F73C; Mon, 21 Dec 2020 05:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:from :to:references:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=geY1+a hMUOhX2b5ltfC/o5Uq+sg=; b=kb2WeAZInXzRFAU3gmP5+HPe/FF2GTvta/+Li1 xWX3wA6WXwW4Qg3GLM66D5zMwapNB+hPuaEAsqjd2mIcSdS9z7h+Gn9TPBfog9A/ p6guqwnPoOU3ehm8eV9MT7zj09s0BOGZkh1RpwW2xcSlG5REYrROw+e/5iuqHpWC QpkQE= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTPSA id 1B480830A4; Mon, 21 Dec 2020 05:44:34 -0800 (PST) Subject: Re: [PATCH v4 0/6] Memory tagging support X-DH-BACKEND: pdx1-sub0-mail-a74 From: Siddhesh Poyarekar To: Richard Earnshaw , libc-alpha@sourceware.org References: <20201218192957.11035-1-rearnsha@arm.com> <077702a8-04dd-d9eb-2a9b-b27caf1a532f@gotplt.org> Message-ID: <9cf938d0-c115-6e1c-9bd6-afe7d3edfe5a@gotplt.org> Date: Mon, 21 Dec 2020 19:14:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <077702a8-04dd-d9eb-2a9b-b27caf1a532f@gotplt.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 13:44:46 -0000 On 12/21/20 5:58 PM, Siddhesh Poyarekar wrote: > On 12/19/20 12:59 AM, Richard Earnshaw via Libc-alpha wrote: >> Main changes in this version: >> >> =C2=A0 - collapse the changes to the malloc code to a single patch. >> =C2=A0 - change _LIBC_MTAG to USE_MTAG. >> =C2=A0 - comments around definition of PROT_MTE. >> =C2=A0 - tunable renamed to glibc.mem.tagging. >> =C2=A0 - cleanups to assembler files for aarch64 support. >> >=20 > I've tested the build to verify that --enable-memory-tagging works=20 > correctly on x86_64 and the resulting bins don't regress the testsuite.= =20 > =C2=A0I'm working through the individual patches to review; will post=20 > comments shortly. I've gone through the patch series and I think it is good to go with a=20 couple of minor changes I've suggested in the reviews. I've mostly=20 deferred to Szabolcs' review for 5/6 and 6/6 since they're aarch64-specif= ic. The changes are small enough that you could commit with the changes.=20 However, please post the series that you commit so that we know what=20 went in finally. Thanks, Siddhesh