From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 0EA833858D1E for ; Thu, 19 Oct 2023 19:23:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EA833858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EA833858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697743418; cv=none; b=ZvY/D+ADg0T4dgzod86o833g2DdQcgln3WDlrcDd3c4IiCTbIqOs4AEc81XG8j0cSoTBUA+kT6/mo6AtL3BGDrh+JLYJJ8x5eivvtKgYbeh+TWAFvpdaOHT+W9BVoNy81vXL8QK6RH1wfTbkdAYQsZpRyPZtjjFlndaM9KY8s98= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697743418; c=relaxed/simple; bh=ZAJH/TR97RWrN/1CKwOnBAccy5nY7dKaSmGeXDS5ov0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bMEAslJzi3Tm0GyhSUB9PTIPihAznZ3mDprqMlfYRxMUAkRgLVQpxG/xG0SbqTRzmev7yLhUpZ0hOwi89QeMmbYAm7MtiLC1QnqNrmUO9CpXyw66Goc7DxvkYyMmnNljbLCEeQwSBu4bjPIhZogFZ4quCPhWJaZekDOUXKLWqMc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1ca74e77aecso8942775ad.1 for ; Thu, 19 Oct 2023 12:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697743416; x=1698348216; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SAB/Qg6iHjhsUzQoX1LKPyWoLSFDN7pVs7bmPfMHqew=; b=Fptg7nYFr0NIMs91BOdjBea/uRHBoSX+Wf2RSrwCiWodkrrtIb9q6uDAtMXsOuOq/8 UYIupaZA9JddUo01TAJ/K07TMZnAwK6G7Mkgn4WLCxAQw/3WPo2iENFRlICIqKgk2vM3 aGmBUD0OUD5ipfJfTcImy1L56KRc4Yb0ckHC/bvzZGpDbXW06RZEF1E/3taC43Gz0Dm8 7UAIn6jvZ+aLxXABVMfGZ0sTemAY/ReFtANnG2TInvlgM5RJ53XS8ZIjTGsHYXT8H8Za oxzixx/WTfso6czZ29D45D+YWvbVwn5jspSznT7WgH63XZKPlRQSO8bnt9sIKgefla18 oMdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697743416; x=1698348216; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SAB/Qg6iHjhsUzQoX1LKPyWoLSFDN7pVs7bmPfMHqew=; b=Yq6log3/CEtH20rEJS2DQ3QC4iHVsDTnNPGBEz5iI7FpvTQY5gvnpELUJQo51/j6M/ uCAngC9sArz9Nbyd6DuILNY4aWeG0isHo2+wFrgzb0yd1noylJTsQ1tH1yRG9KHdaQwt Wl/4/XSwriUeag7yX9NxB+Gxase9OBMbexflZKhwXauF3f73wVRzd7N/dFcNnpmph3rX ONFkamW6LdZnx8R/8Eh15wq5M5I/GJN84UDY36X3DqAEXB1FiJoYlQTR7galh7pnExr2 l1zJ0ob/0LaA7z4LEOnFf+stWAr2ShQFF5V9cURP2A26I0MkJHiA+1zlxLbFtH6QhHjP F4Jg== X-Gm-Message-State: AOJu0Yxv+ImfWZzwh4qZiuL0X7CubvhYKzN0b1DlXAmvnQQtgy3ImYYp LCCyx3CBW4pk+VC65YPQ7AqUvw== X-Google-Smtp-Source: AGHT+IEc3RzNiBof4tslqpv3AEIpjnamJ08Qs1PcbPuITuShgHeWVLswoaoCTyzlKhBwJhRVPkwxlQ== X-Received: by 2002:a17:902:e5d0:b0:1c9:d236:b2b with SMTP id u16-20020a170902e5d000b001c9d2360b2bmr3552494plf.12.1697743415955; Thu, 19 Oct 2023 12:23:35 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:a647:51c8:7d15:99b:dc36? ([2804:1b3:a7c3:a647:51c8:7d15:99b:dc36]) by smtp.gmail.com with ESMTPSA id h1-20020a170902704100b001c60a548331sm53120plt.304.2023.10.19.12.23.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 12:23:35 -0700 (PDT) Message-ID: <9d623890-3dcd-4670-8501-5e28d227dc09@linaro.org> Date: Thu, 19 Oct 2023 16:23:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/16] Move 'aliases' routines from 'inet' into 'nss' Content-Language: en-US To: Arjun Shankar , libc-alpha@sourceware.org References: <20231002130150.1497733-1-arjun@redhat.com> <20231002130150.1497733-8-arjun@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20231002130150.1497733-8-arjun@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/10/23 09:55, Arjun Shankar wrote: > The aliases routines are entry points for nss functionality. This > commit moves aliases.h and the aliases routines from the 'inet' > subdirectory to 'nss', and adjusts any external references. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > include/aliases.h | 2 +- > inet/Makefile | 7 ------- > inet/Versions | 1 - > nss/Makefile | 14 ++++++++++++++ > nss/Versions | 1 + > {inet => nss}/aliases.h | 0 > {inet => nss}/getaliasent.c | 0 > {inet => nss}/getaliasent_r.c | 0 > {inet => nss}/getaliasname.c | 0 > {inet => nss}/getaliasname_r.c | 0 > 10 files changed, 16 insertions(+), 9 deletions(-) > rename {inet => nss}/aliases.h (100%) > rename {inet => nss}/getaliasent.c (100%) > rename {inet => nss}/getaliasent_r.c (100%) > rename {inet => nss}/getaliasname.c (100%) > rename {inet => nss}/getaliasname_r.c (100%) > > diff --git a/include/aliases.h b/include/aliases.h > index db82588630..2c7756efe8 100644 > --- a/include/aliases.h > +++ b/include/aliases.h > @@ -1,5 +1,5 @@ > #ifndef _ALIASES_H > -#include > +#include > > # ifndef _ISOMAC > > diff --git a/inet/Makefile b/inet/Makefile > index 9db7f941c6..bd3dc58322 100644 > --- a/inet/Makefile > +++ b/inet/Makefile > @@ -24,7 +24,6 @@ include ../Makeconfig > > headers := \ > $(wildcard arpa/*.h protocols/*.h) \ > - aliases.h \ > bits/in.h \ > ifaddrs.h \ > netinet/ether.h \ > @@ -49,10 +48,6 @@ routines := \ > ether_ntoa \ > ether_ntoa_r \ > ether_ntoh \ > - getaliasent \ > - getaliasent_r \ > - getaliasname \ > - getaliasname_r \ > gethstbyad \ > gethstbyad_r \ > gethstbynm \ > @@ -176,8 +171,6 @@ CFLAGS-getnetbyad_r.c += -fexceptions > CFLAGS-getnetbyad.c += -fexceptions > CFLAGS-getnetent_r.c += -fexceptions > CFLAGS-getnetent.c += -fexceptions > -CFLAGS-getaliasent_r.c += -fexceptions > -CFLAGS-getaliasent.c += -fexceptions > CFLAGS-getrpcent_r.c += -fexceptions > CFLAGS-getrpcent.c += -fexceptions > CFLAGS-getservent_r.c += -fexceptions > diff --git a/inet/Versions b/inet/Versions > index 84cbe847cd..e6d1e6f1ba 100644 > --- a/inet/Versions > +++ b/inet/Versions > @@ -14,7 +14,6 @@ libc { > ether_ntoa_r; ether_ntohost; > > # g* > - getaliasbyname; getaliasbyname_r; getaliasent; getaliasent_r; > getdomainname; gethostbyaddr; gethostbyaddr_r; gethostbyname; > gethostbyname2; gethostbyname2_r; gethostbyname_r; gethostent; > gethostent_r; getnetbyaddr; getnetbyaddr_r; getnetbyname; > diff --git a/nss/Makefile b/nss/Makefile > index 84cf62af2b..2dfa7ebef9 100644 > --- a/nss/Makefile > +++ b/nss/Makefile > @@ -23,6 +23,7 @@ subdir := nss > include ../Makeconfig > > headers := \ > + aliases.h \ > grp.h \ > gshadow.h \ > nss.h \ > @@ -54,6 +55,19 @@ routines = \ > valid_list_field \ > # routines > > +# alias routines: > +routines += \ > + getaliasent \ > + getaliasent_r \ > + getaliasname \ > + getaliasname_r \ > + # routines > + > +ifeq ($(have-thread-library),yes) > +CFLAGS-getaliasent_r.c += -fexceptions > +CFLAGS-getaliasent.c += -fexceptions > +endif > + > # grp routines: > routines += \ > fgetgrent \ > diff --git a/nss/Versions b/nss/Versions > index 632af25be4..5d1b1dac3d 100644 > --- a/nss/Versions > +++ b/nss/Versions > @@ -17,6 +17,7 @@ libc { > fgetspent; fgetspent_r; > > # g* > + getaliasbyname; getaliasbyname_r; getaliasent; getaliasent_r; > getgrent; getgrent_r; getgrgid; getgrgid_r; getgrnam; getgrnam_r; > getgroups; > getpw; getpwent; getpwent_r; getpwnam; getpwnam_r; getpwuid; getpwuid_r; > diff --git a/inet/aliases.h b/nss/aliases.h > similarity index 100% > rename from inet/aliases.h > rename to nss/aliases.h > diff --git a/inet/getaliasent.c b/nss/getaliasent.c > similarity index 100% > rename from inet/getaliasent.c > rename to nss/getaliasent.c > diff --git a/inet/getaliasent_r.c b/nss/getaliasent_r.c > similarity index 100% > rename from inet/getaliasent_r.c > rename to nss/getaliasent_r.c > diff --git a/inet/getaliasname.c b/nss/getaliasname.c > similarity index 100% > rename from inet/getaliasname.c > rename to nss/getaliasname.c > diff --git a/inet/getaliasname_r.c b/nss/getaliasname_r.c > similarity index 100% > rename from inet/getaliasname_r.c > rename to nss/getaliasname_r.c