From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id DDC0A3857C73 for ; Fri, 19 Mar 2021 20:33:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DDC0A3857C73 Received: by mail-qk1-x72a.google.com with SMTP id g15so4323208qkl.4 for ; Fri, 19 Mar 2021 13:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KonCE0vth+2iRGS3S26bf/0wOLggb/GTHgPB+xzR/Fc=; b=F0NnAAW/Coe8vVj5A06PIsloiR7RNkQP1wVLdWtVGAJNiiPUM/XMVtEq79721UQam2 UsNYzkQ7IkKKP81QNfKeba9TbK9XRjfFqmP4xTp95iql1JF+VVQyX9Ixat/WLa91z7JQ 2uqzzzw5w0wIzKr1kaD03DSdfQZJam39FVoqBsSstuWmcgcCPKUZNuFMSZbZ95KXRJtT jfXvm9HMF19EAad3R60xidUbq+5Ydzu/yADNSIdMJkRxj7ja+Ohw+D+49v5mJ7g/plxK PKjKK3DVRTkdokyVHZIyrrfKDbXOy8C35dT1YlkM8AvfWcdkymMN2oTu9B35gMosenzc dSog== X-Gm-Message-State: AOAM5311sljzmoq6M0TRNmPt+b7Xiz6sEM/UchxtVXJ5VNYCJrf7gujH lSw//AdsMC1YN09ZyC8+I/8x+/HNI4iomAf/ X-Google-Smtp-Source: ABdhPJyMIrRVmW53RxFbWnilI44jsFxA0KgkINjULJv/8ox0vZ7Syii8PhYB4D869aMw7Gobrl7jVQ== X-Received: by 2002:ae9:f444:: with SMTP id z4mr450771qkl.226.1616185994360; Fri, 19 Mar 2021 13:33:14 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id o7sm5533462qkb.104.2021.03.19.13.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 13:33:14 -0700 (PDT) Subject: Re: [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol To: Florian Weimer Cc: libc-alpha@sourceware.org References: <965a0d7e0c28a5a0ce292a2b0bd39f2ba31d1a84.1616095061.git.fweimer@redhat.com> <37e68057-c3be-b522-98a3-1837b02c490a@linaro.org> <8735wqj3ub.fsf@oldenburg.str.redhat.com> <87y2eihop2.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <9d735827-0c63-cc97-c2d1-32d25937abd6@linaro.org> Date: Fri, 19 Mar 2021 17:33:11 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87y2eihop2.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 20:33:16 -0000 On 19/03/2021 17:29, Florian Weimer wrote: > * Adhemerval Zanella: > >> The __attribute__ ((nocommon)) on the malloc hook fixed the build issue. > > I've fixed this locally, and also added to versioned_symbol: > > If LOCAL is a data symbol and does not have a non-zero initializer, > it should be defined with __attribute__ ((nocommon)) for > compatibility with GCC versions that default to -fcommon. */ > > Should I posted a v3? I don't think is a need, I will review the v2.