From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)
Date: Fri, 01 Jun 2018 21:53:00 -0000 [thread overview]
Message-ID: <9dda9f97-c39b-d534-198e-7d87aa68a46d@linaro.org> (raw)
In-Reply-To: <ddc9df2c-0577-47d6-d3d6-abf0eb7a9251@linaro.org>
On 01/06/2018 18:48, Adhemerval Zanella wrote:
>>
>> The new code calls SYSCALL_CANCEL for many more cases, some of which probably are bugs.
>
> Indeed the F_{OFD}_GETLK* case is not the case for cancellation (since the
> lock won't be enforced by kernel). My understanding is both POSIX and Linux
> OFD locks have similar code path which may suspend process execution (the
> case for cancellation syscall). Do you have any reservation about making
> F_OFD_GETLK a cancellation entrypoint as well?
The questioning in fact for F_SETLK64/F_SETLKW64/F_OFD_SETLK/F_OFD_SETLKW
(instead of F_OFD_GETLK).
next prev parent reply other threads:[~2018-06-01 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 21:27 Adhemerval Zanella
2018-04-30 11:10 ` Adhemerval Zanella
2018-05-04 17:54 ` Adhemerval Zanella
2018-05-21 19:01 ` Adhemerval Zanella
2018-05-25 20:03 ` Adhemerval Zanella
2018-06-01 14:49 ` Adhemerval Zanella
2018-06-01 15:00 ` Florian Weimer
2018-06-01 20:38 ` Adhemerval Zanella
2018-06-01 20:50 ` Joseph Myers
2018-06-01 21:49 ` Adhemerval Zanella
2018-06-01 21:07 ` Florian Weimer
2018-06-01 21:48 ` Adhemerval Zanella
2018-06-01 21:53 ` Adhemerval Zanella [this message]
2018-06-02 8:00 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dda9f97-c39b-d534-198e-7d87aa68a46d@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).