From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4A3753836027 for ; Sat, 17 Jul 2021 22:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A3753836027 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-ALQm290qNwyjQ3vAjjZjZQ-1; Sat, 17 Jul 2021 18:03:40 -0400 X-MC-Unique: ALQm290qNwyjQ3vAjjZjZQ-1 Received: by mail-qv1-f71.google.com with SMTP id e19-20020ad442b30000b02902dc988b8675so10263737qvr.3 for ; Sat, 17 Jul 2021 15:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KvG5YEaQgFN88d9/4drc80P8+Vx/oVGbTKphdP122IE=; b=QiOpk3BhHrssSBvEmk1ARQDltD4cKMn3gQfSAMzaFhUlxXl+A/XTil1ZfdADcIlWwe lauRUl9PIe+x2m5Xuokvlkyz2OF5To5TysihqH4UaxkR/DdBN21SM2DHcbEsw8lmtGVB pRTSVyFXo79oK4bKTkKVL6KVKkvjhdY7Gkc2DvoBPkw0e06KaqJqJJEbHlp1gX8zIaBf gNT0D/sVY2WgjbWgxx3LXYmF49n+D1ZPG2HAm29qgtKytY6FUOGDMyg7Ai4jshA/qfRP Y9ng3SCvx6irSHCtfW518EG0nvYbJclL4VWcI4uzjmkUiicpdgbHIdsmVeesjanFxnJs 05fw== X-Gm-Message-State: AOAM530h/1Z8PiIzVhfm6fQ39QTjDdG361nVc1dc+rqkNquG1rlTOBgW sxFhlVZDVEG+a6eYVo/d4bVf1o8jcwr+vIfZpsvqW3HC4B8oiRQOn7j9mbrmWTiPKnmSPjXyOs/ VGnt2viRb9aBFB60LvmYy X-Received: by 2002:ac8:6d0:: with SMTP id j16mr15806649qth.331.1626559420304; Sat, 17 Jul 2021 15:03:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFKSRniu2rko8ikzLBP96dmigeDNK9zUTDCp35nwO1kd5X7kMIX9ykSniXGpN1On6CYMSkhA== X-Received: by 2002:ac8:6d0:: with SMTP id j16mr15806637qth.331.1626559420140; Sat, 17 Jul 2021 15:03:40 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id z23sm2791396qts.96.2021.07.17.15.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jul 2021 15:03:39 -0700 (PDT) Subject: Re: [PATCH v8 01/10] Make mcheck tests conditional on GLIBC_2.24 or earlier To: Siddhesh Poyarekar , libc-alpha@sourceware.org Cc: dj@redhat.com, fweimer@redhat.com References: <20210713073845.504356-1-siddhesh@sourceware.org> <20210713073845.504356-2-siddhesh@sourceware.org> From: Carlos O'Donell Organization: Red Hat Message-ID: <9de6059e-c0cf-83df-a51b-9d8809d1f6bb@redhat.com> Date: Sat, 17 Jul 2021 18:03:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713073845.504356-2-siddhesh@sourceware.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jul 2021 22:03:43 -0000 On 7/13/21 3:38 AM, Siddhesh Poyarekar wrote: > Targets with base versions later than 2.24 won't have > __malloc_initialize_hook because of which the tests will essentially > be the same as the regular malloc tests. Avoid running them instead > and save time. Use have-GLIBC_2.23 for the release before the deprecation of a symbol. Post v9 please and I'll ACK it quickly. Tested-by: Carlos O'Donell > --- > malloc/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/malloc/Makefile b/malloc/Makefile > index 47369b6084..d15729569b 100644 > --- a/malloc/Makefile > +++ b/malloc/Makefile > @@ -78,6 +78,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \ > # Run all tests with MALLOC_CHECK_=3 > tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests)) > > +# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24. OK. Wow, 5 years ago. > +ifeq ($(have-GLIBC_2.24)$(build-shared),yesyes) Should be have-GLIBC_2.23, since if it was deprecated in 2.24, a new arch in 2.24 would not have it and it should be tested. You always want the conditional to trigger on the last release to have the symbol. > # Tests that don't play well with mcheck. They are either bugs in mcheck or > # the tests expect specific internal behavior that is changed due to linking to > # libmcheck.a. > @@ -100,6 +102,7 @@ tests-exclude-mcheck = tst-mallocstate \ > tst-reallocarray > > tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests)) > +endif OK. > > routines = malloc morecore mcheck mtrace obstack reallocarray \ > scratch_buffer_dupfree \ > -- Cheers, Carlos.