From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by sourceware.org (Postfix) with ESMTPS id EEAF03857000 for ; Tue, 9 Aug 2022 18:48:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEAF03857000 Received: by mail-vs1-xe32.google.com with SMTP id q15so12905512vsr.0 for ; Tue, 09 Aug 2022 11:48:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=0YDA/ru9gVk8pfBERDMr9L5s1y6UkMIbQaSb/TiweZ4=; b=tdv504YZQQ4dEFwPBTsWaAdjObnL2xz6vIK7BlVilP98MMtjpXyuodu1qvMRX+sKql RTX5oZq3/kgTA5G4+NhXEYbO/gDQNRgx4ToorRXZY7dk7hEGhRCvuaPCnon1jsGtxeRK bPTj1f0ZQP1cXj5Lwu8NQ/5ijitt5nm6lQhkvuJ1mQem/PS+RWwNpiegINCUcrWrdE/f kQtnhc4hJvi5Et0tVSZybVB6AaRqoB/isCW40/t6XA11Vbj3lcnHopFPseegurT8g1At dOqX/nACNr7FCVUhsUk9FcdFoBAtctsmAGrOlhJLgZ/Tjirr9TVf906g8q0LcA2fKr7f u3hQ== X-Gm-Message-State: ACgBeo32z8oCLQkkNCSoWHvBy/NDRiKFidVfcYxLpdFgMKPa7IKF0frx MnBBMk1ylw78Kl70DYI4jWA4Ew== X-Google-Smtp-Source: AA6agR7ciueqGxKNpRZx2BHB/Uh6JAr4Bj2Utp3ktlqxEZKhfISIrFs3Yb2Oskmjt6KooaPesypljg== X-Received: by 2002:a67:a448:0:b0:35a:1611:172a with SMTP id p8-20020a67a448000000b0035a1611172amr10832138vsh.39.1660070896353; Tue, 09 Aug 2022 11:48:16 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:930b:1501:cb0e:82b0:65e1? ([2804:431:c7ca:930b:1501:cb0e:82b0:65e1]) by smtp.gmail.com with ESMTPSA id x140-20020a1f3192000000b00378a524ac44sm9208735vkx.30.2022.08.09.11.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 11:48:16 -0700 (PDT) Message-ID: <9e01cc4b-7acd-5719-6615-8fb3cb6bf80b@linaro.org> Date: Tue, 9 Aug 2022 15:48:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support Content-Language: en-US To: "H.J. Lu" Cc: GNU C Library References: <20220808200021.763123-1-adhemerval.zanella@linaro.org> <8edb1934-df86-6956-b90c-16032ff67df9@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 18:48:18 -0000 On 09/08/22 15:31, H.J. Lu wrote: > On Tue, Aug 9, 2022 at 5:11 AM Adhemerval Zanella Netto > wrote: >> >> >> >> On 08/08/22 19:16, H.J. Lu wrote: >> >>>> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S >>>> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S >>>> @@ -44,4 +44,7 @@ >>>> >>>> # define USE_LESS_VEC_MASK_STORE 1 >>>> # include "memset-vec-unaligned-erms.S" >>>> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4 >>>> +strong_alias (__memset_evex_unaligned, __memset_generic) >>>> +# endif >>>> #endif >>> >>> This will define 2 __memset_generic for -march=x86-64-v4. >> >> Are you sure? Check with a x86_64 build with -march=x86-64-v4 I am seeing: >> >> $ readelf -Ws string/memset*.os | grep -w __memset_generic | wc -l >> 1 >> >> And it is indeed provided only by string/memset-evex-unaligned-erms.os. > > You are right. Since dl-symbol-hacks.h defines memset to an alias, > should it be moved to sysdes/generic and each arch can provide a > suitable alias? The dl-symbol-hacks.h is meant to be used solely by loader code (that's why I have added to elf/), but I don't have a strong preference.