From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 7F507385E445 for ; Fri, 15 Mar 2024 19:57:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F507385E445 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F507385E445 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710532642; cv=none; b=NwnMFtYQL2Hr8uYj5ab79c3FDWmQ3du+E899maKwC+afI0WZGCjjw3A1s0B08EInQcZyM093Lt5WYu6ZJPerE62U652euuxlF6B6KBWToFcBgHG6HjVcYkKYXYwxvfRC5dMmoGTbtVZavLIsP/iK7siRvQANaUFFuPhhtlGe/cI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710532642; c=relaxed/simple; bh=nsHNKBA27Fo68+0wGJwmDPzLy6pDcLGDVoy1Wrw73cs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=clIwhpbkhwBZixyUGi9Z4gb2rXJ+dgDI3j0IELzVi+mIJ/n997PIEVi3zSfBa70iqEUEOtzQ/cUb/BRA3PB0K4xR27tivXx/OTXaFKk/PyhJQGnFtuaZYIU7rXjaCdFsk7V/ok48uwXw4CQ3O5F4cqWv+PzHN/Ja6X21jdYTS2o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42FIb90k014457; Fri, 15 Mar 2024 19:57:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=/eULud3ynYWw+gXnIb2EuNkcPvTBQAWM6LmcxUOaEfo=; b=c9wsJKpknxnqY2NlkeK9HG9OspCy+SuI4VRdkOm119eAoApyuCDrIZ99goy6fDOugvKr mC3JKkWrZtkyruQV8vFGoeYpWr1VUptJ7U29c7VxUSzU9NMP/Rn9DFwXZ8bJNu6jl8wS Jo29dwg0mFCkw8hqLZ0z/lpFBs2Wiu68T1SNmL1uTZfHrNrR7FdXAXs6GZpoQdTQjrqZ OuFhGgNRfLCW1uJ7prZ4VgFeqrRHRZrimQTQAids5yMdm9WJ53NAluIcbiCumzpafbMH nknJBOvhmsATOK821FAOBSEGuhVBL5iIKIytlm7yuwW8We5hGZzNxKBKel84PZy+FFoZ aw== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wvus18s65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Mar 2024 19:57:19 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42FJMoi9026843; Fri, 15 Mar 2024 19:57:18 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wvsydh276-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Mar 2024 19:57:18 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42FJvEwx21299638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Mar 2024 19:57:17 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8CE358055; Fri, 15 Mar 2024 19:57:14 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BE4A58065; Fri, 15 Mar 2024 19:57:14 +0000 (GMT) Received: from [9.61.153.201] (unknown [9.61.153.201]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 15 Mar 2024 19:57:14 +0000 (GMT) Message-ID: <9e42c217-97ec-4e8f-93dd-17c432934697@linux.ibm.com> Date: Fri, 15 Mar 2024 14:57:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc: Remove power8 strcasestr optimization Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20240305201348.2470552-1-adhemerval.zanella@linaro.org> From: Peter Bergner In-Reply-To: <20240305201348.2470552-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: OZhH-k2iWH7DpYcSRW33gWMMWDhCwp4w X-Proofpoint-GUID: OZhH-k2iWH7DpYcSRW33gWMMWDhCwp4w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-15_06,2024-03-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403140000 definitions=main-2403150159 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TVD_SUBJ_WIPE_DEBT,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I'm sorry I haven't replied earlier, but I just got back from vacation. I also see you've pushed this already. That said... As with the power7 patch, I'm all for cleanups, especially if they simplify things, remove more code than they add, and make things faster. On 3/5/24 2:13 PM, Adhemerval Zanella wrote: > Similar to strstr (1e9a550ba4), power8 strcasestr does not show much > improvement compared to the generic implementation. The geomean > on bench-strcasestr shows: > > __strcasestr_power8 __strcasestr_ppc > power10 1159 1120 > power9 1640 1469 > power8 1787 1904 The generic implementation being the one in string/strcasestr.c, correct? Then how do I read the performance numbers above? When Raji first added the power8 optimized routine, it was showing big speedups. I see that was before Wilco's changes to the generic routine. Do you think that was the main reason why the generic implementation is better now? Even though it's already pushed... LGTM. Reviewed-by: Peter Bergner Peter