From: Stefan Liebler <stli@linux.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: Fix ifunc-impl-list.c build for s390
Date: Fri, 17 Feb 2023 14:46:14 +0100 [thread overview]
Message-ID: <9e8a1491-e778-674c-5d4f-71f473e2aa53@linux.ibm.com> (raw)
In-Reply-To: <4e5aeda7-899e-5bc6-b2d-c9e2359f4e3@codesourcery.com>
On 16.02.23 22:39, Joseph Myers wrote:
> Builds for s390 recently started failing with:
>
> ../sysdeps/s390/multiarch/ifunc-impl-list.c: In function '__libc_ifunc_impl_list':
> ../sysdeps/s390/multiarch/ifunc-impl-list.c:83:21: error: unused variable 'dl_hwcap' [-Werror=unused-variable]
> 83 | unsigned long int dl_hwcap = features->hwcap;
> | ^~~~~~~~
>
> https://sourceware.org/pipermail/libc-testresults/2023q1/010855.html
>
> Add __attribute__ ((unused)) as already done for another variable
> there.
>
> Tested with build-many-glibcs.py (compilers and glibcs) for
> s390x-linux-gnu and s390-linux-gnu.
>
Thanks Joseph for catching it. In case of building with latest -march
argument, I've removed the last user with my recent commit:
"S390: Influence hwcaps/stfle via GLIBC_TUNABLES."
https://sourceware.org/git/?p=glibc.git;a=commit;h=41f67ccbe92b4fd09e1062b383e55e407ae5bfa1
Reviewed-by: Stefan Liebler <stli@linux.ibm.com>
> Note: s390x-linux-gnu-O3 started failing with a different error
> earlier; that problem may still need to be fixed after this fix is in.
>
> https://sourceware.org/pipermail/libc-testresults/2023q1/010829.html
>
I will have a look. Independently I've recognized a fail on x86_64/s390x
with -O3 starting with commit 32c7acd46401530fdbd4e98508c9baaa705f8b53
"Replace rawmemchr (s, '\0') with strchr":
In function ‘nis_local_host’,
inlined from ‘nis_local_host’ at nis_local_names.c:147:1:
nis_local_names.c:171:11: error: ‘strncpy’ output may be truncated
copying between 0 and 1023 bytes from a string of length 1024
[-Werror=stringop-truncation]
171 | strncpy (cp, nis_local_directory (), NIS_MAXNAMELEN -
len -1);
But so far I had no further time to look into it.
> diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
> index 1532258af2..faa428f9ab 100644
> --- a/sysdeps/s390/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
> @@ -80,7 +80,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
>
> /* Get hardware information. */
> const struct cpu_features *features = &GLRO(dl_s390_cpu_features);
> - unsigned long int dl_hwcap = features->hwcap;
> + unsigned long int dl_hwcap __attribute__ ((unused)) = features->hwcap;
> const unsigned long long * __attribute__((unused)) stfle_bits
> = features->stfle_bits;
>
>
next prev parent reply other threads:[~2023-02-17 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 21:39 Joseph Myers
2023-02-17 13:46 ` Stefan Liebler [this message]
2023-02-28 12:44 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e8a1491-e778-674c-5d4f-71f473e2aa53@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).