From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by sourceware.org (Postfix) with ESMTPS id 5D3A23858CDB for ; Thu, 20 Jul 2023 11:06:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D3A23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-56598263d1dso512114eaf.0 for ; Thu, 20 Jul 2023 04:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689851184; x=1690455984; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gKBeVwLIgxAQ9BeKohqYH3jsO5Gxr+7PWZjRYYnSQP8=; b=byeq3FAx347KjahoXZCta/Va/jcbpTm81pBrqsQRAgwRmkeurkkVLhIEY0iEBuzGp7 WraLQMrKsEwYCAM+NLEvJmWhYTxBRAw5QYix5ucQEHpCL7UUxADvokMjB1qTUMe3Rij2 ywr+tXeWJjuls8lLj+2l6EsUuhlXrDJeWdS8wBL4jaQj8gEyJkvA3genVPjHvZN8GFYH 2p8U6FBhMTCrKqI0ZHlf0EqlRW3Pgwkae/z2wQJLah/oVSQxAVEKnh90dpC3GRlnU4SQ Bv00JvOFwyHvEBB8P0eZYJJEEKA2bgUM6yq5lcubQ8mu1570uxRw3bypJKloWJ8jlCIH llAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689851184; x=1690455984; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gKBeVwLIgxAQ9BeKohqYH3jsO5Gxr+7PWZjRYYnSQP8=; b=Nn4766c11K9klCBDBFwwUj6BuuKo0hiPh72Twl2xJfrOZji5Sk+ncz0m77/hy8guIx 0a3+YGCmIvEHhSyjmu22Ey1chIcdj1GKe1o/1HGVX6k1GWauZ2t+Ygtx/r6lBSYH/PtB hF96EA0UbgpJl6JN5okydIf/RR1cKbSiBBQ0YNh6FQVVch7uRUBITB1kSCoFvV6cuO3E LOogxu3ARqkQ+O9Ia5qjAR6tkvKLxieqrhuj1gCUubIjhXOvLs0XPLwZyWCVOuEcJcuc ZmZRp2c0sRSLSExN507NmIRKF59kQAlEVmL8mFuIYAAYlV5MDBCK/sx0jGDqhOXoyMNj F3nA== X-Gm-Message-State: ABy/qLb4bU2VcUuGjBLWFDwvTVNriU/dsYhWxXVyOE/bVMrmpENOkGqB mci+DzI6kk1Drhk3ZvAR96vOkw== X-Google-Smtp-Source: APBJJlGxvUJWy4Fc3Z9wbHVcKEB26Y4v0C2onekTSjTgYS/NhlTv0f+uNyJ6pth9dAmVLn8EnAahuA== X-Received: by 2002:a54:4390:0:b0:3a1:d3f0:32ed with SMTP id u16-20020a544390000000b003a1d3f032edmr1262457oiv.23.1689851184224; Thu, 20 Jul 2023 04:06:24 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:d4d2:214b:b6d7:d18d:b186? ([2804:1b3:a7c0:d4d2:214b:b6d7:d18d:b186]) by smtp.gmail.com with ESMTPSA id n129-20020acabd87000000b003a563be2cb1sm25134oif.26.2023.07.20.04.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 04:05:27 -0700 (PDT) Message-ID: <9f478c1e-b0a2-4c25-19d5-b26a05ded833@linaro.org> Date: Thu, 20 Jul 2023 08:05:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Test suite failures with GCC 11 in header checks Content-Language: en-US To: Frederic Berat , Florian Weimer Cc: libc-alpha@sourceware.org, Carlos O'Donell , Siddhesh Poyarekar References: <87lefbovtz.fsf@oldenburg.str.redhat.com> <87a5vrorwc.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/07/23 06:37, Frederic Berat wrote: > > > On Thu, Jul 20, 2023 at 11:26 AM Florian Weimer > wrote: > > * Florian Weimer: > > > The test suite currently runs header checks with -D_FORTIFY_SOURCE=3 > > even if the compiler does not support it (such as GCC 11), leading to > > failures. > > > > Has this already been discussed?  Should be resolved before the release? > > It's a regression introduced yesterday: > > commit 30379efad117b85cc56a255cac628d0ad745bfe3 > Author: Adhemerval Zanella > > Date:   Wed Jul 19 11:37:01 2023 -0300 > >     scripts: Add fortify checks on installed headers > >     The _FORTIFY_SOURCE is used as default by some system compilers, >     and there is no way to check if some fortify extension does not >     trigger any conformance issue. > >     Checked on x86_64-linux-gnu. > >     Reviewed-by: Carlos O'Donell > > > > Some suggestions for the fix, instead of reverting that: > One can probably make use of the variables created by configure to define the maximum level to be tested. > There is "enable_fortify_source" that should hold the level used to configure glibc, assuming configure is run using GCC11, then this variable will be set to 2. > As of now, this variable isn't used outside of the configure script, but it could be (either by substituting the values in the script or by passing it as an argument through the makefile). I will check this today, another option would to just use maximum level of '2' for now.