From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by sourceware.org (Postfix) with ESMTPS id 6F1EC3858D28 for ; Wed, 6 Jul 2022 20:14:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F1EC3858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Jg3OYHcwRpzel22xlghQ617PFldNQgpHH8ynHq3B2l6XimFfleHueeWzdZuyVcAXpCy/P+H8h9bkG5npqLr6/Tg4NxNH98wIyFvx659OuIybol6fM8ckX3xP6/7W6cDYzlHYVHmlJYYkDfDFJJZioJ3aKSmHxCH1p2wOhsFeqKERiXoOZZR0PCo730ZQv+WwnSBanMdOJMxWite7wwI4mfAKXTvZJVIyO3Dx2uVED2Pfl9pjIeNpkc9/h06vHLtiqACUZitkMzkvamfI/yWIOVSpGe6HnnyYAUB71oAr80AOYfTu0Of4HjE7gKubD8qBXDKm7yGXH1jWvw7d65VyZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3cEGwhXmsAXIlgP/uqLJ5cdKDEmCv12V6O7op6VjgA=; b=T4aJggg4KLag1jYY5VervpbqSvaEXI6R189k7nNVwf4ZAi8mC6f0RAIBPJIXDTsTz41XOsq0Ypu+6fr2Y0MXHWPxoHCYwmhGOlFqRjqnQ2v4ryc7Sh+TtNcEDZ80u1OKTMwSihJP560WMu5t7BruuntQZgcIegxilSFdqzixY4jndE3y8keVDz8ruDmsl/pFekMQCKrFYUvHXStTHn1/Z9xv9yli8hknxec++LV9oTBgNAqWz6lx1EZ8ov0ICQR1Sbb8hF6iEOmUJhva8GCXPdPI763ZXGmHnHw5bTR5fe/1JWfG3QstGaoWCY8MBW+oc7O10QifPuGhXD+94lCs+g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0356.eurprd06.prod.outlook.com (2603:10a6:20b:466::23) by VI1PR08MB3488.eurprd08.prod.outlook.com (2603:10a6:803:7d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 6 Jul 2022 20:14:24 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::22) by AS9PR06CA0356.outlook.office365.com (2603:10a6:20b:466::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 20:14:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 20:14:23 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 20:14:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ecdb9f0d2787a978 X-CR-MTA-TID: 64aa7808 Received: from a3dcb8683f01.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0E4BAD82-3F52-4148-9577-5B88CDB6FF52.1; Wed, 06 Jul 2022 20:14:16 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3dcb8683f01.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 20:14:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIWrRIhDX2NCxnkN2bVDoqiVJrhLvjhphGHD1zkLZdYgix0AirXPsPSuxyUbloL2dcEZvMkveVsA2mixcneVFKooqn/39uvuuKZfzkQhz6NEgKXjSUxCLQWs1OcJeon5sirq3kiy+eFGkt5TY0gNky16ofL7AUSRE68EDo2nbiGwfOzUsiRK2XomfKowCqZp2mUQjJnB0QyOgIZAr22BxKCer+PunCFlUY6srK+dtrPHGKa9MFSNvB4mDHrC9MJrt6vo6gRCmra7imQcWId+EbS6iv8faEaArYnR5aTE+bnQt8/bbn7jVQpfdQlh1t9/Xgtjvn9+xZc9rXdbhZyWiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3cEGwhXmsAXIlgP/uqLJ5cdKDEmCv12V6O7op6VjgA=; b=N75TEIzYf44rgsWm9grpSZkjqREYqbtpAQbl4G2FEV5qxZirPagaseHEV4nd5e7otOqc907REwwrw+Y6R1q+IC+FjP/0sVHljdSgg1MQwh6JlV2AaetiJ0FY6QHGwOs8qHAQEokyrHIywzCgHog4uobc9zxUd2InASVLjkKuiCR1j2yXAXgUPF1JCA9qqyzC9Ee8EIigoGhqYXJ6tujszSTdZtAAxABHcSr0HAEamyeWZ4HiKjGNCRwOSO7vD3sTc59qvJGKi6IsAnNIln4+RehC+v9REM/8tQyp1z9xM9oZRbAkg+Zql5y/Gu1AkvG9HZQFO/3mqQCuESKXrWafZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com (2603:10a6:203:3c::14) by VI1PR08MB4399.eurprd08.prod.outlook.com (2603:10a6:803:fa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 20:14:14 +0000 Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581]) by AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 20:14:14 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Topic: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Index: AQHYkUrot9wGWG5wTUWQh2iJcYWu/K1xhEEAgAAktgCAAAJyx4AAC0YAgAACwLiAAAegAIAAAVoAgAAApNM= Date: Wed, 6 Jul 2022 20:14:13 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0c6456d1-1020-48d1-7aab-08da5f8c1e93 x-ms-traffictypediagnostic: VI1PR08MB4399:EE_|AM5EUR03FT055:EE_|VI1PR08MB3488:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RP+l+HaO+XZ/YPdln7OpilGMHoVS7SfBPEx9UI0bj3fTLGL43fH1X8OyEBOGKi23B2ZfSLwWIzYcK6SROS4S3zHFij7JbYQFOK8m9hFzTD2JclNxCG4ePd7aGvowGmvo2X53G3Uj4I/jLMf3+PjZsvs2EKo+62g9/nHvafabxz9chNRXT6xx4BWiY+67G2n+TW6hfO3jLsQyaRQNX12CczRAyFDJmzEsowkA1Hehvsi62V1Q9gJnGqXbozkq+ad6appMCZV/dwubFDjqUCpVkbWDURWbt4Ia5sGtPmH3rnXANz7Y5O7c4b6xLmxfU/3E2Ku9WhYzKh//FCkgq2lJxRxpLnBP7Ep6kfFBjdOxFUbS0JQKP4/ug3ol9gG0c2U3/5CY+vN7Gry+eWcvgLsbb+XLSMgRLR9XFJHu8O6ArFdjdDnpXyNGoTlbkcpzRL3o1GsbT7dRmzlK11IZ+DQujAzU2hwao2u1Qq0bqfIWfwUMaMLpBXoIK9XWIx6xg0cGefFWpy2r3NWSOU7AJwUUS+eXNIsSXihWiJKCRLkHiXjaEvtjDxRQCzXku1MZtApFxbKD9gsmiJMd+lPhWsNgqw44bjAtAx44z//XYxWZ/RvMgC/8bZFvuJJoroxsyVL8S61hoLM2M/GHTHxr/rKSCpZ06Yu9YDqYIZh6+Qv1oo+IgFhwq3EgoisYMl+q2pfZAYEHej7Ur9fdOnn41SenoH8cC2tUWbMBolR8QuankW/gmJwh64YqsFX9p+E+z9ZfU48G57LseabT2r7AY5oi9M7T3oGezH+1wO5Q3FNR1bxbeSxcj0gBdJEtnn5tq/G1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0801MB1668.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(2906002)(66446008)(4326008)(33656002)(66946007)(64756008)(71200400001)(52536014)(4744005)(66556008)(76116006)(8676002)(66476007)(41300700001)(55016003)(86362001)(8936002)(91956017)(26005)(5660300002)(9686003)(7696005)(38070700005)(478600001)(122000001)(186003)(38100700002)(6916009)(316002)(6506007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4399 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e646b218-ff62-4dbe-4fc1-08da5f8c18ab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j0oZ6zs4sWvokSnjKWthn9gjgKBa4aOin6N6TwaXyljNtc7qWdX9tbnUahDn3wVsbprU4PESWrF8LVgcWD7H0eV+IdipW6/7DRQF4SOlIeF3aVuIEvaYKlw74CaDZ706Zlu+/SIP7fg6i3OcC00/JMDlHGwCE16LLPcDaZoJKeb5Eic2UC+NWaByqhq4GaiyaDZQyg9yrq0gFawFoZLW/MTkdIbGpYDP7E3jmxpEm1mkc18sqw5KpHuoGmF+KC8YFVgR4PD1Yi2JnbBZgTNWitPIhzOIqtVuFjuFeWZTiG7+F+xht03IWI1D+hG6qmVJm988/nzCXiiwgY5PKd90X+1pKyvJSV+T+hWYmF/Ob6htqwniobrMx/sMhjX7K+ZvA4Xuu9dZcNdO+UvAKz8o7sfVj03cqNpGQMnaddCwqOi8O+Ylu2vtRQllgxZKWdpySS6YUB+J6HvupP+01xAEDO6c/NIEU1iP2jyt42Se1Fbu3RJbskXkGaat4eQtC1jkEwshKaV2+zXp7yzaCKQMI+zq8qs+n0t8XgO1xcNV4gdieo82k8ZRB7ROht+NZCZjmZiju3fMaqp/TCG2f22ih6wmsCsby2HTDJbdfJ9d7YsGJECbkLiY2kQRQf0Yj6KqpQCv8ak4L0abQcV8bUuM9U0dWxF5F8wAp/fDxI9oSnI9NKODpDxu9nZH2aZMn2KP2sLFeoH4CDDRQWg0HBCnfQOlDtXBiuP9PaM9sqYwj18fVIjnPBXtcfx7Ow7wi4Bb6+R1nXKjNJjeFbpylzDfPQT6P494/tdV1odMot4NWMZgPIpKtIxV9uEwz+m8wr33 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(39860400002)(396003)(346002)(40470700004)(36840700001)(46966006)(6862004)(8936002)(26005)(9686003)(70206006)(70586007)(4326008)(478600001)(8676002)(40460700003)(86362001)(5660300002)(33656002)(186003)(52536014)(6506007)(316002)(41300700001)(7696005)(40480700001)(55016003)(4744005)(2906002)(36860700001)(336012)(47076005)(82740400003)(81166007)(356005)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 20:14:23.8763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c6456d1-1020-48d1-7aab-08da5f8c1e93 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3488 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 20:14:30 -0000 Hi Noah,=0A= =0A= The goal here is to move to the standard atomics, not to invent our own set= for=0A= convenience or just for fun to be different etc. There were 2 uses of atomi= c_bit_set=0A= in all of GLIBC, and I cannot believe that=A0atomic_fetch_or (&x, 1 << bit)= could cause=0A= any confusion given that it is very similar to x |=3D 1 << bit. We don't wr= ap such=0A= expressions in macros like bitset (x, bit) either - it just doesn't make se= nse.=0A= =0A= As I mentioned, I'll use EXITING_BITMASK rather than 1 << EXITING_BIT.=0A= =0A= Cheers,=0A= Wilco=0A=