From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by sourceware.org (Postfix) with ESMTPS id 536893858D28 for ; Wed, 6 Jul 2022 19:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 536893858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VguVc8AcJI5l3M2vk7V0D1ylhYWGT28RE/rYvh6Qmda/Koi6GMXnW4svk2Xq05a6kY5GtVg9SWzNpPtWJNlWeQtCHqwECTrkFtI5b/9GGa9Rzm5eAbUCzSvInaNbbcie+N4G6PXhwFdfpSfRjmYwY7aEVHbAoK0SioiokK5tQqwmN+d/pjbAaAxjuWIyYrIxO1Fz2u/AoAJXRktJyQZO1zvtLu4ukSOZzOPdSSMl2ax9fAP2GVk9EO2Rj2vdRX7XIKM+Cm2HpZL1hCfReQCvo4sQVeRCW6tLsy6xTSBFoWBX4296u3Jyx2hRJc1ZuvFQDcOuaHgfDnRrXli/7t0cEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R+FsLC15SdjV1Z7HzsbRXGHJC9ymUV4V5vk9e5mGmMU=; b=eRrMFLZMJg+8iLmTMOuq32fD6/xmR1crj2NQusVf8CvSuqdM5jpt83e/SZY4kHNrPBHH89LlopOZt+qT0T8uJgod9G4RAck43HfMp+tenv/LxvyBhUfswoo3I/Au798DkGHMKiOpoD2zPQdUr53onE9txvi7wkXWDCSxlNTpbE+NlOLtxEqQpw2O7Y/f/tX1kmzWV9KtQCon7NIWNoKsEaYQoP+Am8+sPA/3LgvDLsu38swT4dGyNcAdHFSshPj9nhbwNikrlIPLrhNqrdSDSBsDrxnyUYKYvBS1q4lQLV/gUQcP+XcMkpyMyl1doZ6I3QH1pf4p/92qzlyZJJH+dg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB9PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:1d9::22) by DB9PR08MB7675.eurprd08.prod.outlook.com (2603:10a6:10:37e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 19:00:09 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::50) by DB9PR02CA0017.outlook.office365.com (2603:10a6:10:1d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Wed, 6 Jul 2022 19:00:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 19:00:08 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 06 Jul 2022 19:00:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e63b5475c2af06f0 X-CR-MTA-TID: 64aa7808 Received: from a9aab0655684.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C8CE3F61-E747-4181-9D09-FB49EFA28030.1; Wed, 06 Jul 2022 19:00:02 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a9aab0655684.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 19:00:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKyN9fGYuFY26jw482bnuCefxeUH5bgwBOSNUe9g1MDDYXX7dBIgK2PEQ1fD8SxbHHzCzmnp3w+2+CpfHW5U1fZex/6TqMbtUTmRJ1LdLk7gI7RgupACxqI5RFvinf3ohvNnKOzYSXJf5mF/IynrLvimMw1fYj/4nNsngSeBg8AiAyAZKPhcNbj/gLEZK0Kw5FU7er7NQP7vkJgbtSkjMQ8r/CFui2Uv5Cw5vyP20yN33LARTAO7aNaROmBeKl37Eh0IlLV+ZrWGEtrAJDs2poaPugo93IaV86r9W0Z5Bcym7FFN0shTQKTrdt53Qbs+7W6rLV/tqElyKUWzq0kF4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R+FsLC15SdjV1Z7HzsbRXGHJC9ymUV4V5vk9e5mGmMU=; b=WLBZSEm5FtgfFXjvPsOZYZTwl5h5zg040tTDHRRGL7przw0naPT8u+UYv3sQ2SjWoyvTCv//kQeCBH45HeuFnZfFWzZE3pUvt+71F4M8Yhq4Dx3wBjnJAt1prZwCSBdXzCOUsEnC/fpwsSJ6ou2Bqdhgrv4Wx4IeKPW6bGMc83xTlSXXklElH7sN2K1117L9O7e0Fiw0jZeFBkXBz2c/cYElusTjJsJ9cCrrJUFyBIeFQKnReg1h5t1Y+tpzmI10fWmg7PGV2SCiymnhyyM2G4RxF9qFEpNJOPshDXQEgkrTuFIXHbKyksTiANisWxeGL7qwlsDOE042VCX8c3OXrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com (2603:10a6:203:3c::14) by AM6PR08MB4723.eurprd08.prod.outlook.com (2603:10a6:20b:c8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Wed, 6 Jul 2022 18:59:57 +0000 Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581]) by AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 18:59:57 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Topic: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Index: AQHYkUrot9wGWG5wTUWQh2iJcYWu/K1xhEEAgAAktgCAAAJyxw== Date: Wed, 6 Jul 2022 18:59:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9e9c8e35-0153-4418-5ab5-08da5f81bf34 x-ms-traffictypediagnostic: AM6PR08MB4723:EE_|DBAEUR03FT028:EE_|DB9PR08MB7675:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: W+ubswzftZdgpzbmXX52rHu+zKPj0WjgT1eUUDz1qIoW+M3vkJSCsWEuGJ9OVgLLo9i3EK6jZ1wK5XPjEJtkYVG2pakpgEC5CNjXnt4veYOJoo8HY2AuJspP7J8X6ZCcsac82JBFLANE7+W0N7b0lEW8mzMR/N6lfAQ/+4mdS47eACrEIBjVOgn5NJPmLMiBAvYemw9aF8jhdnmj2+pDBa8t6oNmX8AlP+/jd4svDUzCu+nRjFjV49hGPAVWtxOIFVP9c2Y975nc0ZFHFW4oTX1Y/fwwidB6+mtP2w048GMDOgdHmPv9pC5aUAXIXXOhOuCeK4PqnaLDbJsMGVa62vkzI74fsol+uOn9ImjWz14omV+WVPUxwcW4SE8CcnKVudH/M33ZuCp4XicNs7H965SsQYjHZMVC/iT+j/uSg7kNhedbFKKA3frT1DAPu2WcXTdGZVldt/5Apjoyr3IyZfaDYisM3eQD1jOUkFy5BhSy+IVPoXAX6LTmcdzk8MH/DwDmYZW36CxlkFOK4Yd5Iq6iMo/IuHKNq7ChQPIx3Q2hRBZf7dt63VoebCobwGQQtK+T3eA+GPi/+5gsw0VbtS1vMoNMChCHw6mLRJ1QQvMRzTiXdSlgtmQa2q0LkIXlspWGIr2ea3Pi8a4aZa3PsHH7PpTvfcGjx5bLKcR81JsKWx/3gMrYUxg1cydl5TS1OkITzzSxZ4plGIrRD1osW14hlQD2Z8WVoA5eWij8b4W+GJbs8mPaqQU6yiSZ7BocPfuAnqRBSnnDfi2AhIuC+rMoQaZQpU8mmLXR0Dt19Uw9qfJKGtVh7/ojCGD0A+7p X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0801MB1668.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(76116006)(66556008)(66476007)(66946007)(91956017)(41300700001)(66446008)(8676002)(33656002)(6506007)(38070700005)(38100700002)(4326008)(64756008)(122000001)(7696005)(52536014)(86362001)(186003)(71200400001)(5660300002)(4744005)(8936002)(2906002)(316002)(9686003)(478600001)(55016003)(26005)(6916009); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4723 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 82adfb75-6609-42a9-5acd-08da5f81b88b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EfUUHd4lc5h3201IhXp+k2n2IaiDPjz3cFUZIQ7yYFXL6ayPGjQY7SRk99DYk1JbJzlEW5RfBJ4RJPJF1GoKb2IKY6PFN/oRKdG/oxzyJdfNycmSQUpL2MnKy0b+Gww9tLxXOsxDhB031cJWkaZXzlqz4lP5ZRkTnVYs3qJwJJCLxaHxs2kyTJzRIwTOmXRY4It5nIWMhxfh0kcxGWHfyqA00RFR+8xIEJ8DT+9nj0kOnWhb3ZmCf3GrGRilUpP7A1cOTUptLO37A9vM9CHUYHs5aGTzkMrk5hp87xvTgNHWG5JUi6HTYxPuhBsIsfSCl2Mr2t95EU+oG2rvEW3u/TpSRLbqUOIZr8IxTpsgfEksU72HDTl6WzdUB3NW37gu3vlmZt2+ssZYqccuooBELA0NgE+laWk293umpqYiRo0WXQ5H4C/4GGYTbugricqBNWTnXMqtredwX6l5DvSWew974FW3jeGlf3+tcW1ZwokO4au3KkPLmMn2XMBDSeMKrGUfxhiZPSqkzq+ij+7//LoO9FMmZdRSsqsRT3EjVVeECES/6IFLr1a8tH/jy7SxAb9BWxkpVXazZ/vfpFuf0jcDBARLGSGl0vwo1EnbwTSHJKqvqzz5Ry18oOxkozuuFwh6f62bmcDigaE23j7Sshme44uEmy5rNRijMlIpWQyWXchw5A2izl5FB8Jqy0bmW1WlGsrjyuXXfi/co6JiAwKoOnpv7aHloocaFw4OamFqKlaDtfew4qpfhKtySvCY2zLXDRpanfGjeay2K+CT5veM5Fz9sHbDIt03DrXbj9B3Ly9w7zHzRsqlCyIOSOZ8 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(36840700001)(46966006)(40470700004)(26005)(336012)(8676002)(4326008)(186003)(33656002)(6862004)(70586007)(70206006)(86362001)(478600001)(52536014)(47076005)(40460700003)(4744005)(82740400003)(5660300002)(8936002)(81166007)(356005)(9686003)(82310400005)(36860700001)(41300700001)(2906002)(55016003)(40480700001)(6506007)(7696005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 19:00:08.9489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e9c8e35-0153-4418-5ab5-08da5f81bf34 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7675 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 19:00:14 -0000 Hi Noah,=0A= =0A= > > -=A0 if (atomic_bit_test_set (&pd->cancelhandling, TERMINATED_BIT) =3D= =3D 0)=0A= > > +=A0 if ((atomic_fetch_or_acquire (&pd->cancelhandling, 1 << TERMINATED= _BIT)=0A= > > +=A0=A0=A0=A0=A0 & (1 << TERMINATED_BIT)) =3D=3D 0)=0A= =0A= > Can these remain macros that setup the bit_test_set properly but=0A= > use compiler intrinsics?=0A= =0A= The fetch_or above is already written in a way that allows GCC to recognize= it=0A= (it's identical to your do_atomic_or0), so I don't see any issue here. Howe= ver=0A= there is a TERMINATED_BITMASK which might make it more readable.=0A= =0A= Cheers,=0A= Wilco=