From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by sourceware.org (Postfix) with ESMTPS id D32F03858D28 for ; Wed, 6 Jul 2022 19:37:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D32F03858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Vp65YlpupxgUtK5PP1NkKPjC6YeYBzHou9J4EROkdeZKEaPIEqn9hTCrEKKq/aJEyYgQc/WjhqSKcAmCi6nzmVEHvAgn10eLmRNwhQ6dxjfR3hocq2rzlcwjwqG3YLxF8nGx2HqhO31YXmMJRfOrTLCf0O8wxJrP1PxqlTjD0eF7xi/xEweHRiGJwTrs1EIV9GL50Be/Yd1pecLTmKKAll03LrBrFPp+YMvyttZznhKsktVPaw5K2ktpJ3VdRar0/J56bfe4ObMhzM209ti/doJkFL9+Vrq4SGxqoAkJgUDHDPoKAMDXPxb8BpJqkZDtHJOo6po2nNF/74kJWEPg2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OSvxlsC5RPAjIrzaUnC76SMB+vxoR1A6w1Jq0WOHY8s=; b=lacxQ6bqCLWqPpykxMY1eo4PTCEXEKp6/nno5lMbbgFfv9OvaCoiUL5ZmGqZ9b9XYbs+No8hGGdOaJUi7UdiTQKJnhWvC9QSPpqm61FUYUbsBZXg2tGh1hbLLgFCknkSybJAHdVJlKzILJrBEbmrcHiaT8jvms08eJZzZiDKjwkmJO6Iz4BL8qBe0dmmmytCdO+V+ryp5FgfkqvKXtSWxYpwnHSv68cZwbcablxsnLEgc89y4xIkYhXZqEbcHG+DBYlUZ6iVPI90LKdYk7ZTFga22Z1P8aoY8vSNYsFILvuv0ZlTngAksyhEOoV9tC5Ev8nFyfHRv5Oi/R6bk+LImA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB7PR05CA0070.eurprd05.prod.outlook.com (2603:10a6:10:2e::47) by DB8PR08MB5481.eurprd08.prod.outlook.com (2603:10a6:10:114::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 19:37:05 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::64) by DB7PR05CA0070.outlook.office365.com (2603:10a6:10:2e::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23 via Frontend Transport; Wed, 6 Jul 2022 19:37:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 19:37:04 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 19:37:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d05ac921cc1ed12d X-CR-MTA-TID: 64aa7808 Received: from 8fb7e37410d2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6F676DA4-6177-48D1-9ED7-866C2AF335A2.1; Wed, 06 Jul 2022 19:36:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8fb7e37410d2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 19:36:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5eTIZz9VpcjFrjZ+AocQNnTBH0oFHTaHrjncDsi0GaehLvQ788l+X9FHE3mefIy5sSt/cZ7oUtPGzl2zoTl+/e7y9V2LsnI2/KpXkyLMEr9Gipl2JFWwF+cLAIcgTImWH0iFmftf2cIZecd6lI3eyMPM/5nPy9EQYCnmhVPQAsqcc46RI6hwgqqbPJf+/Jfr7sI/YKTsnHfqr9aQlI0pySs+mgYkMM9DgW8N/ZLgjPATYgv9eg6RwFf+KgP09LYiWjKIDkxIs8C+Q58Swcoln0AVPtStKG1vB5R7NpMho4so5YNx45c43kUkRkC8QKpbu3x7yVT/V5jPj0ojQ1WDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OSvxlsC5RPAjIrzaUnC76SMB+vxoR1A6w1Jq0WOHY8s=; b=CmVd/XqekrnztPzqKZfspmy4m/08OT/FkoM/2THxzgbep94toyqmFFKihzC2GJFPiSJta35lEl6rHE+5UWgOckWNnylY1Bhs9ODA1iPR4he5/jwKsMUmAFHXOLslQ5P+6x4iFmVxZ8/a4p+JM2yBdAHkZ73Sz7T4xq7tZoQpb20/4M2Ckvq4y8X2vBur1JZO1n4iLC+tZWYpJobhuHakJiuk+du5V1qwcxGc4UvOvgufFuwSdQ01UtpNBZOQyrDRCGOcLLP+KlzmL9Hp4DKolUogwXNJXL1SREjU7K1kCaZ7kE1y5jc4eFOVOPfiqAyROj0bCKEmU52VTsw5jln0uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com (2603:10a6:203:3c::14) by AM4PR0802MB2356.eurprd08.prod.outlook.com (2603:10a6:200:65::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 19:36:56 +0000 Received: from AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581]) by AM5PR0801MB1668.eurprd08.prod.outlook.com ([fe80::845f:5b9c:410a:f581%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 19:36:56 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Topic: [PATCH 3/7] Remove atomic_bit_set/bit_test_set Thread-Index: AQHYkUrot9wGWG5wTUWQh2iJcYWu/K1xhEEAgAAktgCAAAJyx4AAC0YAgAACwLg= Date: Wed, 6 Jul 2022 19:36:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: deac7cfb-5aaf-4c6a-fb8a-08da5f86e80a x-ms-traffictypediagnostic: AM4PR0802MB2356:EE_|DBAEUR03FT060:EE_|DB8PR08MB5481:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zoVD8tPxMnqxdBMAF3iiRoAJ7l6Q1Wjiz97P+KogTtHge3p89I2NWgx0eD7+pIdvA9TBXicsww1fIJF/XFz4PzEGVFb8yYnkoiU7rxHI9hp9lOmlVNUSbYbjA3h9/7OisAw2hOJa+F9R9guB+xAc42QqZOGtnPhgNeKFjDBZpezas9Bq6PF40otZzHZ9koUq5bNHAxMSn/qlUf0V5KhCT3gMJ5pU7yQmDm86VxFS/Hues36jOfQkbM6gQ/WzTmzilHDP0/hofS3si6s6fZH4pTzhH0eDeC5eZPx702lbxRSyHCFQPwLPK9AftR2G63m87LzD6uENBCYO2GFEMb9nFMM6DZB+15Es+QBLEmRnA2lkyCGBL+AfNfY8mYmHOWXFoltAe6zRZaWZJ94/BQsXD1RguHg4m3Ph/4zQYh5kxDbqtyC7ReKQJfy5WPBiPmAxeng/1mH+M+qq7w6ws6vRKRDhz5uBm/ujCQqbFE4eh+KxPkLO5apdbzWDKrDG6tCJ0dkVEJiAv3j10NAFtv6fKbv+zoTH+JwFFAcU8FIZq7Yr8wlZYQnh8NfZaQ72pFg2EYWjwtkCrINsEaO4foc8w56ycaNjsR2jtPmpU18s6LQm47c0PKYy4GlDT5ZtBvPJgAdjpjfQwMz7P8ASXarng1Ed4ygVmNeHPGyF5IFSa4yn467W75osj5PJWPTzQf5q+naHB3EUY5zEMpb7YVJqsQxMtqqUcmr5YFSjCfYKqgWgxDLD9Fycbwjih7JloOaIUI5oS7etuP37De0WSC5DMc6eXe/d0wdirdbSS5LTp2ZoZPS+DEPjovNfINAhgJlA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0801MB1668.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(4326008)(41300700001)(8676002)(38070700005)(38100700002)(186003)(5660300002)(71200400001)(2906002)(6506007)(19627405001)(7696005)(4744005)(26005)(66556008)(66446008)(64756008)(6916009)(316002)(122000001)(8936002)(33656002)(86362001)(76116006)(66946007)(55016003)(52536014)(478600001)(66476007)(91956017)(9686003); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2356 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22c8c944-bd8e-4869-06c0-08da5f86e2da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Sn7t18Kw6e56peT3hQN1XGTv5sRk50eXQ+o0EVhNqXeql91huSd3OC6E3eFmXUETKUUhKfav1tGwHV0FuWQdYvw+I48FkWzs2yhSPL8W/FB3deXL4zYYuZtizyRfQ7+lvyQZ8jrIdLOt04EZTuTzWqQ7soZvg+fTpjR8Ok6dYB339Pmc+AhGJ0Z4AMnfF2Xh0tVbDSxN6yKyuLLWh1KjKDo4Qb/4/E8dUMr8v4LgwsbjS5/e2L/WXxUKISMqu3ybG/bz2rFs+SWXJJbT5avjJuOQuKrXjfARMZf/0k7XKIU6k/F4FzWnkytnGwy1H8GiiL42nMbsr2aB1ubhfbBAnvinaVMhY9eknpCROXo1BzWOCxAPb/FMpDUNcdRpqwdN8R1ihjahVLhtp9dU14f6fT04YXQWBxQqCFeC2fvS7+oQa2+VrzovYIuBnjqpaXALpux3+6YXLIKxUJLWIdh5X21Ej68Ij8sT+BC7LX85lkLytsB2o5LThCVMN3RjFzXklSfNZlQSdfXfdnz0XhhL/Shj80X/ZhVxGr/DHVaDNQYOpPDviaGPJSoEdaIhaJL4sR4b//0p0rZ7eIrMkG5uc4zKHUHj5GHeaysvobc86/tcqbp6WM8/KD0aZym8sTspNhOMVaQ/k7Crtt68Eo3ViOv7I0LW04gE/dU/GlsAiwOBQybta/Ezyg9vOEfiIOqUwi8zo7RTSbcO4SkFvAaTzdQYVvF5UBk+Rk5Po7HBtspmEdhm03RVkAuA1lOtUIGyeG/hIkdTJozBYRxMTMkN22fxQRyX5DeMWwq9GQkF6byc0sPpJyzG1xvqrDf55vp X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(346002)(40470700004)(36840700001)(46966006)(36860700001)(55016003)(19627405001)(5660300002)(86362001)(336012)(40480700001)(8936002)(186003)(356005)(33656002)(81166007)(47076005)(82740400003)(7696005)(82310400005)(478600001)(6862004)(316002)(26005)(9686003)(41300700001)(70586007)(70206006)(2906002)(8676002)(52536014)(4326008)(40460700003)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 19:37:04.9636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: deac7cfb-5aaf-4c6a-fb8a-08da5f86e80a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5481 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, HTML_MESSAGE, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 19:37:09 -0000 Hi Noah, > For non-constant shift values it needs to be like atomic_or4/atomic_or5. > > Since this needs to be set up in a particular way it seems worth it to > keep it as a macro that will do it properly. Fine with replacing the unde= rlying > atomic op with a compiler intrinsic. This was only one use in GLIBC so how does adding a private macro help othe= r software? This idiom doesn't appear common, particularly with a non-constan= t bit, but in principle the compiler could be fixed so that it optimizes do_atomic= _or2/3 as well. Cheers, Wilco