From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "adhemerval.zanella@linaro.org" <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "triegel@redhat.com" <triegel@redhat.com>, nd <nd@arm.com>
Subject: Re: [PATCH 2/2] Move shared pthread definitions to common headers
Date: Thu, 11 May 2017 12:19:00 -0000 [thread overview]
Message-ID: <AM5PR0802MB2610B0A4872A58D7AE8F3CBF83ED0@AM5PR0802MB2610.eurprd08.prod.outlook.com> (raw)
Hi Adhemerval,
This broke ARM builds using new GLIBC:
diff --git a/sysdeps/arm/nptl/bits/pthreadtypes-arch.h b/sysdeps/arm/nptl/bits/pthreadtypes-arch.h
new file mode 100644
index 0000000..8333acb
--- /dev/null
+++ b/sysdeps/arm/nptl/bits/pthreadtypes-arch.h
+struct __pthread_rwlock_arch_t
+{
+ unsigned int __readers;
+ unsigned int __writers;
+ unsigned int __wrphase_futex;
+ unsigned int __writers_futex;
+ unsigned int __pad3;
+ unsigned int __pad4;
+#if __BYTE_ORDER == __BIG_ENDIAN
+ unsigned char __pad1;
+ unsigned char __pad2;
+ unsigned char __shared;
+ /* FLAGS must stay at this position in the structure to maintain
+ binary compatibility. */
+ unsigned char __flags;
+#else
+ /* FLAGS must stay at this position in the structure to maintain
+ binary compatibility. */
+ unsigned char __flags;
+ unsigned char __shared;
+ unsigned char __pad1;
+ unsigned char __pad2;
+#endif
+ int __cur_writer;
+} __data;
This defines a global __data whenever this header is included:
native-glibc-arm-none-linux-gnueabihf/build/src/gcc/gcc/read-md.h:315: multiple definition of `__data'
build/genconstants.o:native-glibc-arm-none-linux-gnueabihf/build/src/gcc/gcc/genconstants.c:40: first defined here
I think HPPA has the same issue:
grep __data sysdeps/*/nptl/bits/pthreadtypes-arch.h
sysdeps/arm/nptl/bits/pthreadtypes-arch.h:} __data;
sysdeps/hppa/nptl/bits/pthreadtypes-arch.h:} __data;
Wilco
next reply other threads:[~2017-05-11 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 12:19 Wilco Dijkstra [this message]
2017-05-11 13:37 ` Adhemerval Zanella
2017-05-11 13:50 ` Adhemerval Zanella
-- strict thread matches above, loose matches on Subject: below --
2017-04-03 15:08 [PATCH 1/2] Consolidate pthreadtype.h placement Adhemerval Zanella
2017-04-03 15:09 ` [PATCH 2/2] Move shared pthread definitions to common headers Adhemerval Zanella
2017-04-10 18:22 ` Adhemerval Zanella
2017-04-18 11:32 ` Torvald Riegel
2017-04-18 13:08 ` Adhemerval Zanella
2017-05-09 15:10 ` Adhemerval Zanella
2017-10-15 13:52 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0802MB2610B0A4872A58D7AE8F3CBF83ED0@AM5PR0802MB2610.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).