public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "munroesj@linux.vnet.ibm.com" <munroesj@linux.vnet.ibm.com>,
	"adhemerval.zanella@linaro.org" <adhemerval.zanella@linaro.org>,
	"pc@us.ibm.com" <pc@us.ibm.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH] powerpc: Add a POWER8-optimized version of powf()
Date: Fri, 02 Jun 2017 16:06:00 -0000	[thread overview]
Message-ID: <AM5PR0802MB2610F743AF2A1DDEAC176B1E83F70@AM5PR0802MB2610.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <0f81b30e-b8c9-60e9-4fa3-3528ad21e0d7@us.ibm.com>

Paul Clarke wrote:
On 05/27/2017 07:55 AM, Wilco Dijkstra wrote:

> I'm not easily able to test and validate performance on other platforms. 
> I'm not sure the maintainers of those other platforms would want me to, anyway.
>
> I do understand the motivation to encourage architecture-agnostic code in lieu of architecture-specific.
>
> How about making it fairly trivial to share the code, by dropping it in a common place,
> like /sysdeps/generic or /sysdeps/wordsize-64 or /sysdeps/ieee754?  Other arches 
> can then easily include it without having to copy it or include it from a foreign arch directory,  when and if they wish.
>
> This seems like an issue that would be commonly encountered.  Are there generally recommended practices?

Not as far as I know. The current math code is a mess due to all the different directories,
the odd wrappers, the headers that can bypass the wrappers and on top of that the ifuncs...
So we will need to simplify all this, starting with removing the wrappers.

>> As it happens Szabolcs wrote a prototype powf that is not only
>> more accurate but also 4x faster, all using generic code. With these gains, target
>> specific math functions will be obsolete...
>
> Is that forthcoming?

Yes - after they are published under a less restrictive license. In GLIBC we'll need to agree
on how to deal with the wrappers and establish a good place to add new math functions.

Wilco

    

  reply	other threads:[~2017-06-02 16:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 12:55 Wilco Dijkstra
2017-05-30 17:03 ` Paul Clarke
2017-06-02 16:06   ` Wilco Dijkstra [this message]
2017-06-02 16:28     ` Joseph Myers
  -- strict thread matches above, loose matches on Subject: below --
2017-05-25 17:47 Paul Clarke
2017-05-26 19:55 ` Adhemerval Zanella
2017-05-27  0:38   ` Steven Munroe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0802MB2610F743AF2A1DDEAC176B1E83F70@AM5PR0802MB2610.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=munroesj@linux.vnet.ibm.com \
    --cc=nd@arm.com \
    --cc=pc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).