From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com [40.107.22.87]) by sourceware.org (Postfix) with ESMTPS id 893A13858C55 for ; Tue, 20 Sep 2022 22:59:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 893A13858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JW/5oE3YSDwPrNx/qGQ5OrD4usTh6m/LTxlpTMOBnLeI9Lc25CMB8aBs+EOg8iP2MEnbEILOs0Xnranbg76g5fgz6+zJUhQLcfOQKFIrdd3d/bJ1cXi4G1UG81VZZzV2LeHjrtEPqJelrPj0jWZY3FhCY8OTm7aGDNWX9Y7ETPL8bUZzquIx+ZofEZ9Bf180CnT9q7XDcWEFRPbIdhMoHW40oQS4ezFqDmlFRInNfv7Nch2wZlk7UfHqsFF4991vxWbFQBON0FzWqhw861z2w7c5fAbBFIP5Hnk5CMa8NQOogTPgl0qZPYVe/9q/qcCK7LL3dX3EZtMqZuKr9yyJMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUICDQrja3/aLM55jASEYrMDsPM3iQ0Qp7Xo+tRQFRQ=; b=kUDJAWiojAM3B0Wt0Ra4ZLEcA6iFDxWcLtnJERLK0gigdB2hCcxdPEuIr/6Ae87lYC9h8laWnQrYl6OrEfmxER5URQBp71kshaFdGaReWYcthYIDlfSLDYQohztHXR+nmcXZDIaDv37DW5q8Vl7E3eFiC2axFqHh2jLmZbKvgxc753DxC2wG78F+7gpsuyslnKnftqz/GNa3dAF7H5lfQkB6pNltGzpq3nqfJW9+t0ThCXvQnzg99cEdgnFKVXEc3tfTqJ4TW/6Np/+codhezBrbTOCZFZvqxZGOT+GBpjX2PwzsM/lsC0koNNKNCB9kh0DzBJCftNzx7yUXqu/0zA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUICDQrja3/aLM55jASEYrMDsPM3iQ0Qp7Xo+tRQFRQ=; b=Gl9jh08mZX9nrYo2jBHVuGzDsbB6S4VCw85rHjomv4Z144RQq44BloCJRALDQAea9VCKsi3rd7K+6Ms812tXuzknKtJrNjp28IyMGD4S9D/HIhD0ByGtTUsl51yhjwramF+xB3ONffQn3uD7o93JbZFNofXTVsSH5J5tuYdrV90= Received: from DB6P195CA0019.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::29) by VI1PR08MB5453.eurprd08.prod.outlook.com (2603:10a6:803:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 22:59:49 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::ed) by DB6P195CA0019.outlook.office365.com (2603:10a6:4:cb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Tue, 20 Sep 2022 22:59:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 22:59:48 +0000 Received: ("Tessian outbound ee41cdb23966:v124"); Tue, 20 Sep 2022 22:59:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1d91a8cef9d23fd0 X-CR-MTA-TID: 64aa7808 Received: from f86fb585e378.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88727055-7381-4913-A38B-6BD57CBBF0D0.1; Tue, 20 Sep 2022 22:59:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f86fb585e378.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 22:59:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwimuN/MesHovE1fC+kaYCIo21ulUEFsRbxu/XXz2u8K5aoq775Vk5W7dRnOks3cbi5Ij6LITEvNF5hv0ugQCuwdQUjuRUB9/byMto/HGSmT883e/ElfmDqAzWYv1cRqY24Q0qttpgpusz1ftI6PIxUJtE3qYajGwFnxOFJvi/mPkAZ2wVOPNO6IO/FWsTA0CwxdS2h9axm2u3CQHwoSrb+lLM1cyh1NsaRwNWp12DONNMz0jP0bQ0BR/PetU/4v9y+7A9kMwfQ5kIKYurB5vlbMCBonOtJHAqIROmbB5l9O77eHeDsAJUK36iy8YLgkCPeCDZgLCOLL8OAYdipoyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUICDQrja3/aLM55jASEYrMDsPM3iQ0Qp7Xo+tRQFRQ=; b=gqUaDkv6zVvpCMi4xnv2Jh674vvthcrQZiUTudVSB6nIyPVybEp6lTGxinYP3nZcMr0eMKxzfzKlRKERjJhcUzBSaBnEjuyRjGiJTTuOQdiPeWA+jWPrbPo03h8a3OAIyb7NVyow3P0yWfHSA5OSIWHs9MC3gS1dzl53VrXsHD6b9/mGsPoJhkzbcGlSivGZfPww1x53kg8zkwuVQ9pJ2ANpP7nUsQesmDLkEMXjpfporOoQD5tnqNnWoEGxtZYShAd/cUKzlRjSVfv4aNYfT9DSffQcD1EplG5eDB+cN5/pnC8tup9lKJnQVdgMMe3V+75l1AZOZFS+DHs5wfFT1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUICDQrja3/aLM55jASEYrMDsPM3iQ0Qp7Xo+tRQFRQ=; b=Gl9jh08mZX9nrYo2jBHVuGzDsbB6S4VCw85rHjomv4Z144RQq44BloCJRALDQAea9VCKsi3rd7K+6Ms812tXuzknKtJrNjp28IyMGD4S9D/HIhD0ByGtTUsl51yhjwramF+xB3ONffQn3uD7o93JbZFNofXTVsSH5J5tuYdrV90= Received: from AS4PR08MB7901.eurprd08.prod.outlook.com (2603:10a6:20b:51c::16) by PAXPR08MB6336.eurprd08.prod.outlook.com (2603:10a6:102:158::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 22:59:40 +0000 Received: from AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1]) by AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1%7]) with mapi id 15.20.5654.016; Tue, 20 Sep 2022 22:59:40 +0000 From: Wilco Dijkstra To: Adhemerval Zanella , "libc-alpha@sourceware.org" Subject: Re: [PATCH v3] elf: Use C11 atomics on _dl_mcount Thread-Topic: [PATCH v3] elf: Use C11 atomics on _dl_mcount Thread-Index: AQHYzSPNVP75fzwUT0StN1s+6sDUF63o7fnN Date: Tue, 20 Sep 2022 22:59:40 +0000 Message-ID: References: <20220920190413.3160597-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220920190413.3160597-1-adhemerval.zanella@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7901:EE_|PAXPR08MB6336:EE_|DBAEUR03FT031:EE_|VI1PR08MB5453:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e08b554-dfa7-4332-9ff6-08da9b5bd196 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3IYcSbi04p304LfJojVO9ljVg1CcU03BDIk2rR7hlcx2yP1xmoGhxLIxuqXd6nG++6ne1dG4o7+8ghOGdX/dQEmtiDcAs9LANJ4dDAy3qRq77gGHFcMf5xDWbnBa7MTedkLUutew72QqfWV7as2BhY7BfeAgHxWSZnNhE+AeRNvXT7HW+DKncUGOeYHebhdpBtNwtTmSx80H+Hf3nlbjWTdUl2rNO0CK//EmE1puO8eo9RKI4c0sOkdnYLIeUayrLuN/mL/q5ziimfqkiWAZnqie4r6gmiWn0HtiZxAggWd6Q3d3l4+fBfQoNegmhzRhh0idGb1qFgY/6zNyWtQkfAPfKcBTTtZVtziQHICsF/oRHNWGbGsBVD+kWQR4RAPIU9QNlO41R1a0BWIIayE54M8KCrCSj9GW7DC/zdoRyI0upTv+Zs3orhtkDzJDuxz2tIfJLplY54aYqaIYQ1evdcIqDdUX7zwpNQoIPtwPuycuwWZNJe4GpsEVyydww/pc+9oDxkDl1PQF35T7DmEmbupZ7ApOtKcj7QnARp2AHoyhV2ZkUkY2vD6DTveDP+wgeSXczLUAcx7Sui2RlIitqGEI62EpiyYFLfXM95MowJkw0tLqyQSr122XEtd904r8VoOz5dS6Wunz3aeBVmLuXHJUKp3lbWJFPsuC3nFDGYxCzLI+2fMhewFgx3TpNDHSxKSxvMmIxR8Kj6BJ9adI9ZioPlPmEEIovSzkDjRv0F6Qc3kZcgk0eIZtwwS+NIItZJJxjlvep1UT2bZk3KTQ1g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7901.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(9686003)(38100700002)(26005)(122000001)(64756008)(55016003)(6506007)(76116006)(8676002)(33656002)(91956017)(4744005)(2906002)(66946007)(66446008)(41300700001)(38070700005)(7696005)(110136005)(8936002)(66556008)(5660300002)(478600001)(71200400001)(186003)(86362001)(66476007)(52536014)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6336 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a47cc20a-9d9e-4cb9-d0cf-08da9b5bccd6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Mz24UXegBscSLpwM1tOBSnPprFtmQTALCvKZFpiM4p3oy/3sIBtlyqa2gZV7+/2gtMYcz22bhO8T8atk8FoLN6NVL5T6cqGLGSMmCNM9xxWl8gTko9Y2qIdF/3YiRoxIpGDqEcQkRlyDk51v6XG4tt/Z+IKNX1AuCCBvlChk2cDfw+8BwWpDS2V98i0HK9G0am1tR5d254sWveKy08OPmeXnxhtVOZwikrCsRS5yGCc/Ie7E+ommuHKflShwgrGY0KtbAU2rqDmhgjs1XVIg8i85SIMW/H0ThQyWZ7VS9aT57xp2RqfVycAjR5vbKuuLSRDv2v/dgabtQUTmU4Pmf7TftRXOh+oCDve3wVFvJV34/UWaHoqRU4A1wwIpVor6A7f7yoDGL54r989S97xHN9iu7Mf0y+ZnFyO2qC2VMkErOftSxKsqsO2dtdoM83Ed2iq2wkvZtmTEv4whWfkaCC9bD/6AIFET3Z4KNMfT6eEFCdmvQlC2RbiToaf/YX/Wgz9c4UdyyrM2vF1iCDVPFqtTkzfFn2Sw0x+StnmY4nFYzqBLbJmFL3mTPEsvMhEEy7kALdPr9ASD2OVhIWu9XGMlnUv4m1TR77aRTe8ezhaK8Lex8P1Xa1/PUQ7Qnns6wiqDa9P2tZKSv7K16khSkBIfPzTb7b9YjhGtQ+8xd6n0VVqwXaFvalqkU5TZ6sWilbtEDPyP/YIcdvN5a18Yq7iNEGH5MbOfuY7ym3r01nRqlXp7a0nhu/qinC8WD0I2uJNyza3qh/7iTdA751e1g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(36860700001)(52536014)(40480700001)(55016003)(81166007)(478600001)(5660300002)(356005)(8936002)(86362001)(4744005)(110136005)(70586007)(82740400003)(40460700003)(33656002)(2906002)(8676002)(316002)(186003)(70206006)(47076005)(6506007)(7696005)(41300700001)(9686003)(336012)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 22:59:48.6985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e08b554-dfa7-4332-9ff6-08da9b5bd196 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5453 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= =0A= @@ -558,14 +558,14 @@ _dl_mcount (ElfW(Addr) frompc, ElfW(Addr) selfpc)=0A= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* If we still have no entry stop searching = and insert.=A0 */=0A= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (*topcindex =3D=3D 0)=0A= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 {=0A= -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 unsigned int newarc =3D catomic_excha= nge_and_add (narcsp, 1);=0A= +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 unsigned int newarc =3D atomic_fetch_= add_relaxed (narcsp, 1) + 1;=0A= =A0=0A= This adds a spurious + 1. Other than that it looks good to me.=0A= =0A= Reviewed-by: Wilco Dijkstra =0A= =0A= Cheers,=0A= Wilco =