From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140044.outbound.protection.outlook.com [40.107.14.44]) by sourceware.org (Postfix) with ESMTPS id 7428F385C32F for ; Thu, 29 Sep 2022 17:53:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7428F385C32F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NtUCwPJ3VACq7JGOG6u1e6XfZVNxKyZKpbVPp0ifcVq27zPRJHuFZBr6zoAPoM7/ZL8zApEPAwBYU42CZys2QOdow1Syz1eRwQ52cCObWPdDUPrpA1Z6qZ5+cLAB9KhaLVs3nML2J1ZcKC+i+gqyDjfyxURzWzkmoGbi0orjMdHPFM+aCDhtAuKB1H8xbKGlm/Qb2rnlnuUwhs5mp2FbuMqPuw4HsBYsghBAj8Il/684zbHzFPuBpkhd9iRY/8IR1ue8xzq0drst5O1SE8tcdh7O4YdVDotCCi77z19T1rsqoX1K6xiUqeeD/QQHCL28csbvuP0V1MaUXsX5qcei2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wmXriWyRNjbtlDodzkNw5y+6VqUfgqGtaTixSgHbL+o=; b=lqI0nhQftWCdDJRzRsGq4h7Ukh8An1l1f4Q2+Kwm4i9R6QbqfT1yboAnRnYK76qHJivWyJNQfjP1oAyPb60rBMn5lT6oiNLf7qxkmjRGS4BcH0I5iUoPslR+Uu9phLva+KwqgPHEttkK8/gu4uobG3+fywsuP1iReel9dONsFKFaYZgnI35+G6TfPHPd7MDlQW1r0Nl8lupEFv80Ab1DJavjWEyq6MqfDby5sYVb23i0KcyyhvsYZ1IPpfKDjRekv3n80NiwqdTuHsxUjm94wINyCDZt2dY7YHtIAR7t5mcYFzNpcahfz2q9CauFsIcXr2fNV0F+4NwioGzkqlGWYQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmXriWyRNjbtlDodzkNw5y+6VqUfgqGtaTixSgHbL+o=; b=hu/wOs9vau3Pu57fLKgPgu0HXxhjUW9/GUxX6DT1lvrSvoLAqhBmWL8Ig6N0RddTzzpcv4MDU/33YN8vphP5+yyY3Nf5mHYrggndJ8xiafF++JMZdId58BIkeTK/maYPeWP4xbWJmhz1VJTZ8i2tARZURpo8ikoRrqcQHgXgjUg= Received: from FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) by PAXPR08MB7382.eurprd08.prod.outlook.com (2603:10a6:102:22d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 17:53:04 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::d) by FR3P281CA0111.outlook.office365.com (2603:10a6:d10:a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 17:53:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 17:53:04 +0000 Received: ("Tessian outbound 99ee3885c6d5:v128"); Thu, 29 Sep 2022 17:53:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 553cb890a22c025e X-CR-MTA-TID: 64aa7808 Received: from 10058ab5fc47.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E176550C-9F38-4D38-934E-94378DBD6313.1; Thu, 29 Sep 2022 17:52:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10058ab5fc47.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 17:52:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DR4VYepe4TQDqUcq0bqaVdPl+dyyCCFm7tVehqe/jX00/7ThIgYpvrV65ix+QJ4734E9Y+x3xjz4qE/UAs3nFy4kumG6B9qdh6MIvy6glwFj3LfJbupOsui0woxQLqPscJVjoiJxSktbm5tTFq3OPrLpL6nTNf+vbpkTqxj5XA+yZWIN68NRSCcU3DR7yOFBIgcK9485MzdKx2w2M84XBEcdw7jEgwPzW+gPlxiY9MTyJDogpgf3ZuJjZEAI3qBspZIIoiB6nw0jDy2CEXRdoC7bjlJ6653M1MVHkE4WK9NVvf60aOFNZJ7HD8pWtWpw7H+25PkNNk7iRbKL+9MrnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wmXriWyRNjbtlDodzkNw5y+6VqUfgqGtaTixSgHbL+o=; b=SGodnjS3TcBBpN3HFFiY+o0nGievxtI6Kq/TB1mam/C3IuDi0HsMcIDxmL6ub0bl2GdmFAu/dCBIGvEL0f4aGLeL26cE+W2NMjeWaVYatN9FwuwKjpT+SQeh+zhshmsF7heohbZscmgpYBBZOsyqmr8dj9mpazBhiTyu6ZZZkB9mOGTrwIYMmiZRTRdRFPoddUqgpqe4SHn5zRHuC5img6r7ZkM/0dmGacuL2jgPMxL3rlsb1vq9PcWU3TOJIA6aeSUnhlBY9rBL28I0jw33o/QRhnziAyNubrRgJwXVPiusEIK3ZByk+k1ZOOEwe7bqF1AAZ5LgfYT0eHaPpfsb6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmXriWyRNjbtlDodzkNw5y+6VqUfgqGtaTixSgHbL+o=; b=hu/wOs9vau3Pu57fLKgPgu0HXxhjUW9/GUxX6DT1lvrSvoLAqhBmWL8Ig6N0RddTzzpcv4MDU/33YN8vphP5+yyY3Nf5mHYrggndJ8xiafF++JMZdId58BIkeTK/maYPeWP4xbWJmhz1VJTZ8i2tARZURpo8ikoRrqcQHgXgjUg= Received: from AS4PR08MB7901.eurprd08.prod.outlook.com (2603:10a6:20b:51c::16) by AM7PR08MB5320.eurprd08.prod.outlook.com (2603:10a6:20b:103::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 17:52:46 +0000 Received: from AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1]) by AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1%8]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 17:52:39 +0000 From: Wilco Dijkstra To: Adhemerval Zanella , "libc-alpha@sourceware.org" , Yu Chien Peter Lin Subject: Re: [PATCH] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624) Thread-Topic: [PATCH] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624) Thread-Index: AQHY1CLek4OXUPFZM0q+aX5oIX7Ysa32rbuT Date: Thu, 29 Sep 2022 17:52:38 +0000 Message-ID: References: <20220929164510.3454281-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220929164510.3454281-1-adhemerval.zanella@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7901:EE_|AM7PR08MB5320:EE_|VE1EUR03FT022:EE_|PAXPR08MB7382:EE_ X-MS-Office365-Filtering-Correlation-Id: 348878ec-0483-4070-311e-08daa2437584 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: me0+Uql65Tcq7+yRPMC+HvXY2r/YIZCJgXUlYUXV2AEUGgpK36XzW73YFn3M7Rh7ItfuubWxCLqE+8a/kJmkV+XfDQGna+c88OswVggS1wPiCtOLWUjkodySdkInhYg0zLfNMDkPFpqWXA54xTrWjMxlc7ex6BqI0cKeSJMBuwGy1ZkxAA85q7sOoxIEdqAUTGdkI+T34LgYhuadC5UI86zavCMfLKp8HzX9UfZenhinKM1ELfFY0Rq326LiiXXS7/zRLy4CMKZ5U9Pwr+eDftkwvUJqaTrPeGH8ybZic1xQTnWs4MhHa+fTeP+xcOAjtlgy6ciVwO7o2by5ibpD192kGrM2oFGfGN3d888zFfQiwyG6pzC79vJJdOC2LjDMbcXIFaFDSnxP5vpo4cxV9dfmLSAV6j6nwRrAbnPefYdowmFyew3K2+zC2A4dItrBcayto3zJQxCw/hq4m6sybSm0yUEQpg4xTS5utSL9SkgHFT7M+JGC1PkAidWT95sUhJ42G+IhKtQN2ObcsVlwUSSl3kCOgdC3ug82QHTYiXLqEzxt9qCyQudotPRqaAhcQQ4PmQSTdhn0sK9kWZ9bSe4Czkt9F7RUBc8+mrEJwmB2/b6dUbc8lbtIT+ldnUQVMOFfIrME4EPHbzaoG/nGriobCA94eXb9sl7kgPELPWMdWgj1H2tnjtHetDESYSjxHPWLiGoJXATsnUkQVqRC6t+hRaUQw7nbMjrTcUZyucE/XxERM4LJhZspPu2Ubt8E8J72sEhRKt3kaI/kqW2HDw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7901.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39850400004)(396003)(346002)(366004)(376002)(451199015)(33656002)(110136005)(86362001)(52536014)(4744005)(38070700005)(122000001)(186003)(83380400001)(38100700002)(9686003)(26005)(7696005)(71200400001)(478600001)(76116006)(66946007)(66446008)(8676002)(316002)(91956017)(66476007)(66556008)(64756008)(6506007)(8936002)(5660300002)(2906002)(41300700001)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5320 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3157a6a-b0a6-492b-e05a-08daa2436655 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fJx0JJileoFaw8MpJdudk6pVAbJ6VdsM9ch1h4bN8E1/6BWJu49Srtk2y+qmzttJ9Vshd51NmRqDz/NfzgLSK3Wlu0Vqf1vO+q0EUB9bEwK/y0ZIx/cWcvNFgSWwwzcbbsdZzwC1qYT6+8x84hUhCn1oa0QQ8d303eAtrQO29Ks/feLw8ePcAif5u0bPouhGmqXErdzSg3pW5EH4ZOZnP9wUvQksGyQk6srcWXp3rLtxu4dmHTbOgX8ys+wsAuofyU/eSmxdH9imyFWs60onpXxWV5o8spNSj5WoMRp8+zb1DCMU4GUSuWi+n9NGx3iInCgYR/SmoHThvz2QIfAqrUSnb7BoC8EzPfxQpVk+BfznsH37FKOSKeVMDjUJPaRtZjkOoeBbFi0XKcDAxmgd9wxUKjYWHWBGyA60oCK+RFRT18CQi5LGl1K8yiYfyyKpBkHGMv343W4FXH75VQ96Z9cJH2RfOW/1/SoF3O1eBFjRGAwaA9sAszwlP1XGf/U+qXcxLKZOcL2JXOgejOgJHLUflZvZZ2FAp/3wATs7PHxMBjmBcQQnwABW36yWHXPc8NOpI0vautDC6CvAScqninXp/r3v5pypX9SyfyOEzivv3bp4jSLdtK9pa+vkkFB3rzsGzKSnA0ghn7W6daxe+7WIrBOrGj4BJh8UK/sofrLdJTcdW7g8nKP2rWABap3j0vSIBWVBvvHFwusTTybvL6m5MTbHm69o/3zbqJzRJ8IR4JcE1ypJev7bhRh9UPzCl06GygW5Pm51KqPhUs+/VA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(9686003)(26005)(356005)(40480700001)(55016003)(478600001)(82310400005)(40460700003)(86362001)(41300700001)(52536014)(8936002)(316002)(110136005)(7696005)(83380400001)(2906002)(6506007)(336012)(36860700001)(81166007)(47076005)(5660300002)(33656002)(4744005)(186003)(82740400003)(8676002)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 17:53:04.3358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 348878ec-0483-4070-311e-08daa2437584 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7382 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= +static inline int=0A= +__getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)=0A= +{=0A= +=A0 int save_errno =3D errno;=0A= +=A0 int r =3D __getrandom (buf, buflen, flags);=0A= +=A0 __set_errno (save_errno);=0A= +=A0 return r =3D=3D -1 ? -save_errno : r;=0A= +}=0A= =0A= How does this work? If it fails, it returns the negated original errno, whi= ch=0A= doesn't make any sense. It can be zero and so it would imply success on=0A= failure... Shouldn't it just return r as it tries to preserve errno or do w= e need=0A= if (r =3D=3D -1) r =3D -errno; before we restore errno?=0A= =0A= Cheers,=0A= Wilco=