public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "fw@deneb.enyo.de" <fw@deneb.enyo.de>,
	"peterlin@andestech.com" <peterlin@andestech.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: [PATCH] malloc: Fix clobbered errno when getrandom failed [BZ #29624]
Date: Thu, 29 Sep 2022 12:42:16 +0000	[thread overview]
Message-ID: <AS4PR08MB79018834DCA496D0B5F2369083579@AS4PR08MB7901.eurprd08.prod.outlook.com> (raw)

Hi,

Also note the getrandom syscall is redundant since random_bits uses
clock_gettime. There is no need for a cryptographic random number here,
so the syscall can be removed.

And in places where we do want to use getrandom, it makes sense to
wrap the syscall so that we avoid introducing this bug in more places.

Cheers,
Wilco

             reply	other threads:[~2022-09-29 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 12:42 Wilco Dijkstra [this message]
2022-09-29 13:25 ` Adhemerval Zanella Netto
  -- strict thread matches above, loose matches on Subject: below --
2022-09-29  8:33 Yu Chien Peter Lin
2022-09-29 10:00 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR08MB79018834DCA496D0B5F2369083579@AS4PR08MB7901.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=fw@deneb.enyo.de \
    --cc=libc-alpha@sourceware.org \
    --cc=peterlin@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).