From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2058.outbound.protection.outlook.com [40.107.104.58]) by sourceware.org (Postfix) with ESMTPS id 4B81B385354A for ; Tue, 6 Sep 2022 18:41:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B81B385354A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bofQjlguQkeEtctd9iSkpy9T74EYJ40Sb+orlgEtQ/hzp5YnRtmB2eK6gT2Q5PjYmRKNC507pzbpp5ZgDzfBEDi7I5Luobu6coL8CByPIAg2FUuRLZ5totVPBCLuuXXWQytsOnNJEhydAO5J/bH534tSQCy7nq9QbOjWRAwNiMP3yxQJbW51zR3rRtXY2rlUV7TxxwOoJBodLBy0pe88h++NsXxRIKZ5yuIC6bdXS4W3sbjfq7UcyeQfx9hw9SZTaW+lDjpgPKynUESvRLen5bEynlykk0s7Bo5klCltExkoPUKch7u3SJ9+ad3O6kj+CTpYGEXc7oZSFXPaEGXLFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIlAI+AgGbs3YVVIEzUwJU+xJhdboZm22zl3dOvoQJU=; b=n2ZdjUXSEOHu++/U2Ek6YhpjzTdJifDNLijRbyErE2mIAPGc3gx2Y42eQ2z7R7XgWrLOw6m4NowNL7RN7O+pw3xRojDInjofp6+ThFjif5JI3jt2GPrK1ywpKn8DP7Wi1wqkyH2bWGb8xj06XX4XwmJgrOfyIO8pxZK6RtgX4CvR8pGWp86yeaQJlgbkmMzOoPfZ8ZbBENe/+Q8Tztzf4EHBHLqTmhtjYaH7H32gsX7G9cJMEWnHg2ICHjbch/2pmZEN5WrN/wSw4S3PdtoGUUGPqcqNQNJRxotVEEYuJhlAQ04UBpFpUbeq2ynI4goJjaEHhibHzBISPxU+PRHUZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fIlAI+AgGbs3YVVIEzUwJU+xJhdboZm22zl3dOvoQJU=; b=aUofqIhY1BiZ0VeSaUiurEtXBUpbHYaSlQAEtajeZjZ6llNmZMc7Of/Xutn9eZrgu6X3z5YRAhYl+7UR46Hn3r8Ns3Xkuatu1ZkT66DvXv4RMfZSMArOU44ebIHHhL5Yugr4UwZHjQv/v17RrXG13CAY+29UA9FLXuKJ929Ag7c= Received: from DB8PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:10:110::40) by DU0PR08MB7567.eurprd08.prod.outlook.com (2603:10a6:10:317::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 18:41:20 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::df) by DB8PR04CA0030.outlook.office365.com (2603:10a6:10:110::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 18:41:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 18:41:19 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Tue, 06 Sep 2022 18:41:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ab595164ef5e0a1d X-CR-MTA-TID: 64aa7808 Received: from 7dbfcfc392aa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBE5348D-A9FD-4ADC-ACF4-22C16914B245.1; Tue, 06 Sep 2022 18:41:13 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7dbfcfc392aa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 18:41:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNBci/coDyWg0RKN+srGSSZ2zmEuCZ8P5mu2qRaL9nLpYrSULjMFTqft5+5YFtcZs5jA1+ueRBhX9hU2BfgwuHTo9mlbCJ+LwFGSvovhvd5kCI93Rc6yxQ7IsKXk8mWrSUgJ7oC+JkOeAQExIE4uzkumETguZyIGugNGO63MfRcNxWRBXp7GOfeGht7pBnP+xAJOVc8auOHZ36kjjVY1Z76/cqov4s4O4vOBjVZsU9q1Y1rgRaacignmDhIjjmV1WZtToIgYWxzPy9DwCbCEW2ou4qKpKt38ZUSehn0B/ZYbcSrAR/6wXuOzGQYLPghXTq7d4VwkOXIZehxkS2kCTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIlAI+AgGbs3YVVIEzUwJU+xJhdboZm22zl3dOvoQJU=; b=MvnGBhj/rh0K6nAgOlJc+N/2IZLyfhSdyPpD79wMhSDR7kgsn+x6J0seYJt4skTcHNS1Ql4JxOLJqdWGL01zVlj7wquQBVGwzXm7ZE0LUTEczHZMWodwUifq4Bo7HhpRlKZPmpzC1LtGSqrDTsm+UPX2zZ5NdIT0gPwK0hSNv922989dK/q9s+NqoxcJLoB37QatbhXSAkulCv8ZQnLNuDXtOnLS+segIYSXurOYxnIs90o1U+ddDwbpwbGifeCfG9IctWCC/AFCebNB47oee2HP7afYlbYPzej+guUiCwjYN9Wky9H39xBfbSJK8jwwRfPnRac2eKjvmExATEMgFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fIlAI+AgGbs3YVVIEzUwJU+xJhdboZm22zl3dOvoQJU=; b=aUofqIhY1BiZ0VeSaUiurEtXBUpbHYaSlQAEtajeZjZ6llNmZMc7Of/Xutn9eZrgu6X3z5YRAhYl+7UR46Hn3r8Ns3Xkuatu1ZkT66DvXv4RMfZSMArOU44ebIHHhL5Yugr4UwZHjQv/v17RrXG13CAY+29UA9FLXuKJ929Ag7c= Received: from AS4PR08MB7901.eurprd08.prod.outlook.com (2603:10a6:20b:51c::16) by VI1PR08MB5454.eurprd08.prod.outlook.com (2603:10a6:803:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 18:41:11 +0000 Received: from AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::b58b:c477:7fd2:77bf]) by AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::b58b:c477:7fd2:77bf%4]) with mapi id 15.20.5588.010; Tue, 6 Sep 2022 18:41:11 +0000 From: Wilco Dijkstra To: Florian Weimer CC: Wilco Dijkstra via Libc-alpha Subject: Re: [PATCH v2] Use C11 atomics instead of atomic_bit_set/bit_test_set Thread-Topic: [PATCH v2] Use C11 atomics instead of atomic_bit_set/bit_test_set Thread-Index: AQHYwiA8KLGwLCNfj0Cr3zYKGWugmg== Date: Tue, 6 Sep 2022 18:41:11 +0000 Message-ID: References: <87mtbc66t4.fsf@oldenburg.str.redhat.com> <87o7vs4cxh.fsf@oldenburg.str.redhat.com> In-Reply-To: <87o7vs4cxh.fsf@oldenburg.str.redhat.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f9a6d1d4-590d-423c-7b00-08da903763d6 x-ms-traffictypediagnostic: VI1PR08MB5454:EE_|DBAEUR03FT035:EE_|DU0PR08MB7567:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: J1/pI7yYZKYprMipuKJeCoXMgonAwvKVUNaA+JpnUy+xWMxWxHEAzKcrE2mXAJiThb6RLzctvhdreBqjBbIWklPjt7H2YXTQ7IrAD0nfEAd8Yl9ZDR0jW0nJSyFSUgGlc4xd9f5JoWAmR/Ii4pqMrHxTvtQWnDkLzozYHKVljjbJcsmxbjYAeO7P4vGHJPqsxnbcCD9d5iFMCXSq32TSXI412G/a25yr5/yzfHLwbiEahfJweLWLSNfCO89gzeB7XbIiadHlusBt9c6P9188xMMbvkG5WQwDfIaeQzt9+6JnXjHBUe7pyRsMc3mJ2/i7kZwMh0KMeNThu08Gd1vTtMT2/aOh/upzZNEBebyGTB5qOU/STpJNKV0pTQBY3qarnmQVsN8gS7QcxjaRGyiffk2vaJeAihHeeCt52zmDnytoA+ksFZIgy3um4YHbzRjJXltjidMzg2JJ8MgAqqbIGlY946fhMNUDTAw9H6YlYBVgjhY68jAGBzHTehRB6LHAQvGJbXIlEKee1FAPy7uwJrfUSvBCh748B53Qr6F/9rbNYLonyRrw4FoMu2tCs5ZUiVwLvCtn9ioYnGbxPENM9Bz15NDg4qb1Q1GVmhZHGt1ZCIDDF3+/m86+m2sEuoN7Y9Aoeqje0ErbnuSBbsXpImW9RaMFe/iPZTEvQPF46ZdzLGGVgjL+rxnFcZ7Yw6KqNCgCJI3WETGeX3QhuKJ0d8N/RBoRWE1+IuZ8mih4k0LKpKXms1/0uIiwniyUruIj1Fhf1gNH8hURuphnOGSDLw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7901.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(6506007)(9686003)(122000001)(26005)(5660300002)(186003)(52536014)(8936002)(2906002)(86362001)(33656002)(478600001)(7696005)(71200400001)(41300700001)(38070700005)(66556008)(66946007)(64756008)(66476007)(8676002)(4326008)(66446008)(76116006)(6916009)(55016003)(91956017)(316002)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5454 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ec6d255d-0262-4cbd-5c7a-08da90375ed9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VyrPhQH/ivI1Bfj6g/Zn+GeteLpPQlpEj9RTxy14u+lfwfiyTHE5rdAKmXEZl3JBNgK76EA4gHu01uneegLFaC1dp+VZ/JDLI/PuNv/89htSqZrWs9JygH9a1uyOJ4SpFy1rsTN+lOljrSiISXNMo9LY+e8GdlM4vQi8AAjwSsb3xkmyVQKaOcDELfW6GLfENnh1oL0Pf+p8wi7o2ZG5eKFIAm408bjymo7iFqCW0lB2jka/bqyH0QVHKnAWWXCIRX426RcpKpNZt38vDk7lzOQTxKfUc2uXjrgJGeJ5I5wj2j0tPbwyeySCHe4V1MHlhC37wGAvaBc80bRBUDptR5qf2iAc/VDNZInw8U9g/KTSDHaR4olkJLXWj4tVd+T12cZJ4iKzeU2E9iuRKBW368hTQiIsKjJH/ELgmLFs407sSTzz2iE+G7YF/wV7R93JgH5gEN9ayQrIZNMIoaxcKvkYeahIUGqp5TjkHUEF/h+zyGjfiWo2urlPSjWR8JPsuvRJfSmP20j1PJzooia8J6lXy9qq0CcZULI+YC5y5zFlt2cUVWNItjavFiNL2XRNMTJb9rtYBYfIaSMLL3csUm+o654ogVDINCrXw6oL032D6puWuwPmV0vt3GMXrZGJEvthIIWpvImOada8iKDpNlgLgG3lssKr6bLIAFi0N02cNPZuELy9jVOz25SOIFaC19UJ8Z2suaxEUQn79UQAGDQHtRshpb+8zvHtv9v7TYvAnYAvc3juqKsqx+RFkPc20yo32lfvNI1P439GJse1XA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966006)(36840700001)(40470700004)(82310400005)(40480700001)(82740400003)(36860700001)(81166007)(356005)(316002)(26005)(52536014)(41300700001)(5660300002)(336012)(33656002)(9686003)(2906002)(40460700003)(186003)(47076005)(4326008)(8936002)(6862004)(70206006)(55016003)(478600001)(86362001)(6506007)(70586007)(8676002)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 18:41:19.8791 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9a6d1d4-590d-423c-7b00-08da903763d6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7567 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_DMARC_NONE,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Florian,=0A= =0A= This time with the right patch:=0A= =0A= v2: Use relaxed atomics since there is no MO dependence=0A= =0A= Replace the 3 uses of atomic_bit_set and atomic_bit_test_set with=0A= atomic_fetch_or_relaxed.=0A= =0A= ---=0A= =0A= diff --git a/nptl/nptl_free_tcb.c b/nptl/nptl_free_tcb.c=0A= index 0d31143ac849de6398e06c399b94813ae57dcff3..86a89048984da79476095dc64c4= d3d2edf5eca74 100644=0A= --- a/nptl/nptl_free_tcb.c=0A= +++ b/nptl/nptl_free_tcb.c=0A= @@ -24,7 +24,8 @@ void=0A= __nptl_free_tcb (struct pthread *pd)=0A= {=0A= /* The thread is exiting now. */=0A= - if (atomic_bit_test_set (&pd->cancelhandling, TERMINATED_BIT) =3D=3D 0)= =0A= + if ((atomic_fetch_or_relaxed (&pd->cancelhandling, TERMINATED_BITMASK)= =0A= + & TERMINATED_BITMASK) =3D=3D 0)=0A= {=0A= /* Free TPP data. */=0A= if (pd->tpp !=3D NULL)=0A= diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c=0A= index 870a8fcb34eb43b58c2260fee6a4624f0fbbd469..77048bd4c148b0b2fe4ef8b4a2b= f82593fef2d57 100644=0A= --- a/nptl/pthread_create.c=0A= +++ b/nptl/pthread_create.c=0A= @@ -487,7 +487,7 @@ start_thread (void *arg)=0A= /* The thread is exiting now. Don't set this bit until after we've hit= =0A= the event-reporting breakpoint, so that td_thr_get_info on us while a= t=0A= the breakpoint reports TD_THR_RUN state rather than TD_THR_ZOMBIE. *= /=0A= - atomic_bit_set (&pd->cancelhandling, EXITING_BIT);=0A= + atomic_fetch_or_relaxed (&pd->cancelhandling, EXITING_BITMASK);=0A= =0A= if (__glibc_unlikely (atomic_decrement_and_test (&__nptl_nthreads)))=0A= /* This was the last thread. */=0A= diff --git a/sysdeps/nptl/pthreadP.h b/sysdeps/nptl/pthreadP.h=0A= index 39af275c254ef3e737736bd5c38099bada8746d6..c8521b0b232d9f9eeb09a7f62e8= 1e8068411b9f3 100644=0A= --- a/sysdeps/nptl/pthreadP.h=0A= +++ b/sysdeps/nptl/pthreadP.h=0A= @@ -43,12 +43,6 @@=0A= atomic_compare_and_exchange_val_acq (&(descr)->member, new, old)=0A= #endif=0A= =0A= -#ifndef THREAD_ATOMIC_BIT_SET=0A= -# define THREAD_ATOMIC_BIT_SET(descr, member, bit) \=0A= - atomic_bit_set (&(descr)->member, bit)=0A= -#endif=0A= -=0A= -=0A= static inline short max_adaptive_count (void)=0A= {=0A= #if HAVE_TUNABLES=0A= @@ -276,7 +270,7 @@ __do_cancel (void)=0A= struct pthread *self =3D THREAD_SELF;=0A= =0A= /* Make sure we get no more cancellations. */=0A= - atomic_bit_set (&self->cancelhandling, EXITING_BIT);=0A= + atomic_fetch_or_relaxed (&self->cancelhandling, EXITING_BITMASK);=0A= =0A= __pthread_unwind ((__pthread_unwind_buf_t *)=0A= THREAD_GETMEM (self, cleanup_jmp_buf));=0A= =0A=