From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2042.outbound.protection.outlook.com [40.107.247.42]) by sourceware.org (Postfix) with ESMTPS id BF72B3858D1E for ; Fri, 30 Sep 2022 15:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF72B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IgCsG0eKV9mVlAygfMFz/InLeg3STFl/5SiKEuOpOjekzjQ6gOGQ+eGXxFdiB2U878aYmR2bPbWl23GWjb6XrEY1u8cFl/qstAn145O2IVP8LAveiGgY+ovfOsBx2W1eDbsCafcPnF6zI0nSQXJzqfJ8c1X020iuApyadDB56bhsAIbZqKH5e2Z7m20WgyTQGqBaYP9Yv/pVq1ZjsC4aQee90NgdqMSMz8876iSNCv0IUZPcnUIehBMExQ4fq9Oq8faEN8x9GysW1NqDL/PONYyEa5FLHsOAmLEqZxvg2YY9yDAr6lMJaEBQaxvPpRpKYyG35QgYwFtdzq7DZX/tsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMkrffdRmhRrn1p0jMjLa6WbpuauOLTjuLSVDMqqQcA=; b=ZeW78CAk1H2RsnVVh/JC6rNXi4r2n5apDuNzpTEalY3H2tGLU3dnnmAFROSBw/l2oN97wJ9X5eDwFJXVfyf+RAdvZ7ncmXtfbDLmY8XUeSg+aoXvgRz4n2IUFS4KlCROyKnFUg0TccZCclRnV8A2YepMJSAcoKx6dA+6NWaDXPmVKSuAdbXCu0GdTEQoORMOMo1BjIWmnZjYKS8UMR6vnNOzYjzJvW+pmYIn0lOTcKJdyJZPFtok04eycj+WqJeKUWfAlmex6tngcdRVyIB0ksJYGiCLZHkSMZvxExxgIHjzPbr31jVA2qgBhSPF6KwIaGEJGLq4bH+z2AKLYtJfJg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMkrffdRmhRrn1p0jMjLa6WbpuauOLTjuLSVDMqqQcA=; b=dj0PqmYyJkXzJfSCTRtDkjmaKqOGrGE3Q/Uu7AzhmCmraphtAiqmlGBXOFctNCxjLnnNxo7cgdsQ66cVTNHzDS0u1bfc7GGC5aBEWZK+f1s2FmqmIT1oTIktJ4OWipH3i43F13YMEiYK8hxYWLEjexUXgFPoFJCdgB2q3x66oUo= Received: from AS9PR06CA0374.eurprd06.prod.outlook.com (2603:10a6:20b:460::29) by AS8PR08MB7989.eurprd08.prod.outlook.com (2603:10a6:20b:541::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 15:05:26 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::10) by AS9PR06CA0374.outlook.office365.com (2603:10a6:20b:460::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Fri, 30 Sep 2022 15:05:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 15:05:26 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Fri, 30 Sep 2022 15:05:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 131c96547c47e0d0 X-CR-MTA-TID: 64aa7808 Received: from c32595d38df4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83EFA730-AB51-422B-B06C-EF4B450FDCF2.1; Fri, 30 Sep 2022 15:05:19 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c32595d38df4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 15:05:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KXsgR4xVe5F1y/s1jBPlMSluBtpgCHrMzP/t5yEyu3tfYZHPPQlJ8UW/i1cToxQw8v14pnVvLs6b+RvVOxfAhBb/KjdvmhjQqjx9r+FjrgfOg7zXKEIvNU7PEmuVQ71mlmBWGcBA4mBeErpxU+9nlOYRdx9Bdo6WbD8OFoTgbJYZUIsiIqSWfsYHMgkZTV44xQTnf2NMIiloh5cvNvFp7fkUHYZnFIlFAYf/ya7loiOlDJIxfrVeh/FnFjgVD2tnYbCDWHzrlqOf2zGeQV2FMlUD3/VmgZHYe4WNBSqSdf7WDQm3oJsbesyWhc8XL+wWOl8TQN4tJKaKc6pEXM59/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMkrffdRmhRrn1p0jMjLa6WbpuauOLTjuLSVDMqqQcA=; b=SSjUtalLU6b3E2ES57HFaGnLW7ENWjnPvHgMrVk310gJdXGbEEvD3kbsQIu0RP9mlBDmwyBpoqa3fiSV+lpI9L1n9SnBDgpYeu8jwhmMLWYfGtoGWtTgZisLgELu6K+R6ASMw9MP2mYL/HB9hs76Z4Yp6qFfK3aIXWqjQxo9WCC7HF4Ss4lz3LXGt5OBEli6hjGIqgf0nr0R1P27u8tYvx8wC5xQV8nZ8h7zk33AA5VWSOMx6pp5f1GnsMlkQe+41UhvtwuWWV1qIlxwdKlGcTrCgZXVNdoacd7AltfwO5uSRUiYvcQq8ij/RkuGP1H5Q+/jH4O8Cwp1rACP4X12/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMkrffdRmhRrn1p0jMjLa6WbpuauOLTjuLSVDMqqQcA=; b=dj0PqmYyJkXzJfSCTRtDkjmaKqOGrGE3Q/Uu7AzhmCmraphtAiqmlGBXOFctNCxjLnnNxo7cgdsQ66cVTNHzDS0u1bfc7GGC5aBEWZK+f1s2FmqmIT1oTIktJ4OWipH3i43F13YMEiYK8hxYWLEjexUXgFPoFJCdgB2q3x66oUo= Received: from AS4PR08MB7901.eurprd08.prod.outlook.com (2603:10a6:20b:51c::16) by PR3PR08MB5611.eurprd08.prod.outlook.com (2603:10a6:102:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 15:05:16 +0000 Received: from AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1]) by AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1%8]) with mapi id 15.20.5676.017; Fri, 30 Sep 2022 15:05:16 +0000 From: Wilco Dijkstra To: Adhemerval Zanella , "libc-alpha@sourceware.org" , Yu Chien Peter Lin Subject: Re: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638) Thread-Topic: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638) Thread-Index: AQHY1DmbCIwlBVxRVUmqbR07un0yZ634ErQo Date: Fri, 30 Sep 2022 15:05:16 +0000 Message-ID: References: <20220929192756.3310704-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220929192756.3310704-1-adhemerval.zanella@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7901:EE_|PR3PR08MB5611:EE_|AM7EUR03FT026:EE_|AS8PR08MB7989:EE_ X-MS-Office365-Filtering-Correlation-Id: ea3002e8-6af0-4f7c-f523-08daa2f534e8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GfEtcVQR+rr3LgKxgLEdig9Y2ePCfizS9d3MF6xwoTUlJ2TD9C5U4WUtyL5XYnZUBddIU4PDE7wEMPtvJyiDR5UQU+pGD+85m6+/dM/RcZs698NI6YY/bV2bGaLCKPkQz/s5Zvd3/ogTbhKPZctfp3sTeDSLiEhNCRuUUb3WpUFZzkjp8JOnW37kc4avCs6syjeRDtI3VQIHD9N76aKjgB0thcS7VORd4BTK99AghGTejEOM1Nwl9azktiqRgksozVE/nAhHiYMuFWQj7xbAWxEeZ69rNq3TAyYOsqTWRWBbRc3n4Y3NzSFCwrl6wtsSueCOI+3YqO3wOWAF9uXVznlRwoYWIDmPqkem/2yv8g/Ms5GRaU2eprxpMcfWGMlvhw9JOIpIonFkYaBUhhdzaRXjhuuIYvpqa3CH++k3DzXiA8YT0jMPcRT2izwxoUesDtgImSQZ2kWbOmuhjroQWrxu6/WGrSSQq4PjgNVD7JOXFll3XcQKjEaV7cf1onqSn3hn4/bX29YSxAzJ9Dsy8ZrvQti0NwrXQkHRPq0XdwdYZORhALVxZOAS8oIWR/jFJQA+xx3/cIGZj4QEdqblfLHS6IgMdvg/wSlRQH5zPLIubrC1H/IYkyafooutp581ZTYrs2PLEB5m5gU0Sl9SUBg9EXb9JCKLb5g7xW903OgS0tpQ0LPSsRi6G0wFcaM5IlPXe5RweTWXALfYpUOBeLmNyeZd7Hg7Qo8qMcZKo1nS/BX8QNVT2MoFmC02zB+ZQ1BgPh8fa3lUvGWALYd/wMhr9ynfvia6+Yg8KWkrMuwLu5GY6uRE0VhhAx5MzHFQ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7901.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(71200400001)(2906002)(38070700005)(66476007)(66946007)(86362001)(55016003)(8936002)(478600001)(38100700002)(76116006)(91956017)(41300700001)(122000001)(186003)(8676002)(5660300002)(26005)(9686003)(33656002)(64756008)(316002)(7696005)(6506007)(66446008)(66556008)(52536014)(83380400001)(110136005)(42413004)(32563001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5611 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5075abc6-1521-46b7-4856-08daa2f52edf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O8MrDceMQJmiqWIkORri6/8/A9oO7K8g3R5oSnmHEbUCBi8gHrtoMjMauqh6iy+spUJd7PouQpVt31GRTuOz8de7gR8NC0jqOadlV6WRlCZlSZ+kahYdCpO1dEt0j68LCfpVKynF0Fueacpkh8l8KFcYqNAB+k5K3ir94uF03cdojke4xL2b41J96y+LPiy6YtmABfRSlKitY5jJhNTVZTMF4xITXMqRxjp7D5MMirNFPzXSRGzi8ip+hvN0A5ZZevttQatGl5GH5RKyNHUtGWFNXuzxhLHksrxONviSCLHTbBGRGQbov1JePmaVJ2sMFp8dsBbxXtMr01ZEXW4cgoGtaZ4LY5km7/PAoYc8B29IAgnpfngnmqBd7ime/xwmICwqx+HOpG5aaGapJjLk1mwF/2z4ldn9VltUWdg26lRz4ER+fqG4rOdXRXkeI1IdIhKkTUjWF/Q/zYGAcd38KeebHHiSP5DoCDsWSi3mUgF5jv2fs0l24Ws9gDF/MfDlluRkn925UWaIxxQAmwsGU6DzjokRq1lCc7mespBoxyTK491TRf36VKcvvA7Yojc2Ci9cxI0r7+2/7OzaghyDobr+xIg45+Z/82XQCbcTAZJ9taNOuZPsosylkQTWiPZdj9CshwH1yMjI/fVtVwYoI1sHPr4OPJRn1Bimkc1NM6OCqqGCKuxLTHzItS4KoqjBezFaaibCtosDVKlnpyRya2maQpbqG4O+yQD+Hdk3P4OVndocpbvGGthV/Ivj4MHDQP4g0KqQtmXK1+MpnE6IQAz+JD8qPscrz2Z2j9/D+I/sHYZlzoYKML2MUtScop44 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(70586007)(186003)(336012)(83380400001)(82740400003)(47076005)(356005)(81166007)(9686003)(2906002)(5660300002)(8936002)(52536014)(41300700001)(82310400005)(55016003)(40480700001)(40460700003)(478600001)(26005)(36860700001)(7696005)(6506007)(70206006)(8676002)(316002)(110136005)(33656002)(86362001)(42413004)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 15:05:26.4091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea3002e8-6af0-4f7c-f523-08daa2f534e8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7989 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= This looks good to me (and will work on ILP32).=0A= =0A= Reviewed-by: Wilco Dijkstra =0A= =0A= Cheers,=0A= Wilco=0A= =0A= =0A= From: Adhemerval Zanella =0A= =A0=0A= Using an unsigned type prevents the fallback to be used if kernel=0A= does not support getrandom syscall.=0A= =0A= Checked on x86_64-linux-gnu.=0A= ---=0A= =A0stdlib/arc4random.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= 2 +-=0A= =A0sysdeps/unix/sysv/linux/not-cancel.h | 2 +-=0A= =A02 files changed, 2 insertions(+), 2 deletions(-)=0A= =0A= diff --git a/stdlib/arc4random.c b/stdlib/arc4random.c=0A= index e417ef624d..960a38f295 100644=0A= --- a/stdlib/arc4random.c=0A= +++ b/stdlib/arc4random.c=0A= @@ -34,7 +34,7 @@ void=0A= =A0__arc4random_buf (void *p, size_t n)=0A= =A0{=0A= =A0=A0 static int seen_initialized;=0A= -=A0 size_t l;=0A= +=A0 ssize_t l;=0A= =A0=A0 int fd;=0A= =A0=0A= =A0=A0 if (n =3D=3D 0)=0A= diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux= /not-cancel.h=0A= index a263d294b1..cf35c8bfc9 100644=0A= --- a/sysdeps/unix/sysv/linux/not-cancel.h=0A= +++ b/sysdeps/unix/sysv/linux/not-cancel.h=0A= @@ -68,7 +68,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *i= ov, int iovcnt)=0A= =A0=A0 INTERNAL_SYSCALL_CALL (writev, fd, iov, iovcnt);=0A= =A0}=0A= =A0=0A= -static inline int=0A= +static inline ssize_t=0A= =A0__getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)=0A= =A0{=0A= =A0=A0 return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags);=0A= -- =0A= 2.34.1=0A=