From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42]) by sourceware.org (Postfix) with ESMTPS id D806A3857351 for ; Thu, 29 Sep 2022 18:37:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D806A3857351 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Illu0JYCoFH7bbf2+TLWPy7yvEg0wJVq1+rZW1JjcxmH8Lov+8FNaw7DWFY6Rm2lIadIEM70H0cR6ryU9Nq12XY1/iep4a382kt7vE2d3sLE/Xzs8qs73XobORRVXfUcZjHIJMEvkXjoWmVSQK0wOi8oEABfKiGq7x3291I1Tfhj/testx0RL18yixFmJZrV6hOd3MAgRJIHSmL2IeKZGUzHJQPIrzgJ5BvBAwdvwmbEd0PTT5PaiIjsePL6smcKW64Y4sB+ZoKw9TaTQZhz6LenDwtve6Y924Cb0XINVgAvaqWZP2iGCs3+vkTUX1oVsAvyYKuwfovXjoT1BLy6bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AdjixjN9vzia38KRAPbYdOmv5LXyta/8U4qhzJclGUs=; b=kvN2RBfSKvgsYkthLtRznV1D7JT/bMgIGMbJ9rVEW93n44jjqwMc98RNxZU1Akozr37+Nh7dwoUBTUFW3nRnWIG+aK5lACdKOhCUVo8qChLMzYqomABa6Kf1gktsNNo/hxW4qh+za9HVuBTXCUbqFlRrseAhQe0rHljRP/42l1Q0y2wFhjrbineVvQEWBKAOTa7dF20M82mFdQp5g2wUh67/uFLiLIzKjhutCGEyUZa8arm4dXyhwj04FG3bGlnXyaGbOy/Lfw7y+pH70J89scAyKiWTLNcS/LJII/FDhJgP3fHHKBu7bWzCmAuneYj54lgEeX+pDZtEDg1VePMMRQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AdjixjN9vzia38KRAPbYdOmv5LXyta/8U4qhzJclGUs=; b=01pJCSRXfjQ1Khal7KAE6yWXy8DOI2o4/7ifvx9ylMFGjdckTKqiC//SsJtaupjbbc5js3WaPGPR88SAvE2GvGHYRPo2a9czsSeuupM/rxZ5gP31+88DU2sJYj7SJ7O+Jo44goTDr/mK/ClbAW4TuAlJSCpk6dV8dkTkCcSKef4= Received: from DB8PR06CA0028.eurprd06.prod.outlook.com (2603:10a6:10:100::41) by PAWPR08MB8813.eurprd08.prod.outlook.com (2603:10a6:102:335::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 18:37:05 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::24) by DB8PR06CA0028.outlook.office365.com (2603:10a6:10:100::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19 via Frontend Transport; Thu, 29 Sep 2022 18:37:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 18:37:04 +0000 Received: ("Tessian outbound ce981123c49d:v128"); Thu, 29 Sep 2022 18:37:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6c044697e8f973e4 X-CR-MTA-TID: 64aa7808 Received: from 745ac6f7f6d2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 39D1CC25-4B54-42FF-95E8-C717C5D99898.1; Thu, 29 Sep 2022 18:36:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 745ac6f7f6d2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 18:36:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKG6CwuBW6JYP1mmQzfV0I+/zPyWVEUv7VXcJ6utdjaAHN35r1GTfNS+ihCN5Az/r7CFTzucXjrwq3zjtSdGUoYQkbgKEfxDDv7EXE16lkkbx8KHVdO3NbDQX5vMd2Pm8mc+Nk+c1zvcfumWcF7pXSDOVgOSXpZtHAh9289i0ZSjM+oIWsLWnBo+eWENoktn1LgnGDTxU9hN4M5R2OYFUDCIHwKxF1jJmi6uddccNJDIkQeAoO8oC59dm2v5ElAQeOgfb2RbSW+gbG2Xqyw3Qtx5razYJSgx7JuTii1Qa+jcPCe5AJNqRueM2K1erojChyQbdycqingsAmh/DYRYrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AdjixjN9vzia38KRAPbYdOmv5LXyta/8U4qhzJclGUs=; b=a1vmhdJDgYXdysRVD1wubt3D41f0ngO9IPhGlVcC/qednvN3N+f16tmHKvcR4sxascTHlrzbn+h5IQwfenZtqKNa3vorwm0JSDZiqEWPnQo/ASYZp/5D39WhFPZCFGv57sCDOPyUwQufQ+W862ZghV61Lk8z1w7Z9s4z5BP8TOlJl+EAlgYYgq5r9P6nf6lTyhnLkLfBJixMUF+C2BGztrgkDPgSqeRb8Tqq4TFd+NY4ZXanRdz7okVyqDcDZ/jcGKgKThYsfdkZ2Uj8vYsqj+nOmFuoYrHaD/dvU55yT91HG7Br0Oq/MLaGoPWRoZk1F8VXYaxKqTfFIeUxzA/RgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AdjixjN9vzia38KRAPbYdOmv5LXyta/8U4qhzJclGUs=; b=01pJCSRXfjQ1Khal7KAE6yWXy8DOI2o4/7ifvx9ylMFGjdckTKqiC//SsJtaupjbbc5js3WaPGPR88SAvE2GvGHYRPo2a9czsSeuupM/rxZ5gP31+88DU2sJYj7SJ7O+Jo44goTDr/mK/ClbAW4TuAlJSCpk6dV8dkTkCcSKef4= Received: from AS4PR08MB7901.eurprd08.prod.outlook.com (2603:10a6:20b:51c::16) by DU0PR08MB9108.eurprd08.prod.outlook.com (2603:10a6:10:47a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 18:36:54 +0000 Received: from AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1]) by AS4PR08MB7901.eurprd08.prod.outlook.com ([fe80::4d64:ef01:4d4c:6ba1%8]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 18:36:54 +0000 From: Wilco Dijkstra To: Adhemerval Zanella , "libc-alpha@sourceware.org" , Yu Chien Peter Lin Subject: Re: [PATCH v2] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624) Thread-Topic: [PATCH v2] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624) Thread-Index: AQHY1Cyv25VOpC0u30ucRpxKVrHSl632uSbO Date: Thu, 29 Sep 2022 18:36:54 +0000 Message-ID: References: <20220929175526.2596756-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220929175526.2596756-1-adhemerval.zanella@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7901:EE_|DU0PR08MB9108:EE_|DBAEUR03FT030:EE_|PAWPR08MB8813:EE_ X-MS-Office365-Filtering-Correlation-Id: d24320e8-f662-4d35-17e8-08daa2499b6a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: K2bPCek9d3bVk7xWk9DJ2GxBlfW4UV55fFTChXkZ/RyGuDtigdHXQ7AV4csWdzZBsIK5NijtdZ/QQNKMPQILM4ShVQqc53ZnjfB378bN6f6cDlGD+ezl+rd4gwf/nJQ+Eo31p5oWGL5MFRiWyTmtcLH/zR81oGEqLyKysToRv4CkrQrYUvWL7V4cNn8uulZhfkj/wmTjfiniQbhxo8HgqHoO0EMlS9Zr2QW2Kv9B3NTTTjo+EaTJw+mLNIoLLtdOuNEVYyMZ0BhakSKSdfvKAlpbSUyyeHGlE8M9DDdtOvSEK/Ewje0DA+CbLXEUgHGtCCKLyrWobatRWzDgXXwpVqadiqWz/mUHbWN5A6ziDCBTQ0W0Iq/xgNVn4hRoTzq5BW0x1+GXFHW5hOB6IesnQcESWyBJrJkMUMrkf8jWJEfyMxhw3u8aEEgZgh/8kZe3dEfApWdZkxX9Jk5M5uSLH0xQxk+l3VKfQT1ihBX8Rq1si3VtQ5N8IpAsvn6NymUM5SU7e79sIwkUz/RTj7mK/G1z3eC7baUxr0Fh0Z/IrtmIPcvrwiykFrul/23NkM4qqpned5V62Y0A2S8XEAb5ubse3y58znI05qUiwLtC2TvhzpGU1haNhuU/M0GHPs64Rz0Jti/ffEQYKyndQ8ipLTH5rCZSbAQavp/vJkJ0pZ426SujxU+xF6N7nXACVZYNmrSmHCYbQ/5ziPgbqe3Bmlnr1E4Y5ywm3EFX/93zavcULlqG1uGJSGkyBXQWOaCxXAaPZFenpM6pDaHJ1saYKg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7901.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(83380400001)(5660300002)(38070700005)(38100700002)(122000001)(186003)(2906002)(41300700001)(52536014)(8936002)(55016003)(478600001)(9686003)(6506007)(71200400001)(26005)(7696005)(64756008)(66446008)(66476007)(66556008)(66946007)(91956017)(8676002)(316002)(76116006)(110136005)(33656002)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9108 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 227c8228-ad3f-4fcd-cb4b-08daa249955d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hyay6xuuOuZkIy8hofiyDsPr1nuzb+c5tH8ySjOq8YdpmZy+mdOjCx6L5A5hMtqw32nGILI6fjDWJwVqYmsC1415okw2g2UhcHV6aVYn7imm12dA8PvI1tQbeYIrP/LuuXo7g3qeZp0Wp3/dpZxfasYo/BHa71b0Cp8FaTJrGiH99kQql3cFPVRQNMMeKYZ5QuRWcaamQ/sOQ7A205gQ5Ly1Ukvole4mB3ud5PgW4zj+DTHdk+HkcLOAiZ/EPgOSl+TxIrTFA0pTUqdESnsGJmb8dvOduH6YcWWF2i1eaHI2VbVuH+D/1Fq3c0ojtGwG6T3aBrVE4OB5RgJxti1bKAdLUy5TlcfDo776T/COvtboC7zlXnfu1YtYTKl3FT02O75//k30/dK9TqOZoQGXVbhNHBKqcb3u6ZScVMNKHzjNP7zj++QbRxqnH0E4us5MIsv/6ppVEqoA8GaObN8Sp6miICnYUFFd9Jw3dz4S8Fto+SKMi4H1lih/ffMpa8fu+5rjlszExKScujQKghQlD5kgm8rXaJ2BDjOjzBa7t1Ff6tNeNNglVedjGI2L2lb6kvU8gjTYW4HbHWaqxN05eSOaWFzxB6xyvBv9rukm2C/aQxYwt5D0t/feORfZaJ2P7gWjPBM2XjdrGkZpX/pCSKraRA8MOB+QYkgkhcqJJ9tVq0GDeWK3D2/YekOczGL8GAlJXOlxNHOrmmNUzlDMWqBefDKAWTcebAIWmiv/FXqE1nC9epXQv7onobxPTOLMDaNYrmRY3PEFktF/EegGnQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(186003)(81166007)(356005)(82740400003)(40460700003)(55016003)(86362001)(316002)(33656002)(36860700001)(70206006)(478600001)(8676002)(110136005)(5660300002)(40480700001)(41300700001)(70586007)(336012)(8936002)(82310400005)(83380400001)(47076005)(2906002)(52536014)(26005)(9686003)(6506007)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 18:37:04.9923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d24320e8-f662-4d35-17e8-08daa2499b6a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8813 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= Another question, the syscall is defined as:=0A= =0A= ssize_t getrandom (void *__buffer, size_t __length,=0A= =0A= Doesn't this mean if we use 'int' for the return value, a large but valid s= yscall=0A= result could be interpreted as a negative error value? It sounds like all c= ode=0A= processing the getrandom syscall should use ssize_t rather than int. Or do = we=0A= limit length to something fairly small?=0A= =0A= =A0__arc4random_buf (void *p, size_t n)=0A= =A0{=0A= =A0=A0 static int seen_initialized;=0A= -=A0 size_t l;=0A= +=A0 int l;=0A= =0A= Should be ssize_t?=0A= =0A= +static inline int=0A= +__getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)=0A= =0A= ssize_t?=0A= =0A= +{=0A= +=A0 int save_errno =3D errno;=0A= +=A0 int r =3D __getrandom (buf, buflen, flags);=0A= =0A= ssize_t?=0A= =0A= +=A0 r =3D r =3D=3D -1 ? -errno : r;=0A= +=A0 __set_errno (save_errno);=0A= +=A0 return r;=0A= +}=0A= =A0=0A= =A0#define __poll_infinity_nocancel(fds, nfds) \=0A= =A0=A0 __poll (fds, nfds, -1)=0A= diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux= /not-cancel.h=0A= index a263d294b1..00ab75a405 100644=0A= --- a/sysdeps/unix/sysv/linux/not-cancel.h=0A= +++ b/sysdeps/unix/sysv/linux/not-cancel.h=0A= @@ -71,7 +71,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *i= ov, int iovcnt)=0A= =A0static inline int=0A= =0A= ssize_t?=0A= =0A= =A0__getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)=0A= =A0{=0A= -=A0 return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags);=0A= +=A0 return INTERNAL_SYSCALL_CALL (getrandom, buf, buflen, flags);=0A= =A0}=0A= =0A= Cheers,=0A= Wilco=0A=