From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Use C11 like atomics on _dl_mcount
Date: Thu, 1 Sep 2022 23:18:52 +0000 [thread overview]
Message-ID: <AS4PR08MB7901E4323CECB19822B179B1837B9@AS4PR08MB7901.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <5fd88725-8bef-2e26-420a-1216ebfa5cec@linaro.org>
Hi Adhemerval,
> Is the https://patchwork.sourceware.org/project/glibc/list/?series=10727 right? I
> think it has failed CI, could you submit again?
I'll rebase it. I'll probably move the files that cause all the conflicts into a different
patch (an alternative would be to increase the vertical spacing between all the
defines first so that merge tools no longer get confused).
> I thinking we are tracking two different issues, although they are correlated.
> My take is to first try to map the current code to a C11-like atomic, so we
> can always use compiler builtins where applicable (there are couple of
> architecture that we might avoid using libgcc for performance reasons), and
> then check if the atomic usage does make sense.
Yes, so I first mapped them to an atomic with the most appropriate MO (since
the MO of many existing macros is not well defined). We should look at
correctness in a second pass since it is already clear there are many concurrency
bugs.
Cheers,
Wilco
next prev parent reply other threads:[~2022-09-01 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 12:21 Wilco Dijkstra
2022-09-01 13:09 ` Adhemerval Zanella Netto
2022-09-01 14:19 ` Wilco Dijkstra
2022-09-01 15:30 ` Adhemerval Zanella Netto
2022-09-01 23:18 ` Wilco Dijkstra [this message]
2022-09-02 12:21 ` Adhemerval Zanella Netto
2022-09-02 13:27 ` Wilco Dijkstra
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 18:14 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR08MB7901E4323CECB19822B179B1837B9@AS4PR08MB7901.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).